Changeset 134156 in webkit
- Timestamp:
- Nov 10, 2012 6:41:52 AM (11 years ago)
- Location:
- trunk
- Files:
-
- 8 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/LayoutTests/ChangeLog
r134155 r134156 1 2012-11-10 Bruno de Oliveira Abinader <bruno.abinader@basyskom.com> 2 3 [css] text-decoration:none no longer valid 4 https://bugs.webkit.org/show_bug.cgi?id=101529 5 6 Reviewed by Ojan Vafai. 7 8 The getComputedStyle layout tests for 'text-decoration' and 9 '-webkit-text-decoration-line' CSS properties are updated with the correct 10 results for the 'none' value. 11 12 * fast/css/getComputedStyle/getComputedStyle-text-decoration-expected.txt: 13 * fast/css/getComputedStyle/script-tests/getComputedStyle-text-decoration.js: 14 * fast/css3-text/css3-text-decoration/getComputedStyle/getComputedStyle-text-decoration-line-expected.txt: 15 * fast/css3-text/css3-text-decoration/getComputedStyle/script-tests/getComputedStyle-text-decoration-line.js: 16 * inspector/console/console-format-style-whitelist-expected.txt: 17 1 18 2012-11-10 Noel Gordon <noel.gordon@gmail.com> 2 19 -
trunk/LayoutTests/fast/css/getComputedStyle/getComputedStyle-text-decoration-expected.txt
r134078 r134156 19 19 20 20 Value 'none': 21 PASS e.style.textDecoration is ' initial'22 PASS e.style.getPropertyCSSValue('text-decoration').toString() is '[object CSS Value]'23 PASS e.style.getPropertyCSSValue('text-decoration').cssText is ' initial'21 PASS e.style.textDecoration is 'none' 22 PASS e.style.getPropertyCSSValue('text-decoration').toString() is '[object CSSPrimitiveValue]' 23 PASS e.style.getPropertyCSSValue('text-decoration').cssText is 'none' 24 24 PASS computedStyle.textDecoration is 'none' 25 25 PASS computedStyle.getPropertyCSSValue('text-decoration').toString() is '[object CSSPrimitiveValue]' -
trunk/LayoutTests/fast/css/getComputedStyle/script-tests/getComputedStyle-text-decoration.js
r134078 r134156 38 38 debug("Value 'none':"); 39 39 e.style.textDecoration = 'none'; 40 testElementStyle("textDecoration", "text-decoration", "[object CSS Value]", "initial");40 testElementStyle("textDecoration", "text-decoration", "[object CSSPrimitiveValue]", "none"); 41 41 testComputedStyle("textDecoration", "text-decoration", "[object CSSPrimitiveValue]", "none"); 42 42 debug(''); -
trunk/LayoutTests/fast/css3-text/css3-text-decoration/getComputedStyle/getComputedStyle-text-decoration-line-expected.txt
r132043 r134156 19 19 20 20 Value 'none': 21 PASS e.style.webkitTextDecorationLine is ' initial'22 PASS e.style.getPropertyCSSValue('-webkit-text-decoration-line').toString() is '[object CSS Value]'23 PASS e.style.getPropertyCSSValue('-webkit-text-decoration-line').cssText is ' initial'21 PASS e.style.webkitTextDecorationLine is 'none' 22 PASS e.style.getPropertyCSSValue('-webkit-text-decoration-line').toString() is '[object CSSPrimitiveValue]' 23 PASS e.style.getPropertyCSSValue('-webkit-text-decoration-line').cssText is 'none' 24 24 PASS computedStyle.webkitTextDecorationLine is 'none' 25 25 PASS computedStyle.getPropertyCSSValue('-webkit-text-decoration-line').toString() is '[object CSSPrimitiveValue]' -
trunk/LayoutTests/fast/css3-text/css3-text-decoration/getComputedStyle/script-tests/getComputedStyle-text-decoration-line.js
r132043 r134156 38 38 debug("Value 'none':"); 39 39 e.style.webkitTextDecorationLine = 'none'; 40 testElementStyle("webkitTextDecorationLine", "-webkit-text-decoration-line", "[object CSS Value]", "initial");40 testElementStyle("webkitTextDecorationLine", "-webkit-text-decoration-line", "[object CSSPrimitiveValue]", "none"); 41 41 testComputedStyle("webkitTextDecorationLine", "-webkit-text-decoration-line", "[object CSSPrimitiveValue]", "none"); 42 42 debug(''); -
trunk/LayoutTests/inspector/console/console-format-style-whitelist-expected.txt
r131448 r134156 14 14 Style: border: 1px solid red; margin: 20px; padding: 10px; 15 15 text-* is fine by us! console-format-style-whitelist.html:11 16 Style: text-decoration: initial;16 Style: text-decoration: none; 17 17 Display, on the other hand, is bad news. console-format-style-whitelist.html:13 18 18 Style: NO STYLES DEFINED. -
trunk/Source/WebCore/ChangeLog
r134154 r134156 1 2012-11-10 Bruno de Oliveira Abinader <bruno.abinader@basyskom.com> 2 3 [css] text-decoration:none no longer valid 4 https://bugs.webkit.org/show_bug.cgi?id=101529 5 6 Reviewed by Ojan Vafai. 7 8 This patch fixes an issue where the 'none' value was parsed as explicitly 9 'initial' value. However true in a sense that the initial value for the 10 'text-decoration' property is 'none', the value itself could not be parsed as 11 'initial'. 12 13 The getComputedStyle layout tests for 'text-decoration' and 14 '-webkit-text-decoration-line' CSS properties are updated with the correct 15 results. 16 17 * css/CSSParser.cpp: 18 (WebCore::CSSParser::parseTextDecoration): When parsed, 'none' value 19 gets its own identifier value instead of explicit initial. 20 1 21 2012-11-09 Dean Jackson <dino@apple.com> 2 22 -
trunk/Source/WebCore/css/CSSParser.cpp
r134078 r134156 8237 8237 CSSParserValue* value = m_valueList->current(); 8238 8238 if (value->id == CSSValueNone) { 8239 addTextDecorationProperty(propId, cssValuePool().create ExplicitInitialValue(), important);8239 addTextDecorationProperty(propId, cssValuePool().createIdentifierValue(CSSValueNone), important); 8240 8240 m_valueList->next(); 8241 8241 return true;
Note: See TracChangeset
for help on using the changeset viewer.