Changeset 134530 in webkit


Ignore:
Timestamp:
Nov 13, 2012 8:42:46 PM (11 years ago)
Author:
arv@chromium.org
Message:

Update DOMException name: InvalidCharacterError
​https://bugs.webkit.org/show_bug.cgi?id=102128

Reviewed by Darin Adler.

Source/WebCore:

Patch 5 of 25 to update DOMException name to match the spec and Firefox.

Updated existing tests.

  • dom/DOMCoreException.cpp:

LayoutTests:

Updated tests and expectations.

  • fast/dom/Document/createElement-invalid-names-expected.txt:
  • fast/dom/Document/createElement-invalid-names.html:
  • fast/dom/Element/prefix-setter-exception-expected.txt:
  • fast/dom/Window/atob-btoa-expected.txt:
  • fast/dom/dataset-expected.txt:
  • fast/dom/dataset-xhtml-expected.txt:
  • fast/dom/script-tests/dataset-xhtml.js:
  • fast/dom/script-tests/dataset.js:
Location:
trunk
Files:
11 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r134528 r134530  
     12012-11-13  Erik Arvidsson  <arv@chromium.org>
     2
     3        Update DOMException name: InvalidCharacterError
     4        https://bugs.webkit.org/show_bug.cgi?id=102128
     5
     6        Reviewed by Darin Adler.
     7
     8        Updated tests and expectations.
     9
     10        * fast/dom/Document/createElement-invalid-names-expected.txt:
     11        * fast/dom/Document/createElement-invalid-names.html:
     12        * fast/dom/Element/prefix-setter-exception-expected.txt:
     13        * fast/dom/Window/atob-btoa-expected.txt:
     14        * fast/dom/dataset-expected.txt:
     15        * fast/dom/dataset-xhtml-expected.txt:
     16        * fast/dom/script-tests/dataset-xhtml.js:
     17        * fast/dom/script-tests/dataset.js:
     18
    1192012-11-13  Elliott Sprehn  <esprehn@chromium.org>
    220

  • trunk/LayoutTests/fast/dom/Document/createElement-invalid-names-expected.txt

    r103222 r134530  
    44
    55
    6 PASS document.createElement('0ascii') threw exception Error: INVALID_CHARACTER_ERR: DOM Exception 5.
    7 PASS document.createElement('.Ascii') threw exception Error: INVALID_CHARACTER_ERR: DOM Exception 5.
    8 PASS document.createElement('-Ascii') threw exception Error: INVALID_CHARACTER_ERR: DOM Exception 5.
    9 PASS document.createElement(' ascii') threw exception Error: INVALID_CHARACTER_ERR: DOM Exception 5.
    10 PASS document.createElement('   ascii') threw exception Error: INVALID_CHARACTER_ERR: DOM Exception 5.
    11 PASS document.createElement('֑sc.ii') threw exception Error: INVALID_CHARACTER_ERR: DOM Exception 5.
    12 PASS document.createElement('⃣scii') threw exception Error: INVALID_CHARACTER_ERR: DOM Exception 5.
    13 PASS document.createElement('िascii') threw exception Error: INVALID_CHARACTER_ERR: DOM Exception 5.
    14 PASS document.createElement('ʳascii') threw exception Error: INVALID_CHARACTER_ERR: DOM Exception 5.
    15 PASS document.createElement('asc i') threw exception Error: INVALID_CHARACTER_ERR: DOM Exception 5.
    16 PASS document.createElement('asc        i') threw exception Error: INVALID_CHARACTER_ERR: DOM Exception 5.
    17 PASS document.createElement('asciiⅦ') threw exception Error: INVALID_CHARACTER_ERR: DOM Exception 5.
     6PASS document.createElement('0ascii') threw exception Error: InvalidCharacterError: DOM Exception 5.
     7PASS document.createElement('.Ascii') threw exception Error: InvalidCharacterError: DOM Exception 5.
     8PASS document.createElement('-Ascii') threw exception Error: InvalidCharacterError: DOM Exception 5.
     9PASS document.createElement(' ascii') threw exception Error: InvalidCharacterError: DOM Exception 5.
     10PASS document.createElement('   ascii') threw exception Error: InvalidCharacterError: DOM Exception 5.
     11PASS document.createElement('֑sc.ii') threw exception Error: InvalidCharacterError: DOM Exception 5.
     12PASS document.createElement('⃣scii') threw exception Error: InvalidCharacterError: DOM Exception 5.
     13PASS document.createElement('िascii') threw exception Error: InvalidCharacterError: DOM Exception 5.
     14PASS document.createElement('ʳascii') threw exception Error: InvalidCharacterError: DOM Exception 5.
     15PASS document.createElement('asc i') threw exception Error: InvalidCharacterError: DOM Exception 5.
     16PASS document.createElement('asc        i') threw exception Error: InvalidCharacterError: DOM Exception 5.
     17PASS document.createElement('asciiⅦ') threw exception Error: InvalidCharacterError: DOM Exception 5.
    1818PASS successfullyParsed is true
    1919

  • trunk/LayoutTests/fast/dom/Document/createElement-invalid-names.html

    r103222 r134530  
    2727
    2828for (var i in nameList)
    29     shouldThrow("document.createElement('" + nameList[i] +"')", "'Error: INVALID_CHARACTER_ERR: DOM Exception 5'");
     29    shouldThrow("document.createElement('" + nameList[i] +"')", "'Error: InvalidCharacterError: DOM Exception 5'");
    3030</script>
    3131<script src="../../js/resources/js-test-post.js"></script>

  • trunk/LayoutTests/fast/dom/Element/prefix-setter-exception-expected.txt

    r105388 r134530  
    44
    55
    6 PASS prefixedElem.prefix = "." threw exception Error: INVALID_CHARACTER_ERR: DOM Exception 5.
     6PASS prefixedElem.prefix = "." threw exception Error: InvalidCharacterError: DOM Exception 5.
    77PASS prefixedElem.prefix is "before"
    88PASS prefixedElem.prefix = "x." is "x."
    99PASS prefixedElem.prefix is "x."
    10 PASS prefixedElem.prefix = "0a" threw exception Error: INVALID_CHARACTER_ERR: DOM Exception 5.
     10PASS prefixedElem.prefix = "0a" threw exception Error: InvalidCharacterError: DOM Exception 5.
    1111PASS prefixedElem.prefix is "before"
    1212PASS prefixedElem.prefix = "a0" is "a0"
    … …  
    1414PASS prefixedElem.prefix = "_0" is "_0"
    1515PASS prefixedElem.prefix is "_0"
    16 PASS prefixedElem.prefix = "×" threw exception Error: INVALID_CHARACTER_ERR: DOM Exception 5.
     16PASS prefixedElem.prefix = "×" threw exception Error: InvalidCharacterError: DOM Exception 5.
    1717PASS prefixedElem.prefix is "before"
    18 PASS prefixedElem.prefix = "·" threw exception Error: INVALID_CHARACTER_ERR: DOM Exception 5.
     18PASS prefixedElem.prefix = "·" threw exception Error: InvalidCharacterError: DOM Exception 5.
    1919PASS prefixedElem.prefix is "before"
    2020PASS prefixedElem.prefix = "aa" is "aa"
    2121PASS prefixedElem.prefix is "aa"
    22 PASS prefixedElem.prefix = "\n" threw exception Error: INVALID_CHARACTER_ERR: DOM Exception 5.
     22PASS prefixedElem.prefix = "\n" threw exception Error: InvalidCharacterError: DOM Exception 5.
    2323PASS prefixedElem.prefix is "before"
    2424PASS successfullyParsed is true

  • trunk/LayoutTests/fast/dom/Window/atob-btoa-expected.txt

    r108729 r134530  
    1919PASS window.btoa("éé") is "6ek="
    2020PASS window.btoa("\u0080\u0081") is "gIE="
    21 PASS window.btoa("тест") threw exception Error: INVALID_CHARACTER_ERR: DOM Exception 5.
     21PASS window.btoa("тест") threw exception Error: InvalidCharacterError: DOM Exception 5.
    2222PASS window.btoa is 0
    2323PASS typeof window.btoa is "number"
    2424PASS typeof window.atob is "function"
    25 PASS window.atob() threw exception Error: INVALID_CHARACTER_ERR: DOM Exception 5.
     25PASS window.atob() threw exception Error: InvalidCharacterError: DOM Exception 5.
    2626PASS window.atob("") is ""
    2727PASS window.atob(null) is ""
    28 PASS window.atob(undefined) threw exception Error: INVALID_CHARACTER_ERR: DOM Exception 5.
    29 PASS window.atob(" YQ==") threw exception Error: INVALID_CHARACTER_ERR: DOM Exception 5.
    30 PASS window.atob("YQ==\u000a") threw exception Error: INVALID_CHARACTER_ERR: DOM Exception 5.
     28PASS window.atob(undefined) threw exception Error: InvalidCharacterError: DOM Exception 5.
     29PASS window.atob(" YQ==") threw exception Error: InvalidCharacterError: DOM Exception 5.
     30PASS window.atob("YQ==\u000a") threw exception Error: InvalidCharacterError: DOM Exception 5.
    3131PASS window.atob("6ek=") is "éé"
    3232PASS window.atob("6ek") is "éé"
    3333PASS window.atob("gIE=") is "€"
    34 PASS window.atob("тест") threw exception Error: INVALID_CHARACTER_ERR: DOM Exception 5.
    35 PASS window.atob("z") threw exception Error: INVALID_CHARACTER_ERR: DOM Exception 5.
     34PASS window.atob("тест") threw exception Error: InvalidCharacterError: DOM Exception 5.
     35PASS window.atob("z") threw exception Error: InvalidCharacterError: DOM Exception 5.
    3636PASS window.atob("zz") is "Ï"
    3737PASS window.atob("zzz") is "Ï<"
    … …  
    4141PASS window.atob("zzz====") is "Ï<"
    4242PASS window.atob("zzzz") is "Ï<ó"
    43 PASS window.atob("zzzzz") threw exception Error: INVALID_CHARACTER_ERR: DOM Exception 5.
    44 PASS window.atob("z=zz") threw exception Error: INVALID_CHARACTER_ERR: DOM Exception 5.
    45 PASS window.atob("=") threw exception Error: INVALID_CHARACTER_ERR: DOM Exception 5.
    46 PASS window.atob("==") threw exception Error: INVALID_CHARACTER_ERR: DOM Exception 5.
    47 PASS window.atob("===") threw exception Error: INVALID_CHARACTER_ERR: DOM Exception 5.
    48 PASS window.atob("====") threw exception Error: INVALID_CHARACTER_ERR: DOM Exception 5.
    49 PASS window.atob("=====") threw exception Error: INVALID_CHARACTER_ERR: DOM Exception 5.
     43PASS window.atob("zzzzz") threw exception Error: InvalidCharacterError: DOM Exception 5.
     44PASS window.atob("z=zz") threw exception Error: InvalidCharacterError: DOM Exception 5.
     45PASS window.atob("=") threw exception Error: InvalidCharacterError: DOM Exception 5.
     46PASS window.atob("==") threw exception Error: InvalidCharacterError: DOM Exception 5.
     47PASS window.atob("===") threw exception Error: InvalidCharacterError: DOM Exception 5.
     48PASS window.atob("====") threw exception Error: InvalidCharacterError: DOM Exception 5.
     49PASS window.atob("=====") threw exception Error: InvalidCharacterError: DOM Exception 5.
    5050PASS window.atob is 0
    5151PASS typeof window.atob is "number"

  • trunk/LayoutTests/fast/dom/dataset-expected.txt

    r96893 r134530  
    2929
    3030PASS testSet('-foo', 'dummy') threw exception Error: SYNTAX_ERR: DOM Exception 12.
    31 PASS testSet('foo ', 'dummy') threw exception Error: INVALID_CHARACTER_ERR: DOM Exception 5.
    32 PASS testSet('foo豈', 'dummy') threw exception Error: INVALID_CHARACTER_ERR: DOM Exception 5.
     31PASS testSet('foo ', 'dummy') threw exception Error: InvalidCharacterError: DOM Exception 5.
     32PASS testSet('foo豈', 'dummy') threw exception Error: InvalidCharacterError: DOM Exception 5.
    3333
    3434PASS testDelete('data-foo', 'foo') is true

  • trunk/LayoutTests/fast/dom/dataset-xhtml-expected.txt

    r96911 r134530  
    2424
    2525PASS testSet('-foo', 'dummy') threw exception Error: SYNTAX_ERR: DOM Exception 12.
    26 PASS testSet('foo ', 'dummy') threw exception Error: INVALID_CHARACTER_ERR: DOM Exception 5.
    27 PASS testSet('foo豈', 'dummy') threw exception Error: INVALID_CHARACTER_ERR: DOM Exception 5.
     26PASS testSet('foo ', 'dummy') threw exception Error: InvalidCharacterError: DOM Exception 5.
     27PASS testSet('foo豈', 'dummy') threw exception Error: InvalidCharacterError: DOM Exception 5.
    2828
    2929PASS testDelete('data-foo', 'foo') is true

  • trunk/LayoutTests/fast/dom/script-tests/dataset-xhtml.js

    r98407 r134530  
    4949
    5050shouldThrow("testSet('-foo', 'dummy')", "'Error: SYNTAX_ERR: DOM Exception 12'");
    51 shouldThrow("testSet('foo\x20', 'dummy')", "'Error: INVALID_CHARACTER_ERR: DOM Exception 5'");
    52 shouldThrow("testSet('foo\uF900', 'dummy')", "'Error: INVALID_CHARACTER_ERR: DOM Exception 5'");
     51shouldThrow("testSet('foo\x20', 'dummy')", "'Error: InvalidCharacterError: DOM Exception 5'");
     52shouldThrow("testSet('foo\uF900', 'dummy')", "'Error: InvalidCharacterError: DOM Exception 5'");
    5353debug("");
    5454

  • trunk/LayoutTests/fast/dom/script-tests/dataset.js

    r98407 r134530  
    5454
    5555shouldThrow("testSet('-foo', 'dummy')", "'Error: SYNTAX_ERR: DOM Exception 12'");
    56 shouldThrow("testSet('foo\x20', 'dummy')", "'Error: INVALID_CHARACTER_ERR: DOM Exception 5'");
    57 shouldThrow("testSet('foo\uF900', 'dummy')", "'Error: INVALID_CHARACTER_ERR: DOM Exception 5'");
     56shouldThrow("testSet('foo\x20', 'dummy')", "'Error: InvalidCharacterError: DOM Exception 5'");
     57shouldThrow("testSet('foo\uF900', 'dummy')", "'Error: InvalidCharacterError: DOM Exception 5'");
    5858debug("");
    5959

  • trunk/Source/WebCore/ChangeLog

    r134529 r134530  
     12012-11-13  Erik Arvidsson  <arv@chromium.org>
     2
     3        Update DOMException name: InvalidCharacterError
     4        https://bugs.webkit.org/show_bug.cgi?id=102128
     5
     6        Reviewed by Darin Adler.
     7
     8        Patch 5 of 25 to update DOMException name to match the spec and Firefox.
     9
     10        Updated existing tests.
     11
     12        * dom/DOMCoreException.cpp:
     13
    1142012-11-13  Joshua Bell  <jsbell@chromium.org>
    215

  • trunk/Source/WebCore/dom/DOMCoreException.cpp

    r134435 r134530  
    4040    { "HierarchyRequestError", "A Node was inserted somewhere it doesn't belong." },
    4141    { "WRONG_DOCUMENT_ERR", "A Node was used in a different document than the one that created it (that doesn't support it)." },
    42     { "INVALID_CHARACTER_ERR", "An invalid or illegal character was specified, such as in an XML name." },
     42    { "InvalidCharacterError", "An invalid or illegal character was specified, such as in an XML name." },
    4343    { "NO_DATA_ALLOWED_ERR", "Data was specified for a Node which does not support data." },
    4444    { "NO_MODIFICATION_ALLOWED_ERR", "An attempt was made to modify an object where modifications are not allowed." },
Note: See TracChangeset for help on using the changeset viewer.