Changeset 134558 in webkit

Timestamp:

Nov 13, 2012 11:56:51 PM (11 years ago)

Author:

tkent@chromium.org

Message:

Use menulist-button instead of menulist for date/time input types
​https://bugs.webkit.org/show_bug.cgi?id=101886

Reviewed by Hajime Morita.

Both of Chromium-Android and iOS use -webkit-appearance:menulist-button,
not menulist. We had better apply common one by default.

No new tests. Covered by fast/forms/*/*-appearance-*.html.

• css/html.css:

(input[type="date"]): Switch menulist-button from menulist.
(input[type="datetime"]): Ditto.
(input[type="datetime-local"]): Ditto.
(input[type="month"]): Ditto.
(input[type="time"]): Ditto.
(input[type="week"]): Ditto.
(input::-webkit-date-and-time-value):
Add top, right, bottom margins. The right margin is important when
dir=rtl is specified.
whitespace:pre is needed to align baseline in a case of empty values.

• css/themeChromiumAndroid.css:

Remove redundant style declaration.

• css/themeWin.css:

Remove padding adjustment for date/time input types. It is for
textfields.

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• css/html.css (modified) (7 diffs)
• css/themeChromiumAndroid.css (modified) (1 diff)
• css/themeWin.css (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2012-11-13  Kent Tamura  <tkent@chromium.org>
+
+        Use menulist-button instead of menulist for date/time input types
+        https://bugs.webkit.org/show_bug.cgi?id=101886
+
+        Reviewed by Hajime Morita.
+
+        Both of Chromium-Android and iOS use -webkit-appearance:menulist-button,
+        not menulist. We had better apply common one by default.
+
+        No new tests. Covered by fast/forms/*/*-appearance-*.html.
+
+        * css/html.css:
+        (input[type="date"]): Switch menulist-button from menulist.
+        (input[type="datetime"]): Ditto.
+        (input[type="datetime-local"]): Ditto.
+        (input[type="month"]): Ditto.
+        (input[type="time"]): Ditto.
+        (input[type="week"]): Ditto.
+        (input::-webkit-date-and-time-value):
+        Add top, right, bottom margins. The right margin is important when
+        dir=rtl is specified.
+        whitespace:pre is needed to align baseline in a case of empty values.
+        * css/themeChromiumAndroid.css:
+        Remove redundant style declaration.
+        * css/themeWin.css:
+        Remove padding adjustment for date/time input types. It is for
+        textfields.
+
 2012-11-13  Vincent Scheib  <scheib@chromium.org>
 

trunk/Source/WebCore/css/html.css

@@ -608 +608 @@
 input[type="date"] {
     -webkit-align-items: center;
-    -webkit-appearance: menulist;
+    -webkit-appearance: menulist-button;
     display: -webkit-inline-flex;
     overflow: hidden;
@@ -617 +617 @@
 input[type="datetime"] {
     -webkit-align-items: center;
-    -webkit-appearance: menulist;
+    -webkit-appearance: menulist-button;
     display: -webkit-inline-flex;
     overflow: hidden;
@@ -626 +626 @@
 input[type="datetime-local"] {
     -webkit-align-items: center;
-    -webkit-appearance: menulist;
+    -webkit-appearance: menulist-button;
     display: -webkit-inline-flex;
     overflow: hidden;
@@ -635 +635 @@
 input[type="month"] {
     -webkit-align-items: center;
-    -webkit-appearance: menulist;
+    -webkit-appearance: menulist-button;
     display: -webkit-inline-flex;
     overflow: hidden;
@@ -644 +644 @@
 input[type="time"] {
     -webkit-align-items: center;
-    -webkit-appearance: menulist;
+    -webkit-appearance: menulist-button;
     display: -webkit-inline-flex;
     overflow: hidden;
@@ -653 +653 @@
 input[type="week"] {
     -webkit-align-items: center;
-    -webkit-appearance: menulist;
+    -webkit-appearance: menulist-button;
     display: -webkit-inline-flex;
     overflow: hidden;
@@ -661 +661 @@
 
 input::-webkit-date-and-time-value {
-    margin-left: 4px;
+    margin: 1px 24px 1px 4px;
+    white-space: pre;
 }
 #endif

trunk/Source/WebCore/css/themeChromiumAndroid.css

@@ -40 +40 @@
     white-space: pre;
 }
-
-input[type="date"], input[type="datetime"], input[type="datetime-local"], input[type="time"], input[type="month"] {
-    -webkit-appearance: menulist-button;
-}

trunk/Source/WebCore/css/themeWin.css

@@ -39 +39 @@
 input[type="password"],
 input[type="tel"],
-#if !defined(ENABLE_INPUT_MULTIPLE_FIELDS_UI) || !ENABLE_INPUT_MULTIPLE_FIELDS_UI
-input[type="date"],
-input[type="datetime"],
-input[type="datetime-local"],
-input[type="month"],
-input[type="time"],
-input[type="week"],
-#endif
 input[type="url"],
 input[type="text"] {