Changeset 134637 in webkit


Ignore:
Timestamp:
Nov 14, 2012 11:34:49 AM (11 years ago)
Author:
rniwa@webkit.org
Message:

runCount in runner.js should be renamed to iterationCount
​https://bugs.webkit.org/show_bug.cgi?id=102208

Reviewed by Tony Chang.

Prior to this patch, there were terminology confusions between "runs" and "iterations".
The term "run" should refer to running a performance test once, and "iteration" should
refer to one measurement in the test. i.e. Executing run-perf-should once will result in
a single "run" of performance tests and each test may execute multiple "iterations"
to complete the run.

Unfortunately, we still overload the meaning of "runs" in "runs/s" (is "function calls/s")
but that could be addressed in a separate patch.

  • Animation/balls.html:
  • DOM/DOMTable.html:
  • DOM/resources/dom-perf.js:
  • Layout/floats_100_100.html:
  • Layout/floats_100_100_nested.html:
  • Layout/floats_20_100.html:
  • Layout/floats_20_100_nested.html:
  • Layout/floats_2_100.html:
  • Layout/floats_2_100_nested.html:
  • Layout/floats_50_100.html:
  • Layout/floats_50_100_nested.html:
  • Layout/subtree-detaching.html:
  • Parser/html5-full-render.html:
  • SVG/SvgHitTesting.html:
  • resources/runner.js:
Location:
trunk/PerformanceTests
Files:
16 edited

Legend:

Unmodified
Added
Removed

  • trunk/PerformanceTests/Animation/balls.html

    r131638 r134637  
    107107
    108108    window.onload = function () {
    109         PerfTestRunner.prepareToMeasureValuesAsync({runCount: 10, done: onCompletedRun, unit: 'fps'});
     109        PerfTestRunner.prepareToMeasureValuesAsync({iterationCount: 10, done: onCompletedRun, unit: 'fps'});
    110110
    111111        // Create the particles

  • trunk/PerformanceTests/ChangeLog

    r134443 r134637  
     12012-11-14  Ryosuke Niwa  <rniwa@webkit.org>
     2
     3        runCount in runner.js should be renamed to iterationCount
     4        https://bugs.webkit.org/show_bug.cgi?id=102208
     5
     6        Reviewed by Tony Chang.
     7
     8        Prior to this patch, there were terminology confusions between "runs" and "iterations".
     9        The term "run" should refer to running a performance test once, and "iteration" should
     10        refer to one measurement in the test. i.e. Executing run-perf-should once will result in
     11        a single "run" of performance tests and each test may execute multiple "iterations"
     12        to complete the run.
     13
     14        Unfortunately, we still overload the meaning of "runs" in "runs/s" (is "function calls/s")
     15        but that could be addressed in a separate patch.
     16
     17        * Animation/balls.html:
     18        * DOM/DOMTable.html:
     19        * DOM/resources/dom-perf.js:
     20        * Layout/floats_100_100.html:
     21        * Layout/floats_100_100_nested.html:
     22        * Layout/floats_20_100.html:
     23        * Layout/floats_20_100_nested.html:
     24        * Layout/floats_2_100.html:
     25        * Layout/floats_2_100_nested.html:
     26        * Layout/floats_50_100.html:
     27        * Layout/floats_50_100_nested.html:
     28        * Layout/subtree-detaching.html:
     29        * Parser/html5-full-render.html:
     30        * SVG/SvgHitTesting.html:
     31        * resources/runner.js:
     32
    1332012-11-13  Dimitri Glazkov  <dglazkov@chromium.org>
    234

  • trunk/PerformanceTests/DOM/DOMTable.html

    r106386 r134637  
    88<script>
    99runBenchmarkSuite(DOMTableTest, 10);
    10 // runCount = 10 since this test is very slow (~12m per run on Core i5 2.53Hz MacBookPro)
     10// iterationCount: 10 since this test is very slow (~12m per run on Core i5 2.53Hz MacBookPro)
    1111</script>
    1212</body>

  • trunk/PerformanceTests/DOM/resources/dom-perf.js

    r129848 r134637  
    331331};
    332332
    333 function runBenchmarkSuite(suite, runCount) {
     333function runBenchmarkSuite(suite, iterationCount) {
    334334    PerfTestRunner.measureTime({run: function () {
    335335        var container = document.getElementById('container');
    … …  
    347347        return totalMeanTime;
    348348    },
    349     runCount: runCount,
     349    iterationCount: iterationCount,
    350350    done: function () {
    351351        var container = document.getElementById('container');

  • trunk/PerformanceTests/Layout/floats_100_100.html

    r129824 r134637  
    1111        <script>
    1212            PerfTestRunner.measureTime({run: createFloatsLayoutTestFunction(100, 100, 0, 3),
    13                 runCount: 2});
     13                iterationCount: 2});
    1414        </script>
    1515    </body>

  • trunk/PerformanceTests/Layout/floats_100_100_nested.html

    r129824 r134637  
    1111        <script>
    1212            PerfTestRunner.measureTime({run: createFloatsLayoutTestFunction(100, 100, 100, 3),
    13                 runCount: 2});
     13                iterationCount: 2});
    1414        </script>
    1515    </body>

  • trunk/PerformanceTests/Layout/floats_20_100.html

    r129824 r134637  
    1111        <script>
    1212            PerfTestRunner.measureTime({run: createFloatsLayoutTestFunction(20, 100, 0, 100),
    13                 runCount: 7});
     13                iterationCount: 7});
    1414        </script>
    1515    </body>

  • trunk/PerformanceTests/Layout/floats_20_100_nested.html

    r129824 r134637  
    1111        <script>
    1212            PerfTestRunner.measureTime({run: createFloatsLayoutTestFunction(20, 100, 100, 100),
    13                 runCount: 6});
     13                iterationCount: 6});
    1414        </script>
    1515    </body>

  • trunk/PerformanceTests/Layout/floats_2_100.html

    r129824 r134637  
    1111        <script>
    1212            PerfTestRunner.measureTime({run: createFloatsLayoutTestFunction(2, 100, 0, 500),
    13                 runCount: 10});
     13                iterationCount: 10});
    1414        </script>
    1515    </body>

  • trunk/PerformanceTests/Layout/floats_2_100_nested.html

    r129824 r134637  
    1111        <script>
    1212            PerfTestRunner.measureTime({run: createFloatsLayoutTestFunction(2, 100, 100, 250),
    13                 runCount: 10});
     13                iterationCount: 10});
    1414        </script>
    1515    </body>

  • trunk/PerformanceTests/Layout/floats_50_100.html

    r129824 r134637  
    1111        <script>
    1212            PerfTestRunner.measureTime({run: createFloatsLayoutTestFunction(50, 100, 0, 20),
    13                 runCount: 5});
     13                iterationCount: 5});
    1414        </script>
    1515    </body>

  • trunk/PerformanceTests/Layout/floats_50_100_nested.html

    r129824 r134637  
    1111        <script>
    1212            PerfTestRunner.measureTime({run: createFloatsLayoutTestFunction(50, 100, 100, 20),
    13                 runCount: 5});
     13                iterationCount: 5});
    1414        </script>
    1515    </body>

  • trunk/PerformanceTests/Layout/subtree-detaching.html

    r130341 r134637  
    3737buildTree();
    3838
    39 PerfTestRunner.measureTime({run: runTest, runCount: 20, description: "This benchmark checks the time spend in detaching an tree." });
     39PerfTestRunner.measureTime({run: runTest, iterationCount: 20, description: "This benchmark checks the time spend in detaching an tree." });
    4040</script>
    4141</body>

  • trunk/PerformanceTests/Parser/html5-full-render.html

    r132273 r134637  
    77    PerfTestRunner.measurePageLoadTime({path: "resources/html5.html",
    88    chunkSize: 500000, // 6.09mb / 500k = approx 13 chunks (thus 13 forced layouts/style resolves).
    9     runCount: 5 }); // Depending on the chosen chunk size, iterations can take over 60s to run on a fast machine, so we only run 5.
     9    iterationCount: 5 }); // Depending on the chosen chunk size, iterations can take over 60s to run on a fast machine, so we only run 5.
    1010}
    1111

  • trunk/PerformanceTests/SVG/SvgHitTesting.html

    r129824 r134637  
    112112        if (wrapper)
    113113          wrapper.parentNode.removeChild(wrapper);
    114       }, runCount: 10});
     114      }, iterationCount: 10});
    115115    </script>
    116116  </body>

  • trunk/PerformanceTests/resources/runner.js

    r132316 r134637  
    1212(function () {
    1313    var logLines = null;
    14     var completedRuns = -1;
     14    var completedIterations = -1;
    1515    var callsPerIteration = 1;
    1616    var currentTest = null;
    … …  
    1818    var jsHeapResults = [];
    1919    var mallocHeapResults = [];
    20     var runCount = undefined;
     20    var iterationCount = undefined;
    2121
    2222    var PerfTestRunner = {};
    … …  
    168168        }
    169169        currentTest = test;
    170         runCount = test.runCount || 20;
     170        iterationCount = test.iterationCount || 20;
    171171        logLines = window.testRunner ? [] : null;
    172         PerfTestRunner.log("Running " + runCount + " times");
     172        PerfTestRunner.log("Running " + iterationCount + " times");
    173173        if (runner)
    174174            scheduleNextRun(runner);
    … …  
    185185            }
    186186
    187             completedRuns++;
     187            completedIterations++;
    188188
    189189            try {
    … …  
    194194            }
    195195
    196             if (completedRuns < runCount)
     196            if (completedIterations < iterationCount)
    197197                scheduleNextRun(runner);
    198198            else
    … …  
    203203    function ignoreWarmUpAndLog(measuredValue) {
    204204        var labeledResult = measuredValue + " " + PerfTestRunner.unit;
    205         if (completedRuns <= 0)
     205        if (completedIterations <= 0)
    206206            PerfTestRunner.log("Ignoring warm-up run (" + labeledResult + ")");
    207207        else {
    … …  
    242242
    243243    PerfTestRunner.measureValueAync = function (measuredValue) {
    244         completedRuns++;
     244        completedIterations++;
    245245
    246246        try {
    … …  
    251251        }
    252252
    253         if (completedRuns >= runCount)
     253        if (completedIterations >= iterationCount)
    254254            finish();
    255255    }
    … …  
    290290            totalTime += callRunAndMeasureTime(callsPerIteration);
    291291            numberOfRuns += callsPerIteration;
    292             if (completedRuns < 0 && totalTime < 100)
     292            if (completedIterations < 0 && totalTime < 100)
    293293                callsPerIteration = Math.max(10, 2 * callsPerIteration);
    294294        }
Note: See TracChangeset for help on using the changeset viewer.