Changeset 134939 in webkit
- Timestamp:
- Nov 16, 2012 5:47:03 AM (11 years ago)
- Location:
- trunk/Source/WebCore
- Files:
-
- 1 added
- 3 edited
- 30 moved
Legend:
- Unmodified
- Added
- Removed
-
trunk/Source/WebCore/ChangeLog
r134938 r134939 1 2012-11-16 Mario Sanchez Prada <mario@webkit.org> 2 3 [EFL] Share WebKit-Gtk's Accessibility implementation with others WebKit ports. 4 https://bugs.webkit.org/show_bug.cgi?id=99578 5 6 Reviewed by Martin Robinson. 7 8 Renamed WebCore/accessibility/gtk to WebCore/accessibility/atk. 9 10 * GNUmakefile.am: 11 * GNUmakefile.list.am: 12 * accessibility/atk/AXObjectCacheAtk.cpp: Renamed from 13 Source/WebCore/accessibility/gtk/AXObjectCacheAtk.cpp. 14 * accessibility/atk/AccessibilityObjectAtk.cpp: Renamed from 15 Source/WebCore/accessibility/gtk/AccessibilityObjectAtk.cpp. 16 * accessibility/atk/WebKitAccessibleHyperlink.cpp: Renamed from 17 Source/WebCore/accessibility/gtk/WebKitAccessibleHyperlink.cpp. 18 * accessibility/atk/WebKitAccessibleHyperlink.h: Renamed from 19 Source/WebCore/accessibility/gtk/WebKitAccessibleHyperlink.h. 20 * accessibility/atk/WebKitAccessibleInterfaceAction.cpp: Renamed 21 from Source/WebCore/accessibility/gtk/WebKitAccessibleInterfaceAction.cpp. 22 * accessibility/atk/WebKitAccessibleInterfaceAction.h: Renamed 23 from Source/WebCore/accessibility/gtk/WebKitAccessibleInterfaceAction.h. 24 * accessibility/atk/WebKitAccessibleInterfaceComponent.cpp: 25 Renamed from Source/WebCore/accessibility/gtk/WebKitAccessibleInterfaceComponent.cpp. 26 * accessibility/atk/WebKitAccessibleInterfaceComponent.h: Renamed 27 from Source/WebCore/accessibility/gtk/WebKitAccessibleInterfaceComponent.h. 28 * accessibility/atk/WebKitAccessibleInterfaceDocument.cpp: Renamed 29 from Source/WebCore/accessibility/gtk/WebKitAccessibleInterfaceDocument.cpp. 30 * accessibility/atk/WebKitAccessibleInterfaceDocument.h: Renamed 31 from Source/WebCore/accessibility/gtk/WebKitAccessibleInterfaceDocument.h. 32 * accessibility/atk/WebKitAccessibleInterfaceEditableText.cpp: 33 Renamed from Source/WebCore/accessibility/gtk/WebKitAccessibleInterfaceEditableText.cpp. 34 * accessibility/atk/WebKitAccessibleInterfaceEditableText.h: 35 Renamed from Source/WebCore/accessibility/gtk/WebKitAccessibleInterfaceEditableText.h. 36 * accessibility/atk/WebKitAccessibleInterfaceHyperlinkImpl.cpp: 37 Renamed from Source/WebCore/accessibility/gtk/WebKitAccessibleInterfaceHyperlinkImpl.cpp. 38 * accessibility/atk/WebKitAccessibleInterfaceHyperlinkImpl.h: 39 Renamed from Source/WebCore/accessibility/gtk/WebKitAccessibleInterfaceHyperlinkImpl.h. 40 * accessibility/atk/WebKitAccessibleInterfaceHypertext.cpp: 41 Renamed from Source/WebCore/accessibility/gtk/WebKitAccessibleInterfaceHypertext.cpp. 42 * accessibility/atk/WebKitAccessibleInterfaceHypertext.h: Renamed 43 from Source/WebCore/accessibility/gtk/WebKitAccessibleInterfaceHypertext.h. 44 * accessibility/atk/WebKitAccessibleInterfaceImage.cpp: Renamed 45 from Source/WebCore/accessibility/gtk/WebKitAccessibleInterfaceImage.cpp. 46 * accessibility/atk/WebKitAccessibleInterfaceImage.h: Renamed from 47 Source/WebCore/accessibility/gtk/WebKitAccessibleInterfaceImage.h. 48 * accessibility/atk/WebKitAccessibleInterfaceSelection.cpp: 49 Renamed from Source/WebCore/accessibility/gtk/WebKitAccessibleInterfaceSelection.cpp. 50 * accessibility/atk/WebKitAccessibleInterfaceSelection.h: Renamed 51 from Source/WebCore/accessibility/gtk/WebKitAccessibleInterfaceSelection.h. 52 * accessibility/atk/WebKitAccessibleInterfaceTable.cpp: Renamed 53 from Source/WebCore/accessibility/gtk/WebKitAccessibleInterfaceTable.cpp. 54 * accessibility/atk/WebKitAccessibleInterfaceTable.h: Renamed from 55 Source/WebCore/accessibility/gtk/WebKitAccessibleInterfaceTable.h. 56 * accessibility/atk/WebKitAccessibleInterfaceText.cpp: Renamed 57 from Source/WebCore/accessibility/gtk/WebKitAccessibleInterfaceText.cpp. 58 * accessibility/atk/WebKitAccessibleInterfaceText.h: Renamed from 59 Source/WebCore/accessibility/gtk/WebKitAccessibleInterfaceText.h. 60 * accessibility/atk/WebKitAccessibleInterfaceValue.cpp: Renamed 61 from Source/WebCore/accessibility/gtk/WebKitAccessibleInterfaceValue.cpp. 62 * accessibility/atk/WebKitAccessibleInterfaceValue.h: Renamed from 63 Source/WebCore/accessibility/gtk/WebKitAccessibleInterfaceValue.h. 64 * accessibility/atk/WebKitAccessibleUtil.cpp: Renamed from 65 Source/WebCore/accessibility/gtk/WebKitAccessibleUtil.cpp. 66 * accessibility/atk/WebKitAccessibleUtil.h: Renamed from 67 Source/WebCore/accessibility/gtk/WebKitAccessibleUtil.h. 68 * accessibility/atk/WebKitAccessibleWrapperAtk.cpp: Renamed from 69 Source/WebCore/accessibility/gtk/WebKitAccessibleWrapperAtk.cpp. 70 * accessibility/atk/WebKitAccessibleWrapperAtk.h: Renamed from 71 Source/WebCore/accessibility/gtk/WebKitAccessibleWrapperAtk.h. 72 1 73 2012-11-16 Shinya Kawanaka <shinyak@chromium.org> 2 74 -
trunk/Source/WebCore/GNUmakefile.am
r134864 r134939 107 107 -DWEBKITGTK_API_VERSION_STRING=\"@WEBKITGTK_API_VERSION@\" \ 108 108 -DWTF_USE_SOUP=1 \ 109 -I$(srcdir)/Source/WebCore/accessibility/ gtk \109 -I$(srcdir)/Source/WebCore/accessibility/atk \ 110 110 -I$(srcdir)/Source/WebCore/loader/gtk \ 111 111 -I$(srcdir)/Source/WebCore/page/gtk \ -
trunk/Source/WebCore/GNUmakefile.list.am
r134930 r134939 5892 5892 # WebCore files that use GTK/GDK or any other dependency that requires GTK+. 5893 5893 webcoregtk_sources += \ 5894 Source/WebCore/accessibility/ gtk/AccessibilityObjectAtk.cpp \5895 Source/WebCore/accessibility/ gtk/AXObjectCacheAtk.cpp \5896 Source/WebCore/accessibility/ gtk/WebKitAccessibleHyperlink.h \5897 Source/WebCore/accessibility/ gtk/WebKitAccessibleHyperlink.cpp \5898 Source/WebCore/accessibility/ gtk/WebKitAccessibleInterfaceAction.cpp \5899 Source/WebCore/accessibility/ gtk/WebKitAccessibleInterfaceAction.h \5900 Source/WebCore/accessibility/ gtk/WebKitAccessibleInterfaceComponent.cpp \5901 Source/WebCore/accessibility/ gtk/WebKitAccessibleInterfaceComponent.h \5902 Source/WebCore/accessibility/ gtk/WebKitAccessibleInterfaceDocument.cpp \5903 Source/WebCore/accessibility/ gtk/WebKitAccessibleInterfaceDocument.h \5904 Source/WebCore/accessibility/ gtk/WebKitAccessibleInterfaceEditableText.cpp \5905 Source/WebCore/accessibility/ gtk/WebKitAccessibleInterfaceEditableText.h \5906 Source/WebCore/accessibility/ gtk/WebKitAccessibleInterfaceHyperlinkImpl.cpp \5907 Source/WebCore/accessibility/ gtk/WebKitAccessibleInterfaceHyperlinkImpl.h \5908 Source/WebCore/accessibility/ gtk/WebKitAccessibleInterfaceHypertext.cpp \5909 Source/WebCore/accessibility/ gtk/WebKitAccessibleInterfaceHypertext.h \5910 Source/WebCore/accessibility/ gtk/WebKitAccessibleInterfaceImage.cpp \5911 Source/WebCore/accessibility/ gtk/WebKitAccessibleInterfaceImage.h \5912 Source/WebCore/accessibility/ gtk/WebKitAccessibleInterfaceSelection.cpp \5913 Source/WebCore/accessibility/ gtk/WebKitAccessibleInterfaceSelection.h \5914 Source/WebCore/accessibility/ gtk/WebKitAccessibleInterfaceTable.cpp \5915 Source/WebCore/accessibility/ gtk/WebKitAccessibleInterfaceTable.h \5916 Source/WebCore/accessibility/ gtk/WebKitAccessibleInterfaceText.cpp \5917 Source/WebCore/accessibility/ gtk/WebKitAccessibleInterfaceText.h \5918 Source/WebCore/accessibility/ gtk/WebKitAccessibleInterfaceValue.cpp \5919 Source/WebCore/accessibility/ gtk/WebKitAccessibleInterfaceValue.h \5920 Source/WebCore/accessibility/ gtk/WebKitAccessibleUtil.cpp \5921 Source/WebCore/accessibility/ gtk/WebKitAccessibleUtil.h \5922 Source/WebCore/accessibility/ gtk/WebKitAccessibleWrapperAtk.cpp \5923 Source/WebCore/accessibility/ gtk/WebKitAccessibleWrapperAtk.h \5894 Source/WebCore/accessibility/atk/AccessibilityObjectAtk.cpp \ 5895 Source/WebCore/accessibility/atk/AXObjectCacheAtk.cpp \ 5896 Source/WebCore/accessibility/atk/WebKitAccessibleHyperlink.h \ 5897 Source/WebCore/accessibility/atk/WebKitAccessibleHyperlink.cpp \ 5898 Source/WebCore/accessibility/atk/WebKitAccessibleInterfaceAction.cpp \ 5899 Source/WebCore/accessibility/atk/WebKitAccessibleInterfaceAction.h \ 5900 Source/WebCore/accessibility/atk/WebKitAccessibleInterfaceComponent.cpp \ 5901 Source/WebCore/accessibility/atk/WebKitAccessibleInterfaceComponent.h \ 5902 Source/WebCore/accessibility/atk/WebKitAccessibleInterfaceDocument.cpp \ 5903 Source/WebCore/accessibility/atk/WebKitAccessibleInterfaceDocument.h \ 5904 Source/WebCore/accessibility/atk/WebKitAccessibleInterfaceEditableText.cpp \ 5905 Source/WebCore/accessibility/atk/WebKitAccessibleInterfaceEditableText.h \ 5906 Source/WebCore/accessibility/atk/WebKitAccessibleInterfaceHyperlinkImpl.cpp \ 5907 Source/WebCore/accessibility/atk/WebKitAccessibleInterfaceHyperlinkImpl.h \ 5908 Source/WebCore/accessibility/atk/WebKitAccessibleInterfaceHypertext.cpp \ 5909 Source/WebCore/accessibility/atk/WebKitAccessibleInterfaceHypertext.h \ 5910 Source/WebCore/accessibility/atk/WebKitAccessibleInterfaceImage.cpp \ 5911 Source/WebCore/accessibility/atk/WebKitAccessibleInterfaceImage.h \ 5912 Source/WebCore/accessibility/atk/WebKitAccessibleInterfaceSelection.cpp \ 5913 Source/WebCore/accessibility/atk/WebKitAccessibleInterfaceSelection.h \ 5914 Source/WebCore/accessibility/atk/WebKitAccessibleInterfaceTable.cpp \ 5915 Source/WebCore/accessibility/atk/WebKitAccessibleInterfaceTable.h \ 5916 Source/WebCore/accessibility/atk/WebKitAccessibleInterfaceText.cpp \ 5917 Source/WebCore/accessibility/atk/WebKitAccessibleInterfaceText.h \ 5918 Source/WebCore/accessibility/atk/WebKitAccessibleInterfaceValue.cpp \ 5919 Source/WebCore/accessibility/atk/WebKitAccessibleInterfaceValue.h \ 5920 Source/WebCore/accessibility/atk/WebKitAccessibleUtil.cpp \ 5921 Source/WebCore/accessibility/atk/WebKitAccessibleUtil.h \ 5922 Source/WebCore/accessibility/atk/WebKitAccessibleWrapperAtk.cpp \ 5923 Source/WebCore/accessibility/atk/WebKitAccessibleWrapperAtk.h \ 5924 5924 Source/WebCore/editing/gtk/FrameSelectionGtk.cpp \ 5925 5925 Source/WebCore/page/gtk/DragControllerGtk.cpp \ -
trunk/Source/WebCore/accessibility/atk/AXObjectCacheAtk.cpp
r134938 r134939 25 25 #include "Document.h" 26 26 #include "Element.h" 27 #include <wtf/gobject/GOwnPtr.h>28 27 #include "HTMLSelectElement.h" 29 28 #include "Range.h" 30 29 #include "TextIterator.h" 31 30 #include "WebKitAccessibleWrapperAtk.h" 31 #include <wtf/gobject/GOwnPtr.h> 32 32 33 33 namespace WebCore { -
trunk/Source/WebCore/accessibility/atk/WebKitAccessibleHyperlink.cpp
r134938 r134939 340 340 341 341 g_object_class_install_property(gobjectClass, PROP_HYPERLINK_IMPL, 342 343 344 345 346 342 g_param_spec_object("hyperlink-impl", 343 "Hyperlink implementation", 344 "The associated WebKitAccessible instance.", 345 WEBKIT_TYPE_ACCESSIBLE, 346 (GParamFlags)(G_PARAM_READWRITE | G_PARAM_CONSTRUCT_ONLY | G_PARAM_STATIC_STRINGS))); 347 347 348 348 g_type_class_add_private(gobjectClass, sizeof(WebKitAccessibleHyperlinkPrivate)); -
trunk/Source/WebCore/accessibility/atk/WebKitAccessibleInterfaceText.cpp
r134938 r134939 36 36 #include "Font.h" 37 37 #include "FrameView.h" 38 #include <wtf/gobject/GOwnPtr.h>39 38 #include "HostWindow.h" 40 39 #include "InlineTextBox.h" … … 48 47 #include "WebKitAccessibleWrapperAtk.h" 49 48 #include "htmlediting.h" 49 #include <wtf/gobject/GOwnPtr.h> 50 50 51 51 #if PLATFORM(GTK) … … 212 212 Color bgColor = style->visitedDependentColor(CSSPropertyBackgroundColor); 213 213 if (bgColor.isValid()) { 214 buffer.set(g_strdup_printf("%i,%i,%i", 215 bgColor.red(), bgColor.green(), bgColor.blue())); 214 buffer.set(g_strdup_printf("%i,%i,%i", bgColor.red(), bgColor.green(), bgColor.blue())); 216 215 result = addToAtkAttributeSet(result, atk_text_attribute_get_name(ATK_TEXT_ATTR_BG_COLOR), buffer.get()); 217 216 } … … 219 218 Color fgColor = style->visitedDependentColor(CSSPropertyColor); 220 219 if (fgColor.isValid()) { 221 buffer.set(g_strdup_printf("%i,%i,%i", 222 fgColor.red(), fgColor.green(), fgColor.blue())); 220 buffer.set(g_strdup_printf("%i,%i,%i", fgColor.red(), fgColor.green(), fgColor.blue())); 223 221 result = addToAtkAttributeSet(result, atk_text_attribute_get_name(ATK_TEXT_ATTR_FG_COLOR), buffer.get()); 224 222 } -
trunk/Source/WebCore/accessibility/atk/WebKitAccessibleUtil.cpp
r134938 r134939 165 165 ExceptionCode ec = 0; 166 166 return (range->intersectsNode(node, ec) 167 168 167 && (range->endContainer() != node || range->endOffset()) 168 && (range->startContainer() != lastDescendant || range->startOffset() != lastOffsetInNode(lastDescendant))); 169 169 } -
trunk/Source/WebCore/accessibility/atk/WebKitAccessibleWrapperAtk.cpp
r134938 r134939 207 207 } 208 208 209 static gpointer webkit _accessible_parent_class = 0;209 static gpointer webkitAccessibleParentClass = 0; 210 210 211 211 static bool isRootObject(AccessibilityObject* coreObject) … … 258 258 { 259 259 // Check first if the parent has been already set. 260 AtkObject* accessibleParent = ATK_OBJECT_CLASS(webkit _accessible_parent_class)->get_parent(object);260 AtkObject* accessibleParent = ATK_OBJECT_CLASS(webkitAccessibleParentClass)->get_parent(object); 261 261 if (accessibleParent) 262 262 return accessibleParent; … … 629 629 // more check so that we do not present them as being "editable". 630 630 if ((!coreObject->isReadOnly() 631 631 || (coreObject->isControl() && coreObject->canSetValueAttribute())) 632 632 && !isListBoxOption) 633 633 atk_state_set_add_state(stateSet, ATK_STATE_EDITABLE); … … 709 709 static AtkStateSet* webkitAccessibleRefStateSet(AtkObject* object) 710 710 { 711 AtkStateSet* stateSet = ATK_OBJECT_CLASS(webkit _accessible_parent_class)->ref_state_set(object);711 AtkStateSet* stateSet = ATK_OBJECT_CLASS(webkitAccessibleParentClass)->ref_state_set(object); 712 712 AccessibilityObject* coreObject = core(object); 713 713 … … 728 728 static AtkRelationSet* webkitAccessibleRefRelationSet(AtkObject* object) 729 729 { 730 AtkRelationSet* relationSet = ATK_OBJECT_CLASS(webkit _accessible_parent_class)->ref_relation_set(object);730 AtkRelationSet* relationSet = ATK_OBJECT_CLASS(webkitAccessibleParentClass)->ref_relation_set(object); 731 731 AccessibilityObject* coreObject = core(object); 732 732 … … 738 738 static void webkitAccessibleInit(AtkObject* object, gpointer data) 739 739 { 740 if (ATK_OBJECT_CLASS(webkit _accessible_parent_class)->initialize)741 ATK_OBJECT_CLASS(webkit _accessible_parent_class)->initialize(object, data);740 if (ATK_OBJECT_CLASS(webkitAccessibleParentClass)->initialize) 741 ATK_OBJECT_CLASS(webkitAccessibleParentClass)->initialize(object, data); 742 742 743 743 WEBKIT_ACCESSIBLE(object)->m_object = reinterpret_cast<AccessibilityObject*>(data); … … 749 749 returnString(String()); 750 750 751 G_OBJECT_CLASS(webkit _accessible_parent_class)->finalize(object);752 } 753 754 static void webkit _accessible_class_init(AtkObjectClass* klass)751 G_OBJECT_CLASS(webkitAccessibleParentClass)->finalize(object); 752 } 753 754 static void webkitAccessibleClassInit(AtkObjectClass* klass) 755 755 { 756 756 GObjectClass* gobjectClass = G_OBJECT_CLASS(klass); 757 757 758 webkit _accessible_parent_class = g_type_class_peek_parent(klass);758 webkitAccessibleParentClass = g_type_class_peek_parent(klass); 759 759 760 760 gobjectClass->finalize = webkitAccessibleFinalize; … … 774 774 775 775 GType 776 webkit _accessible_get_type(void)777 { 778 static volatile gsize type _volatile = 0;779 780 if (g_once_init_enter(&type _volatile)) {776 webkitAccessibleGetType(void) 777 { 778 static volatile gsize typeVolatile = 0; 779 780 if (g_once_init_enter(&typeVolatile)) { 781 781 static const GTypeInfo tinfo = { 782 782 sizeof(WebKitAccessibleClass), 783 783 (GBaseInitFunc) 0, 784 784 (GBaseFinalizeFunc) 0, 785 (GClassInitFunc) webkit _accessible_class_init,785 (GClassInitFunc) webkitAccessibleClassInit, 786 786 (GClassFinalizeFunc) 0, 787 787 0, /* class data */ … … 792 792 }; 793 793 794 GType type = g_type_register_static(ATK_TYPE_OBJECT, 795 "WebKitAccessible", &tinfo, GTypeFlags(0)); 796 g_once_init_leave(&type_volatile, type); 797 } 798 799 return type_volatile; 794 GType type = g_type_register_static(ATK_TYPE_OBJECT, "WebKitAccessible", &tinfo, GTypeFlags(0)); 795 g_once_init_leave(&typeVolatile, type); 796 } 797 798 return typeVolatile; 800 799 } 801 800 … … 971 970 return type; 972 971 973 type = g_type_register_static(WEBKIT_TYPE_ACCESSIBLE, 974 atkTypeName, 975 &typeInfo, GTypeFlags(0)); 972 type = g_type_register_static(WEBKIT_TYPE_ACCESSIBLE, atkTypeName, &typeInfo, GTypeFlags(0)); 976 973 for (guint i = 0; i < G_N_ELEMENTS(AtkInterfacesInitFunctions); i++) { 977 974 if (interfaceMask & (1 << i)) 978 975 g_type_add_interface_static(type, 979 980 976 GetAtkInterfaceTypeFromWAIType(static_cast<WAIType>(i)), 977 &AtkInterfacesInitFunctions[i]); 981 978 } 982 979 -
trunk/Source/WebCore/accessibility/atk/WebKitAccessibleWrapperAtk.h
r134938 r134939 31 31 G_BEGIN_DECLS 32 32 33 #define WEBKIT_TYPE_ACCESSIBLE (webkit _accessible_get_type ())33 #define WEBKIT_TYPE_ACCESSIBLE (webkitAccessibleGetType ()) 34 34 #define WEBKIT_ACCESSIBLE(obj) (G_TYPE_CHECK_INSTANCE_CAST ((obj), WEBKIT_TYPE_ACCESSIBLE, WebKitAccessible)) 35 35 #define WEBKIT_ACCESSIBLE_CLASS(klass) (G_TYPE_CHECK_CLASS_CAST ((klass), WEBKIT_TYPE_ACCESSIBLE, WebKitAccessibleClass)) … … 47 47 48 48 struct _WebKitAccessibleClass { 49 AtkObjectClass parent _class;49 AtkObjectClass parentClass; 50 50 }; 51 51 52 GType webkit _accessible_get_type(void) G_GNUC_CONST;52 GType webkitAccessibleGetType(void) G_GNUC_CONST; 53 53 54 54 WebKitAccessible* webkitAccessibleNew(WebCore::AccessibilityObject*);
Note: See TracChangeset
for help on using the changeset viewer.