Changeset 135110 in webkit

Timestamp:

Nov 18, 2012 9:50:44 PM (11 years ago)

Author:

commit-queue@webkit.org

Message:

min/max/step support for calendar picker on datetime/datetime-local
​https://bugs.webkit.org/show_bug.cgi?id=102628

Patch by Kunihiko Sakamoto <​ksakamoto@chromium.org> on 2012-11-18
Reviewed by Kent Tamura.

Source/WebCore:

Gray out dates with no allowed values on calendar picker for datetime/datetime-local
when values are limited by min/max/step attributes.

Test: platform/chromium/fast/forms/calendar-picker/calendar-picker-datetime-with-step.html

• Resources/pagepopups/calendarPicker.js:

(CalendarPicker.prototype._stepMismatch):
Returns true iff there are any allowed values in the given day.

LayoutTests:

Verify that calendar picker has correct available dates when
min/max/step attributes are set in datetime input.

• platform/chromium/fast/forms/calendar-picker/calendar-picker-datetime-with-step-expected.txt: Added.
• platform/chromium/fast/forms/calendar-picker/calendar-picker-datetime-with-step.html: Added.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/platform/chromium/fast/forms/calendar-picker/calendar-picker-datetime-with-step-expected.txt (added)
• LayoutTests/platform/chromium/fast/forms/calendar-picker/calendar-picker-datetime-with-step.html (added)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/Resources/pagepopups/calendarPicker.js (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2012-11-18  Kunihiko Sakamoto  <ksakamoto@chromium.org>
+
+        min/max/step support for calendar picker on datetime/datetime-local
+        https://bugs.webkit.org/show_bug.cgi?id=102628
+
+        Reviewed by Kent Tamura.
+
+        Verify that calendar picker has correct available dates when
+        min/max/step attributes are set in datetime input.
+
+        * platform/chromium/fast/forms/calendar-picker/calendar-picker-datetime-with-step-expected.txt: Added.
+        * platform/chromium/fast/forms/calendar-picker/calendar-picker-datetime-with-step.html: Added.
+
 2012-11-18  Kentaro Hara  <haraken@chromium.org>
 

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2012-11-18  Kunihiko Sakamoto  <ksakamoto@chromium.org>
+
+        min/max/step support for calendar picker on datetime/datetime-local
+        https://bugs.webkit.org/show_bug.cgi?id=102628
+
+        Reviewed by Kent Tamura.
+
+        Gray out dates with no allowed values on calendar picker for datetime/datetime-local
+        when values are limited by min/max/step attributes.
+
+        Test: platform/chromium/fast/forms/calendar-picker/calendar-picker-datetime-with-step.html
+
+        * Resources/pagepopups/calendarPicker.js:
+        (CalendarPicker.prototype._stepMismatch):
+        Returns true iff there are any allowed values in the given day.
+
 2012-11-18  Laszlo Gombos  <l.gombos@samsung.com>
 

trunk/Source/WebCore/Resources/pagepopups/calendarPicker.js

@@ -1220 +1220 @@
  */
 CalendarPicker.prototype._stepMismatch = function(value) {
-    return (value - this.stepBase) % this.step != 0;
+    var nextAllowedValue = Math.ceil((value - this.stepBase) / this.step) * this.step + this.stepBase;
+    return nextAllowedValue >= value + this.selectionConstructor.DefaultStep
 }