Changeset 135307 in webkit


Ignore:
Timestamp:
Nov 20, 2012 1:00:08 PM (11 years ago)
Author:
commit-queue@webkit.org
Message:

animations/stop-animation-on-suspend.html sometimes fails on all platforms
​https://bugs.webkit.org/show_bug.cgi?id=49182

Patch by Jussi Kukkonen <​jussi.kukkonen@intel.com> on 2012-11-20
Reviewed by Antti Koivisto.

stop-animation-on-suspend incorrectly assumed that animation in a subframe would start
roughly at document load. Keep both animations (one in main frame, one in iframe) paused
until the iframe is loaded: this way they should run synchronised enough.

Also increase the tolerance of the test slightly: measuring timing like this is inherently flaky.

Remove failure expectation from all TestExpectations and remove the clearly wrong expected
result for chromium-mac.

  • animations/resources/stop-animation-on-suspend-subframe.html:
  • animations/stop-animation-on-suspend.html:
  • platform/chromium/TestExpectations:
  • platform/chromium-mac/animations/stop-animation-on-suspend-expected.txt:
  • platform/efl/TestExpectations:
  • platform/gtk/TestExpectations:
  • platform/mac/TestExpectations:
  • platform/qt-arm/TestExpectations:
  • platform/win/TestExpectations:
  • platform/wincairo/TestExpectations:
Location:
trunk/LayoutTests
Files:
1 deleted
10 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r135306 r135307  
     12012-11-20  Jussi Kukkonen  <jussi.kukkonen@intel.com>
     2
     3        animations/stop-animation-on-suspend.html sometimes fails on all platforms
     4        https://bugs.webkit.org/show_bug.cgi?id=49182
     5
     6        Reviewed by Antti Koivisto.
     7
     8        stop-animation-on-suspend incorrectly assumed that animation in a subframe would start
     9        roughly at document load. Keep both animations (one in main frame, one in iframe) paused
     10        until the iframe is loaded: this way they should run synchronised enough.
     11
     12        Also increase the tolerance of the test slightly: measuring timing like this is inherently flaky.
     13
     14        Remove failure expectation from all TestExpectations and remove the clearly wrong expected
     15        result for chromium-mac.
     16
     17        * animations/resources/stop-animation-on-suspend-subframe.html:
     18        * animations/stop-animation-on-suspend.html:
     19        * platform/chromium/TestExpectations:
     20        * platform/chromium-mac/animations/stop-animation-on-suspend-expected.txt:
     21        * platform/efl/TestExpectations:
     22        * platform/gtk/TestExpectations:
     23        * platform/mac/TestExpectations:
     24        * platform/qt-arm/TestExpectations:
     25        * platform/win/TestExpectations:
     26        * platform/wincairo/TestExpectations:
     27
    1282012-11-20  Mike Reed  <reed@google.com>
    229

  • trunk/LayoutTests/animations/resources/stop-animation-on-suspend-subframe.html

    r71424 r135307  
    1313        overflow:hidden;
    1414        -webkit-animation: move 400ms alternate infinite linear;
     15        -webkit-animation-play-state:paused;
    1516    }
    1617

  • trunk/LayoutTests/animations/stop-animation-on-suspend.html

    r116729 r135307  
    33<html>
    44<head>
    5   <title>Test that animations stop on suspend</title>
     5  <title>Test that animations stop on suspend, also when they are inside subframes</title>
    66  <style type="text/css" media="screen">
    77    iframe {
    … …  
    2121        overflow:hidden;
    2222        -webkit-animation: move 400ms alternate infinite linear;
     23        -webkit-animation-play-state:paused;
    2324    }
    2425
    … …  
    3334    const expectedValues = [
    3435      // [animation-name, time, element-id, property, expected-value, tolerance]
    35       ["move", 0.2, "box", "webkitTransform", [1,0,0,1, 100, 0], 30],
    36       ["move", 0.2, "iframe.subframe-box", "webkitTransform", [1,0,0,1, 100, 0], 30],
    37       ["move", 0.4, "box", "webkitTransform", [1,0,0,1, 200, 0], 30],
    38       ["move", 0.4, "iframe.subframe-box", "webkitTransform", [1,0,0,1, 200, 0], 30],
     36      ["move", 0.2, "box", "webkitTransform", [1,0,0,1, 100, 0], 40],
     37      ["move", 0.2, "iframe.subframe-box", "webkitTransform", [1,0,0,1, 100, 0], 40],
     38      ["move", 0.4, "box", "webkitTransform", [1,0,0,1, 200, 0], 40],
     39      ["move", 0.4, "iframe.subframe-box", "webkitTransform", [1,0,0,1, 200, 0], 40],
    3940    ];
    4041   
    … …  
    5758    }
    5859
    59     runAnimationTest(expectedValues, setTimers, undefined, true);
    60    
     60    function iframeOnLoad()
     61    {
     62        var box = document.getElementById("box");
     63        var subFrameBox = document.getElementById("iframe").contentDocument.getElementById("subframe-box");
     64
     65        box.style.webkitAnimationPlayState="running";
     66        subFrameBox.style.webkitAnimationPlayState="running";
     67
     68        runAnimationTest(expectedValues, setTimers, undefined, true);
     69    }
     70
    6171  </script>
    6272</head>
    … …  
    6474    <div class="box" id="box"></div>
    6575    <!-- The parent document may into compositing mode by the iframe. -->
    66     <iframe id="iframe" src="resources/stop-animation-on-suspend-subframe.html"></iframe>
     76    <iframe id="iframe" onload="iframeOnLoad();" src="resources/stop-animation-on-suspend-subframe.html"></iframe>
    6777    <div id="result"></div>
    6878</body>

  • trunk/LayoutTests/platform/chromium/TestExpectations

    r135306 r135307  
    24762476
    24772477# Added in WK r71424
    2478 # We should probably just skip this test, everyone else has since
    24792478# https://bugs.webkit.org/show_bug.cgi?id=49182
    2480 crbug.com/62138 [ Debug ] animations/stop-animation-on-suspend.html [ Crash Failure Pass ]
    2481 crbug.com/62138 [ Release ] animations/stop-animation-on-suspend.html [ Failure Pass ]
     2479crbug.com/62138 [ Debug ] animations/stop-animation-on-suspend.html [ Crash Pass ]
    24822480
    24832481crbug.com/61739 [ Debug ] animations/suspend-resume-animation-events.html [ Failure Pass ]

  • trunk/LayoutTests/platform/efl/TestExpectations

    r135278 r135307  
    998998webkit.org/b/84589 http/tests/security/cross-frame-access-get.html [ Failure ]
    999999
    1000 # Issue with timing for suspend/resumeAnimations()?
    1001 webkit.org/b/84592 animations/stop-animation-on-suspend.html [ Failure ]
    1002 
    10031000# IndexedDB is not yet enabled.
    10041001Bug(EFL) storage/indexeddb

  • trunk/LayoutTests/platform/gtk/TestExpectations

    r135273 r135307  
    548548webkit.org/b/83878 media/track/track-mode.html [ Failure Pass ]
    549549webkit.org/b/88867 media/track/track-cue-rendering-snap-to-lines-not-set.html [ Failure Pass ]
    550 
    551 webkit.org/b/49179 animations/stop-animation-on-suspend.html [ Failure Pass ]
    552550
    553551webkit.org/b/61121 http/tests/appcache/interrupted-update.html [ Failure Pass ]

  • trunk/LayoutTests/platform/mac/TestExpectations

    r135228 r135307  
    326326plugins/evaluate-js-after-removing-plugin-element.html
    327327
    328 # Very flaky: https://bugs.webkit.org/show_bug.cgi?id=49182
    329 animations/stop-animation-on-suspend.html
    330 
    331328# DRT does not support toggling caret browsing on / off
    332329editing/selection/caret-mode-paragraph-keys-navigation.html

  • trunk/LayoutTests/platform/qt-arm/TestExpectations

    r133596 r135307  
    141141
    142142# New failing tests
    143 animations/stop-animation-on-suspend.html
    144143editing/selection/regional-indicators.html
    145144fast/dom/Window/window-property-descriptors.html

  • trunk/LayoutTests/platform/win/TestExpectations

    r135228 r135307  
    444444# Sometimes times out http://webkit.org/b/49014
    445445fast/workers/storage/change-version-handle-reuse-sync.html
    446 
    447 # Sometimes fails http://webkit.org/b/49182
    448 animations/stop-animation-on-suspend.html
    449446
    450447# Crashing in AccessibilityUIElement::parentElement http://webkit.org/b/49379

  • trunk/LayoutTests/platform/wincairo/TestExpectations

    r135228 r135307  
    978978fast/workers/storage/change-version-handle-reuse-sync.html
    979979
    980 # Sometimes fails http://webkit.org/b/49182
    981 animations/stop-animation-on-suspend.html
    982 
    983980# Crashing in AccessibilityUIElement::parentElement http://webkit.org/b/49379
    984981accessibility/iframe-bastardization.html
Note: See TracChangeset for help on using the changeset viewer.