Changeset 135364 in webkit


Ignore:
Timestamp:
Nov 21, 2012 1:56:57 AM (11 years ago)
Author:
commit-queue@webkit.org
Message:

Unreviewed, rolling out r135307.
​http://trac.webkit.org/changeset/135307
​https://bugs.webkit.org/show_bug.cgi?id=102905

Jussi said this doesn't definitively fix things, so revert for
now. (Requested by rakuco on #webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2012-11-21

  • animations/resources/stop-animation-on-suspend-subframe.html:
  • animations/stop-animation-on-suspend.html:
  • platform/chromium-mac/animations/stop-animation-on-suspend-expected.txt: Added.
  • platform/chromium/TestExpectations:
  • platform/efl/TestExpectations:
  • platform/gtk/TestExpectations:
  • platform/mac/TestExpectations:
  • platform/qt-arm/TestExpectations:
  • platform/win/TestExpectations:
  • platform/wincairo/TestExpectations:
Location:
trunk/LayoutTests
Files:
1 added
10 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r135356 r135364  
     12012-11-21  Sheriff Bot  <webkit.review.bot@gmail.com>
     2
     3        Unreviewed, rolling out r135307.
     4        http://trac.webkit.org/changeset/135307
     5        https://bugs.webkit.org/show_bug.cgi?id=102905
     6
     7        Jussi said this doesn't definitively fix things, so revert for
     8        now. (Requested by rakuco on #webkit).
     9
     10        * animations/resources/stop-animation-on-suspend-subframe.html:
     11        * animations/stop-animation-on-suspend.html:
     12        * platform/chromium-mac/animations/stop-animation-on-suspend-expected.txt: Added.
     13        * platform/chromium/TestExpectations:
     14        * platform/efl/TestExpectations:
     15        * platform/gtk/TestExpectations:
     16        * platform/mac/TestExpectations:
     17        * platform/qt-arm/TestExpectations:
     18        * platform/win/TestExpectations:
     19        * platform/wincairo/TestExpectations:
     20
    1212012-11-21  Yury Semikhatsky  <yurys@chromium.org>
    222

  • trunk/LayoutTests/animations/resources/stop-animation-on-suspend-subframe.html

    r135307 r135364  
    1313        overflow:hidden;
    1414        -webkit-animation: move 400ms alternate infinite linear;
    15         -webkit-animation-play-state:paused;
    1615    }
    1716

  • trunk/LayoutTests/animations/stop-animation-on-suspend.html

    r135307 r135364  
    33<html>
    44<head>
    5   <title>Test that animations stop on suspend, also when they are inside subframes</title>
     5  <title>Test that animations stop on suspend</title>
    66  <style type="text/css" media="screen">
    77    iframe {
    … …  
    2121        overflow:hidden;
    2222        -webkit-animation: move 400ms alternate infinite linear;
    23         -webkit-animation-play-state:paused;
    2423    }
    2524
    … …  
    3433    const expectedValues = [
    3534      // [animation-name, time, element-id, property, expected-value, tolerance]
    36       ["move", 0.2, "box", "webkitTransform", [1,0,0,1, 100, 0], 40],
    37       ["move", 0.2, "iframe.subframe-box", "webkitTransform", [1,0,0,1, 100, 0], 40],
    38       ["move", 0.4, "box", "webkitTransform", [1,0,0,1, 200, 0], 40],
    39       ["move", 0.4, "iframe.subframe-box", "webkitTransform", [1,0,0,1, 200, 0], 40],
     35      ["move", 0.2, "box", "webkitTransform", [1,0,0,1, 100, 0], 30],
     36      ["move", 0.2, "iframe.subframe-box", "webkitTransform", [1,0,0,1, 100, 0], 30],
     37      ["move", 0.4, "box", "webkitTransform", [1,0,0,1, 200, 0], 30],
     38      ["move", 0.4, "iframe.subframe-box", "webkitTransform", [1,0,0,1, 200, 0], 30],
    4039    ];
    4140   
    … …  
    5857    }
    5958
    60     function iframeOnLoad()
    61     {
    62         var box = document.getElementById("box");
    63         var subFrameBox = document.getElementById("iframe").contentDocument.getElementById("subframe-box");
    64 
    65         box.style.webkitAnimationPlayState="running";
    66         subFrameBox.style.webkitAnimationPlayState="running";
    67 
    68         runAnimationTest(expectedValues, setTimers, undefined, true);
    69     }
    70 
     59    runAnimationTest(expectedValues, setTimers, undefined, true);
     60   
    7161  </script>
    7262</head>
    … …  
    7464    <div class="box" id="box"></div>
    7565    <!-- The parent document may into compositing mode by the iframe. -->
    76     <iframe id="iframe" onload="iframeOnLoad();" src="resources/stop-animation-on-suspend-subframe.html"></iframe>
     66    <iframe id="iframe" src="resources/stop-animation-on-suspend-subframe.html"></iframe>
    7767    <div id="result"></div>
    7868</body>

  • trunk/LayoutTests/platform/chromium/TestExpectations

    r135356 r135364  
    24742474
    24752475# Added in WK r71424
     2476# We should probably just skip this test, everyone else has since
    24762477# https://bugs.webkit.org/show_bug.cgi?id=49182
    2477 crbug.com/62138 [ Debug ] animations/stop-animation-on-suspend.html [ Crash Pass ]
     2478crbug.com/62138 [ Debug ] animations/stop-animation-on-suspend.html [ Crash Failure Pass ]
     2479crbug.com/62138 [ Release ] animations/stop-animation-on-suspend.html [ Failure Pass ]
    24782480
    24792481crbug.com/61739 [ Debug ] animations/suspend-resume-animation-events.html [ Failure Pass ]

  • trunk/LayoutTests/platform/efl/TestExpectations

    r135348 r135364  
    998998webkit.org/b/84589 http/tests/security/cross-frame-access-get.html [ Failure ]
    999999
     1000# Issue with timing for suspend/resumeAnimations()?
     1001webkit.org/b/84592 animations/stop-animation-on-suspend.html [ Failure ]
     1002
    10001003# IndexedDB is not yet enabled.
    10011004Bug(EFL) storage/indexeddb

  • trunk/LayoutTests/platform/gtk/TestExpectations

    r135337 r135364  
    548548webkit.org/b/83878 media/track/track-mode.html [ Failure Pass ]
    549549webkit.org/b/88867 media/track/track-cue-rendering-snap-to-lines-not-set.html [ Failure Pass ]
     550
     551webkit.org/b/49179 animations/stop-animation-on-suspend.html [ Failure Pass ]
    550552
    551553webkit.org/b/61121 http/tests/appcache/interrupted-update.html [ Failure Pass ]

  • trunk/LayoutTests/platform/mac/TestExpectations

    r135337 r135364  
    326326plugins/evaluate-js-after-removing-plugin-element.html
    327327
     328# Very flaky: https://bugs.webkit.org/show_bug.cgi?id=49182
     329animations/stop-animation-on-suspend.html
     330
    328331# DRT does not support toggling caret browsing on / off
    329332editing/selection/caret-mode-paragraph-keys-navigation.html

  • trunk/LayoutTests/platform/qt-arm/TestExpectations

    r135307 r135364  
    141141
    142142# New failing tests
     143animations/stop-animation-on-suspend.html
    143144editing/selection/regional-indicators.html
    144145fast/dom/Window/window-property-descriptors.html

  • trunk/LayoutTests/platform/win/TestExpectations

    r135337 r135364  
    444444# Sometimes times out http://webkit.org/b/49014
    445445fast/workers/storage/change-version-handle-reuse-sync.html
     446
     447# Sometimes fails http://webkit.org/b/49182
     448animations/stop-animation-on-suspend.html
    446449
    447450# Crashing in AccessibilityUIElement::parentElement http://webkit.org/b/49379

  • trunk/LayoutTests/platform/wincairo/TestExpectations

    r135337 r135364  
    978978fast/workers/storage/change-version-handle-reuse-sync.html
    979979
     980# Sometimes fails http://webkit.org/b/49182
     981animations/stop-animation-on-suspend.html
     982
    980983# Crashing in AccessibilityUIElement::parentElement http://webkit.org/b/49379
    981984accessibility/iframe-bastardization.html
Note: See TracChangeset for help on using the changeset viewer.