Changeset 135553 in webkit

Timestamp:

Nov 22, 2012 6:54:10 PM (11 years ago)

Author:

commit-queue@webkit.org

Message:

Text Autosizing: Improve handling of nested comments on reddit.com
​https://bugs.webkit.org/show_bug.cgi?id=102409

Patch by John Mellor <​johnme@chromium.org> on 2012-11-22
Reviewed by Kenneth Rohde Christiansen.

Source/WebCore:

No longer consider overflow != visible as requiring an independent
cluster. Some sites (e.g. reddit.com) wrap ordinary blocks (such as
comments) in overflow:hidden or overflow:auto, for various reasons
(like allowing it to be scrollable, or clipping an element that sticks
out). These reasons are not sufficient justification for a new cluster.

On reddit.com this means that comments will all get the same multiplier,
rather than being independently assigned a variety of multipliers based
on how much text each comment contains (etc), which significantly
improves the look.

Test: fast/text-autosizing/cluster-narrow-in-wide-ohidden.html

• rendering/TextAutosizer.cpp:

(WebCore::TextAutosizer::isAutosizingCluster):

LayoutTests:

Added test to confirm that overflow:hidden no longer triggers a cluster.

• fast/text-autosizing/cluster-narrow-in-wide-ohidden-expected.html: Added.
• fast/text-autosizing/cluster-narrow-in-wide-ohidden.html: Added.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/fast/text-autosizing/cluster-narrow-in-wide-ohidden-expected.html (added)
• LayoutTests/fast/text-autosizing/cluster-narrow-in-wide-ohidden.html (added)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/rendering/TextAutosizer.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2012-11-22  John Mellor  <johnme@chromium.org>
+
+        Text Autosizing: Improve handling of nested comments on reddit.com
+        https://bugs.webkit.org/show_bug.cgi?id=102409
+
+        Reviewed by Kenneth Rohde Christiansen.
+
+        Added test to confirm that overflow:hidden no longer triggers a cluster.
+
+        * fast/text-autosizing/cluster-narrow-in-wide-ohidden-expected.html: Added.
+        * fast/text-autosizing/cluster-narrow-in-wide-ohidden.html: Added.
+
 2012-11-22  Stephen Chenney  <schenney@chromium.org>
 

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2012-11-22  John Mellor  <johnme@chromium.org>
+
+        Text Autosizing: Improve handling of nested comments on reddit.com
+        https://bugs.webkit.org/show_bug.cgi?id=102409
+
+        Reviewed by Kenneth Rohde Christiansen.
+
+        No longer consider overflow != visible as requiring an independent
+        cluster. Some sites (e.g. reddit.com) wrap ordinary blocks (such as
+        comments) in overflow:hidden or overflow:auto, for various reasons
+        (like allowing it to be scrollable, or clipping an element that sticks
+        out). These reasons are not sufficient justification for a new cluster.
+
+        On reddit.com this means that comments will all get the same multiplier,
+        rather than being independently assigned a variety of multipliers based
+        on how much text each comment contains (etc), which significantly
+        improves the look.
+
+        Test: fast/text-autosizing/cluster-narrow-in-wide-ohidden.html
+
+        * rendering/TextAutosizer.cpp:
+        (WebCore::TextAutosizer::isAutosizingCluster):
+
 2012-11-22  Pravin D  <pravind.2k4@gmail.com>
 

trunk/Source/WebCore/rendering/TextAutosizer.cpp

@@ -236 +236 @@
         || renderer->isFlexibleBoxIncludingDeprecated()
         || renderer->hasColumns()
-        || renderer->style()->overflowX() != OVISIBLE
-        || renderer->style()->overflowY() != OVISIBLE
         || renderer->containingBlock()->isHorizontalWritingMode() != renderer->isHorizontalWritingMode();
     // FIXME: Tables need special handling to multiply all their columns by