Changeset 136039 in webkit

Timestamp:

Nov 28, 2012 12:05:47 PM (11 years ago)

Author:

Alexandru Chiculita

Message:

[CSS Regions] Auto-height regions will not calculate the height correctly when the content changes dynamically
​https://bugs.webkit.org/show_bug.cgi?id=102954

Reviewed by David Hyatt.

Source/WebCore:

Whenever the flow changes, we need to reset the region computed auto-heights.
However, when we reset the region heights to "auto" or "un-computed", we also need to make
sure that all the region breaks are counted again, so that we split regions correctly during the new layout.
I've reused the m_regionsInvalidated property to force the flow do a complete layout.

Test: fast/regions/autoheight-dynamic-update.html

• rendering/RenderFlowThread.cpp:

(WebCore::RenderFlowThread::resetRegionsOverrideLogicalContentHeight):

LayoutTests:

Added test to check for auto-height region size update after an element is added to the flow.
In this case the first region will need to resize to accommodate the size of the added elements.

• fast/regions/autoheight-dynamic-update-expected.html: Added.
• fast/regions/autoheight-dynamic-update.html: Added.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/fast/regions/autoheight-dynamic-update-expected.html (added)
• LayoutTests/fast/regions/autoheight-dynamic-update.html (added)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/rendering/RenderFlowThread.cpp (modified) (2 diffs)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2012-11-28  Alexandru Chiculita  <achicu@adobe.com>
+
+        [CSS Regions] Auto-height regions will not calculate the height correctly when the content changes dynamically
+        https://bugs.webkit.org/show_bug.cgi?id=102954
+
+        Reviewed by David Hyatt.
+
+        Added test to check for auto-height region size update after an element is added to the flow.
+        In this case the first region will need to resize to accommodate the size of the added elements.
+
+        * fast/regions/autoheight-dynamic-update-expected.html: Added.
+        * fast/regions/autoheight-dynamic-update.html: Added.
+
 2012-11-28  Andrew Scherkus  <scherkus@chromium.org>
 

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2012-11-28  Alexandru Chiculita  <achicu@adobe.com>
+
+        [CSS Regions] Auto-height regions will not calculate the height correctly when the content changes dynamically
+        https://bugs.webkit.org/show_bug.cgi?id=102954
+
+        Reviewed by David Hyatt.
+
+        Whenever the flow changes, we need to reset the region computed auto-heights.
+        However, when we reset the region heights to "auto" or "un-computed", we also need to make
+        sure that all the region breaks are counted again, so that we split regions correctly during the new layout.
+        I've reused the m_regionsInvalidated property to force the flow do a complete layout.
+
+        Test: fast/regions/autoheight-dynamic-update.html
+
+        * rendering/RenderFlowThread.cpp:
+        (WebCore::RenderFlowThread::resetRegionsOverrideLogicalContentHeight):
+
 2012-11-28  Alexandru Chiculita  <achicu@adobe.com>
 

trunk/Source/WebCore/rendering/RenderFlowThread.cpp

@@ -738 +738 @@
     // We need to reset the override logical content height for regions with auto logical height
     // only if the flow thread content needs layout.
-    if (!selfNeedsLayout())
+    if (!needsLayout())
         return;
 
@@ -754 +754 @@
         region->setNeedsLayout(true);
     }
+    // Make sure we don't skip any region breaks when we do the layout again.
+    // Using m_regionsInvalidated to force all the RenderFlowThread children do the layout again.
+    m_regionsInvalidated = true;
 }