Changeset 136341 in webkit

Timestamp:

Dec 2, 2012 4:49:09 AM (11 years ago)

Author:

commit-queue@webkit.org

Message:

Coordinated Graphics: Images disappear randomly
​https://bugs.webkit.org/show_bug.cgi?id=103522

Patch by Huang Dongsung <​luxtella@company100.net> on 2012-12-02
Reviewed by Kenneth Rohde Christiansen.

Currently, we delete layers before synchronizing layer states of layers. It
causes flash. This patch deletes layers after the synchronization.

In addiation, this patch removes updateViewport() in
LayerTreeCoordinatorProxy::deleteCompositingLayer() because
LayerTreeCoordinatorProxy::didRenderFrame() is always called after
deleting layers.

• UIProcess/CoordinatedGraphics/LayerTreeCoordinatorProxy.cpp:

(WebKit::LayerTreeCoordinatorProxy::deleteCompositingLayer):

• WebProcess/WebPage/CoordinatedGraphics/LayerTreeCoordinator.cpp:

(WebKit::LayerTreeCoordinator::flushPendingLayerChanges):

Location:

trunk/Source/WebKit2

Files:

• ChangeLog (modified) (1 diff)
• UIProcess/CoordinatedGraphics/LayerTreeCoordinatorProxy.cpp (modified) (1 diff)
• WebProcess/WebPage/CoordinatedGraphics/LayerTreeCoordinator.cpp (modified) (2 diffs)

trunk/Source/WebKit2/ChangeLog

@@ +1 @@
+2012-12-02  Huang Dongsung  <luxtella@company100.net>
+
+        Coordinated Graphics: Images disappear randomly
+        https://bugs.webkit.org/show_bug.cgi?id=103522
+
+        Reviewed by Kenneth Rohde Christiansen.
+
+        Currently, we delete layers before synchronizing layer states of layers. It
+        causes flash. This patch deletes layers after the synchronization.
+
+        In addiation, this patch removes updateViewport() in
+        LayerTreeCoordinatorProxy::deleteCompositingLayer() because
+        LayerTreeCoordinatorProxy::didRenderFrame() is always called after
+        deleting layers.
+
+        * UIProcess/CoordinatedGraphics/LayerTreeCoordinatorProxy.cpp:
+        (WebKit::LayerTreeCoordinatorProxy::deleteCompositingLayer):
+        * WebProcess/WebPage/CoordinatedGraphics/LayerTreeCoordinator.cpp:
+        (WebKit::LayerTreeCoordinator::flushPendingLayerChanges):
+
 2012-12-02  Brent Fulgham  <bfulgham@webkit.org>
 

trunk/Source/WebKit2/UIProcess/CoordinatedGraphics/LayerTreeCoordinatorProxy.cpp

@@ -95 +95 @@
 {
     dispatchUpdate(bind(&LayerTreeRenderer::deleteLayer, m_renderer.get(), id));
-    updateViewport();
 }
 

trunk/Source/WebKit2/WebProcess/WebPage/CoordinatedGraphics/LayerTreeCoordinator.cpp

@@ -269 +269 @@
         return false;
 
-    for (size_t i = 0; i < m_detachedLayers.size(); ++i)
-        m_webPage->send(Messages::LayerTreeCoordinatorProxy::DeleteCompositingLayer(m_detachedLayers[i]));
-    m_detachedLayers.clear();
-
     bool didSync = m_webPage->corePage()->mainFrame()->view()->flushCompositingStateIncludingSubframes();
     m_nonCompositedContentLayer->flushCompositingStateForThisLayerOnly();
@@ -286 +282 @@
         m_shouldSyncRootLayer = false;
     }
+
+    for (size_t i = 0; i < m_detachedLayers.size(); ++i)
+        m_webPage->send(Messages::LayerTreeCoordinatorProxy::DeleteCompositingLayer(m_detachedLayers[i]));
+    m_detachedLayers.clear();
 
     if (m_shouldSyncFrame) {