Changeset 13655 in webkit


Ignore:
Timestamp:
Apr 3, 2006 2:42:17 PM (18 years ago)
Author:
adele
Message:

LayoutTests:

Reviewed by Darin.

  • fast/repaint/inline-block-overflow-expected.png: Added.
  • fast/repaint/layer-outline-expected.checksum: Added.
  • fast/repaint/layer-outline-expected.png: Added.
  • fast/repaint/layer-outline-expected.txt: Added.
  • fast/repaint/layer-outline-horizontal-expected.checksum: Added.
  • fast/repaint/layer-outline-horizontal-expected.png: Added.
  • fast/repaint/layer-outline-horizontal-expected.txt: Added.
  • fast/repaint/layer-outline-horizontal.html: Added.
  • fast/repaint/layer-outline.html: Added.

WebCore:

Test: fast/repaint/layer-outline.html fast/repaint/layer-outline-horizontal.html

Reviewed by Darin.

  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::paintLayer): Use the outlineRect for the outline phase and do it only if the outlineRect isn't empty. (WebCore::RenderLayer::calculateRects): Actually add the outline width to the outline rect.
Location:
trunk
Files:
8 added
3 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r13654 r13655  
     12006-04-03  Mitz Pettel  <opendarwin.org@mitzpettel.com>
     2
     3        Reviewed by Darin.
     4
     5        - Test for http://bugzilla.opendarwin.org/show_bug.cgi?id=7943
     6          Layer outline does not repaint
     7
     8        * fast/repaint/inline-block-overflow-expected.png: Added.
     9        * fast/repaint/layer-outline-expected.checksum: Added.
     10        * fast/repaint/layer-outline-expected.png: Added.
     11        * fast/repaint/layer-outline-expected.txt: Added.
     12        * fast/repaint/layer-outline-horizontal-expected.checksum: Added.
     13        * fast/repaint/layer-outline-horizontal-expected.png: Added.
     14        * fast/repaint/layer-outline-horizontal-expected.txt: Added.
     15        * fast/repaint/layer-outline-horizontal.html: Added.
     16        * fast/repaint/layer-outline.html: Added.
     17
    1182006-04-03  Adele Peterson  <adele@apple.com>
    219

  • trunk/WebCore/ChangeLog

    r13654 r13655  
     12006-04-03  Mitz Pettel  <opendarwin.org@mitzpettel.com>
     2
     3        Test: fast/repaint/layer-outline.html fast/repaint/layer-outline-horizontal.html
     4
     5        Reviewed by Darin.
     6
     7        - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=7943
     8          Layer outline does not repaint
     9
     10        * rendering/RenderLayer.cpp:
     11        (WebCore::RenderLayer::paintLayer): Use the outlineRect for the
     12        outline phase and do it only if the outlineRect isn't empty.
     13        (WebCore::RenderLayer::calculateRects): Actually add the outline width to the
     14        outline rect.
     15
    1162006-04-03  Adele Peterson  <adele@apple.com>
    217

  • trunk/WebCore/rendering/RenderLayer.cpp

    r13605 r13655  
    11491149    }
    11501150   
    1151     // Paint our own outline
    1152     RenderObject::PaintInfo info(p, clipRectToApply, PaintPhaseSelfOutline, paintingRootForRenderer, 0);
    1153     setClip(p, paintDirtyRect, outlineRect);
    1154     renderer()->paint(info, tx, ty);
    1155     restoreClip(p, paintDirtyRect, outlineRect);
     1151    if (!outlineRect.isEmpty()) {
     1152        // Paint our own outline
     1153        RenderObject::PaintInfo info(p, outlineRect, PaintPhaseSelfOutline, paintingRootForRenderer, 0);
     1154        setClip(p, paintDirtyRect, outlineRect);
     1155        renderer()->paint(info, tx, ty);
     1156        restoreClip(p, paintDirtyRect, outlineRect);
     1157    }
    11561158   
    11571159    // Now walk the sorted list of children with positive z-indices.
    … …  
    13761378    layerBounds = IntRect(x,y,width(),height());
    13771379   
     1380    int outlineSize = renderer()->style()->outlineSize();
     1381    outlineRect.inflate(outlineSize);
    13781382    // Update the clip rects that will be passed to child layers.
    13791383    if (m_object->hasOverflowClip() || m_object->hasClip()) {
    … …  
    13931397        backgroundRect.intersect(layerBounds);
    13941398    }
     1399    outlineRect.intersect(paintDirtyRect);
    13951400}
    13961401
Note: See TracChangeset for help on using the changeset viewer.