Changeset 136965 in webkit

Timestamp:

Dec 7, 2012 11:16:49 AM (11 years ago)

Author:

commit-queue@webkit.org

Message:

[BlackBerry] Update BlackBerry Port to use new Graphics::createBuffer BufferType enum values.
​https://bugs.webkit.org/show_bug.cgi?id=104121

Patch by Mike Lattanzio <​mlattanzio@rim.com> on 2012-12-07
Reviewed by Rob Buis.

Source/WebKit/blackberry:

Update createBuffer calls to reflect new BufferType enum.
Set buffers opaque if possible to avoid unnecessary blends.
Internal PR 254649
Internal Review: Jakob Petsovits

• WebKitSupport/BackingStoreTile.cpp:

(BlackBerry::WebKit::TileBuffer::nativeBuffer):

Tools:

Update createBuffer call to reflect new BufferType enum.
Internal PR 254649
Internal Review: Jakob Petsovits

DRT is always backed for maximum compatibility.

• DumpRenderTree/blackberry/PixelDumpSupportBlackBerry.cpp:

(createBitmapContextFromWebView):

Location:

trunk

Files:

• Source/WebKit/blackberry/Api/BackingStore.cpp (modified) (1 diff)
• Source/WebKit/blackberry/ChangeLog (modified) (1 diff)
• Source/WebKit/blackberry/WebKitSupport/BackingStoreTile.cpp (modified) (1 diff)
• Tools/ChangeLog (modified) (1 diff)
• Tools/DumpRenderTree/blackberry/PixelDumpSupportBlackBerry.cpp (modified) (1 diff)

trunk/Source/WebKit/blackberry/Api/BackingStore.cpp

@@ -1120 +1120 @@
 
         BlackBerry::Platform::Graphics::Buffer* nativeBuffer = backBuffer->nativeBuffer();
+        BlackBerry::Platform::Graphics::setBufferOpaqueHint(nativeBuffer, !Color(m_webPage->settings()->backgroundColor()).hasAlpha());
 
         // TODO: This code is only needed for EGLImage code path, but preferrably BackingStore

trunk/Source/WebKit/blackberry/ChangeLog

@@ +1 @@
+2012-12-07  Mike Lattanzio  <mlattanzio@rim.com>
+
+        [BlackBerry] Update BlackBerry Port to use new Graphics::createBuffer BufferType enum values.
+        https://bugs.webkit.org/show_bug.cgi?id=104121
+
+        Reviewed by Rob Buis.
+
+        Update createBuffer calls to reflect new BufferType enum.
+        Set buffers opaque if possible to avoid unnecessary blends.
+        Internal PR 254649
+        Internal Review: Jakob Petsovits
+
+        * WebKitSupport/BackingStoreTile.cpp:
+        (BlackBerry::WebKit::TileBuffer::nativeBuffer):
+
 2012-12-07  Andrew Lo  <anlo@rim.com>
 

trunk/Source/WebKit/blackberry/WebKitSupport/BackingStoreTile.cpp

@@ -102 +102 @@
 {
     if (!m_nativeBuffer)
-        m_nativeBuffer = createBuffer(m_size, Platform::Graphics::TileBuffer, SurfacePool::globalSurfacePool()->sharedPixmapGroup());
+        m_nativeBuffer = createBuffer(m_size, Platform::Graphics::AlwaysBacked, SurfacePool::globalSurfacePool()->sharedPixmapGroup());
 
     return m_nativeBuffer;

trunk/Tools/ChangeLog

@@ +1 @@
+2012-12-07  Mike Lattanzio  <mlattanzio@rim.com>
+
+        [BlackBerry] Update BlackBerry Port to use new Graphics::createBuffer BufferType enum values.
+        https://bugs.webkit.org/show_bug.cgi?id=104121
+
+        Reviewed by Rob Buis.
+
+        Update createBuffer call to reflect new BufferType enum.
+        Internal PR 254649
+        Internal Review: Jakob Petsovits
+
+        DRT is always backed for maximum compatibility.
+
+        * DumpRenderTree/blackberry/PixelDumpSupportBlackBerry.cpp:
+        (createBitmapContextFromWebView):
+
 2012-12-07  Jochen Eisinger  <jochen@chromium.org>
 

trunk/Tools/DumpRenderTree/blackberry/PixelDumpSupportBlackBerry.cpp

@@ -87 +87 @@
     }
 #else
-    BlackBerry::Platform::Graphics::Buffer* buffer = BlackBerry::Platform::Graphics::createBuffer(windowSize, BlackBerry::Platform::Graphics::TemporaryBuffer);
+    BlackBerry::Platform::Graphics::Buffer* buffer = BlackBerry::Platform::Graphics::createBuffer(windowSize, BlackBerry::Platform::Graphics::AlwaysBacked);
     BlackBerry::Platform::Graphics::Drawable* drawable = BlackBerry::Platform::Graphics::lockBufferDrawable(buffer);
     if (drawable) {