Changeset 137206 in webkit

Timestamp:

Dec 10, 2012 2:15:01 PM (11 years ago)

Author:

commit-queue@webkit.org

Message:

Deprecate prefixed linear-gradient and radial-gradient functions
​https://bugs.webkit.org/show_bug.cgi?id=104591

Patch by Tab Atkins <​jackalmage@gmail.com> on 2012-12-10
Reviewed by Dean Jackson.

Rename the old gradient parsing functions in anticipation of functions that parse the new syntax.

No new tests added - this is a rename and has no functionality change.

• css/CSSParser.cpp:

(WebCore::CSSParser::parseDeprecatedLinearGradient):
(WebCore::CSSParser::parseDeprecatedRadialGradient):
(WebCore::CSSParser::parseGeneratedImage):

• css/CSSParser.h:

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• css/CSSParser.cpp (modified) (3 diffs)
• css/CSSParser.h (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2012-12-10  Tab Atkins  <jackalmage@gmail.com>
+
+        Deprecate prefixed linear-gradient and radial-gradient functions
+        https://bugs.webkit.org/show_bug.cgi?id=104591
+
+        Reviewed by Dean Jackson.
+
+        Rename the old gradient parsing functions in anticipation of functions that parse the new syntax.
+
+        No new tests added - this is a rename and has no functionality change.
+
+        * css/CSSParser.cpp:
+        (WebCore::CSSParser::parseDeprecatedLinearGradient):
+        (WebCore::CSSParser::parseDeprecatedRadialGradient):
+        (WebCore::CSSParser::parseGeneratedImage):
+        * css/CSSParser.h:
+
 2012-12-10  Mark Pilgrim  <pilgrim@chromium.org>
 

trunk/Source/WebCore/css/CSSParser.cpp

@@ -7121 +7121 @@
 }
 
-bool CSSParser::parseLinearGradient(CSSParserValueList* valueList, RefPtr<CSSValue>& gradient, CSSGradientRepeat repeating)
+bool CSSParser::parseDeprecatedLinearGradient(CSSParserValueList* valueList, RefPtr<CSSValue>& gradient, CSSGradientRepeat repeating)
 {
     RefPtr<CSSLinearGradientValue> result = CSSLinearGradientValue::create(repeating);
@@ -7189 +7189 @@
 }
 
-bool CSSParser::parseRadialGradient(CSSParserValueList* valueList, RefPtr<CSSValue>& gradient, CSSGradientRepeat repeating)
+bool CSSParser::parseDeprecatedRadialGradient(CSSParserValueList* valueList, RefPtr<CSSValue>& gradient, CSSGradientRepeat repeating)
 {
     RefPtr<CSSRadialGradientValue> result = CSSRadialGradientValue::create(repeating);
@@ -7371 +7371 @@
 
     if (equalIgnoringCase(val->function->name, "-webkit-linear-gradient("))
-        return parseLinearGradient(valueList, value, NonRepeating);
+        return parseDeprecatedLinearGradient(valueList, value, NonRepeating);
 
     if (equalIgnoringCase(val->function->name, "-webkit-repeating-linear-gradient("))
-        return parseLinearGradient(valueList, value, Repeating);
+        return parseDeprecatedLinearGradient(valueList, value, Repeating);
 
     if (equalIgnoringCase(val->function->name, "-webkit-radial-gradient("))
-        return parseRadialGradient(valueList, value, NonRepeating);
+        return parseDeprecatedRadialGradient(valueList, value, NonRepeating);
 
     if (equalIgnoringCase(val->function->name, "-webkit-repeating-radial-gradient("))
-        return parseRadialGradient(valueList, value, Repeating);
+        return parseDeprecatedRadialGradient(valueList, value, Repeating);
 
     if (equalIgnoringCase(val->function->name, "-webkit-canvas("))

trunk/Source/WebCore/css/CSSParser.h

@@ -213 +213 @@
 
     bool parseDeprecatedGradient(CSSParserValueList*, RefPtr<CSSValue>&);
-    bool parseLinearGradient(CSSParserValueList*, RefPtr<CSSValue>&, CSSGradientRepeat repeating);
-    bool parseRadialGradient(CSSParserValueList*, RefPtr<CSSValue>&, CSSGradientRepeat repeating);
+    bool parseDeprecatedLinearGradient(CSSParserValueList*, RefPtr<CSSValue>&, CSSGradientRepeat repeating);
+    bool parseDeprecatedRadialGradient(CSSParserValueList*, RefPtr<CSSValue>&, CSSGradientRepeat repeating);
     bool parseGradientColorStops(CSSParserValueList*, CSSGradientValue*, bool expectComma);