Changeset 137330 in webkit


Ignore:
Timestamp:
Dec 11, 2012 10:13:17 AM (11 years ago)
Author:
jsbell@chromium.org
Message:

[Chromium] IndexedDB: Memory leak in IDBCallbacksProxy::onSuccess(PassRefPtr<IDBDatabaseBackendInterface>)
https://bugs.webkit.org/show_bug.cgi?id=104615

Reviewed by Tony Chang.

Ensure passed pointer is treated with ownership semantics.

  • src/WebIDBCallbacksImpl.cpp:

(WebKit::WebIDBCallbacksImpl::onSuccess):

Location:
trunk/Source/WebKit/chromium
Files:
2 edited

Legend:

Unmodified
Added
Removed
  • trunk/Source/WebKit/chromium/ChangeLog

    r137327 r137330  
     12012-12-11  Joshua Bell  <jsbell@chromium.org>
     2
     3        [Chromium] IndexedDB: Memory leak in IDBCallbacksProxy::onSuccess(PassRefPtr<IDBDatabaseBackendInterface>)
     4        https://bugs.webkit.org/show_bug.cgi?id=104615
     5
     6        Reviewed by Tony Chang.
     7
     8        Ensure passed pointer is treated with ownership semantics.
     9
     10        * src/WebIDBCallbacksImpl.cpp:
     11        (WebKit::WebIDBCallbacksImpl::onSuccess):
     12
    1132012-12-11  Mark Pilgrim  <pilgrim@chromium.org>
    214
  • trunk/Source/WebKit/chromium/src/WebIDBCallbacksImpl.cpp

    r136475 r137330  
    7474void WebIDBCallbacksImpl::onSuccess(WebIDBDatabase* webKitInstance)
    7575{
     76    OwnPtr<WebIDBDatabase> webDatabase = adoptPtr(webKitInstance);
    7677    if (m_databaseProxy) {
    7778        m_callbacks->onSuccess(m_databaseProxy.release());
    7879        return;
    7980    }
    80     m_callbacks->onSuccess(IDBDatabaseBackendProxy::create(adoptPtr(webKitInstance)));
     81    m_callbacks->onSuccess(IDBDatabaseBackendProxy::create(webDatabase.release()));
    8182}
    8283
Note: See TracChangeset for help on using the changeset viewer.