Changeset 137371 in webkit


Ignore:
Timestamp:
Dec 11, 2012 3:33:55 PM (11 years ago)
Author:
eric@webkit.org
Message:

Make Ninja the default build system for build-webkit --chromium
https://bugs.webkit.org/show_bug.cgi?id=104434

Reviewed by Daniel Bates.

As far as I can tell, most Chromium developers are now using Ninja
as their default build system instead of the native Xcode/Visual Studio/Make.
This change makes Ninja the default for developers as well as all Chromium webkit bots.

Developers can pass --no-ninja to get the platform-native buildsystem instead of Ninja.
It's possible we may wish to make this a per-platform default, and have
Ninja only be the default for Mac/Linux.

There was a thread on webkit-dev discussing this change:
http://lists.webkit.org/pipermail/webkit-dev/2012-December/023113.html

  • Scripts/update-webkit:
Location:
trunk/Tools
Files:
3 edited

Legend:

Unmodified
Added
Removed
  • trunk/Tools/ChangeLog

    r137356 r137371  
     12012-12-11  Eric Seidel  <eric@webkit.org>
     2
     3        Make Ninja the default build system for build-webkit --chromium
     4        https://bugs.webkit.org/show_bug.cgi?id=104434
     5
     6        Reviewed by Daniel Bates.
     7
     8        As far as I can tell, most Chromium developers are now using Ninja
     9        as their default build system instead of the native Xcode/Visual Studio/Make.
     10        This change makes Ninja the default for developers as well as all Chromium webkit bots.
     11
     12        Developers can pass --no-ninja to get the platform-native buildsystem instead of Ninja.
     13        It's possible we may wish to make this a per-platform default, and have
     14        Ninja only be the default for Mac/Linux.
     15
     16        There was a thread on webkit-dev discussing this change:
     17        http://lists.webkit.org/pipermail/webkit-dev/2012-December/023113.html
     18
     19        * Scripts/update-webkit:
     20
    1212012-12-11  Dirk Pranke  <dpranke@chromium.org>
    222
  • trunk/Tools/Scripts/update-webkit

    r132262 r137371  
    4848my $useGYP = 0;
    4949my $useMake = 0;
    50 my $useNinja = 0;
     50my $useNinja = 1;
    5151
    5252determineIsChromium();
     
    6262    'gyp' => \$useGYP,
    6363    'make' => \$useMake,
    64     'ninja' => \$useNinja,
     64    'ninja!' => \$useNinja,
    6565);
    6666
     
    7070  --chromium          also update dependencies of the chromium port
    7171  --make              generate the Makefile-based build system (Chromium only)
    72   --ninja             generate the ninja-based build system (Chromium only)
     72  --no-ninja          generate the platform-native build system instead of ninja (Chromium only)
    7373  --chromium-android  also update dependencies of the chromium port for Android
    7474  -h|--help           show the help message
  • trunk/Tools/Scripts/webkitdirs.pm

    r137270 r137371  
    25462546        # Windows build - builds the root visual studio solution.
    25472547        $result = buildChromiumVisualStudioProject("Source/WebKit/chromium/All.sln", $clean);
    2548     } elsif (isChromiumNinja() && !isChromiumAndroid()) {
     2548    } elsif (isChromiumNinja()) {
    25492549        $result = buildChromiumNinja("all", $clean, @options);
    25502550    } elsif (isLinux() || isChromiumAndroid() || isChromiumMacMake()) {
Note: See TracChangeset for help on using the changeset viewer.