Changeset 137479 in webkit


Ignore:
Timestamp:
Dec 12, 2012 10:19:09 AM (11 years ago)
Author:
mihnea@adobe.com
Message:

[CSS Regions] Two regions reftests are failing the image match
​https://bugs.webkit.org/show_bug.cgi?id=74219

Reviewed by Julien Chaffraix.

Modify the 2 tests that were failing on other platforms (chromium, qt, gtk, efl). The tests were failing because different platforms were having different default font-family, font-size
values. I have explicitly set the font-size, font-family and the line-height for the text that will be paginated in regions. Also changed the text color to yellow,
so that we are able to see how the text lines are displayed in each region.

  • fast/regions/positioned-objects-block-static-spanning-regions-expected.html:
  • fast/regions/positioned-objects-block-static-spanning-regions-rtl-expected.html:
  • fast/regions/positioned-objects-block-static-spanning-regions-rtl.html:
  • fast/regions/positioned-objects-block-static-spanning-regions.html:
  • platform/chromium/TestExpectations:
  • platform/efl-wk2/TestExpectations:
  • platform/efl/TestExpectations:
  • platform/gtk/TestExpectations:
  • platform/qt/TestExpectations:
Location:
trunk/LayoutTests
Files:
10 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r137478 r137479  
     12012-12-12  Mihnea Ovidenie  <mihnea@adobe.com>
     2
     3        [CSS Regions] Two regions reftests are failing the image match
     4        https://bugs.webkit.org/show_bug.cgi?id=74219
     5
     6        Reviewed by Julien Chaffraix.
     7
     8        Modify the 2 tests that were failing on other platforms (chromium, qt, gtk, efl). The tests were failing because different platforms were having different default font-family, font-size
     9        values. I have explicitly set the font-size, font-family and the line-height for the text that will be paginated in regions. Also changed the text color to yellow,
     10        so that we are able to see how the text lines are displayed in each region.
     11
     12        * fast/regions/positioned-objects-block-static-spanning-regions-expected.html:
     13        * fast/regions/positioned-objects-block-static-spanning-regions-rtl-expected.html:
     14        * fast/regions/positioned-objects-block-static-spanning-regions-rtl.html:
     15        * fast/regions/positioned-objects-block-static-spanning-regions.html:
     16        * platform/chromium/TestExpectations:
     17        * platform/efl-wk2/TestExpectations:
     18        * platform/efl/TestExpectations:
     19        * platform/gtk/TestExpectations:
     20        * platform/qt/TestExpectations:
     21
    1222012-12-12  Julien Chaffraix  <jchaffraix@webkit.org>
    223

  • trunk/LayoutTests/fast/regions/positioned-objects-block-static-spanning-regions-expected.html

    r137264 r137479  
    2828        height:100%;
    2929        background-color:#00a000;
    30         color:#00a000;
     30        color:#ffff00;
     31        font: 16px/1.25 monospace;
    3132    }
    3233
    … …  
    6667        <div class="grey-box1 greyColor">
    6768            <div class="green-box">
     69                Some text.<br>
     70                Some text.<br>
     71                Some text.<br>
     72                Some text.<br>
     73                Some text.<br>
     74                Some text.<br>
     75                Some text.<br>
    6876            </div>
    6977        </div>
    … …  
    7280        <div class="grey-box2 greyColor">
    7381            <div class="green-box">
     82                Some text.<br>
     83                Some text.<br>
     84                Some text.<br>
     85                Some text.<br>
     86                Some text.<br>
     87                Some text.<br>
     88                Some text.<br>
     89                Some text.<br>
     90                Some text.<br>
    7491            </div>
    7592        </div>
    … …  
    7895        <div class="grey-box3 greyColor">
    7996            <div class="green-box">
     97                Some text.<br>
     98                Some text.<br>
     99                Some text.<br>
    80100            </div>
    81101        </div>

  • trunk/LayoutTests/fast/regions/positioned-objects-block-static-spanning-regions-rtl-expected.html

    r137264 r137479  
    2929        height:100%;
    3030        background-color:#00a000;
    31         color:#00a000;
     31        color:#ffff00;
     32        font: 16px/1.25 monospace;
    3233    }
    3334
    … …  
    7677                Some text.<br>
    7778                Some text.<br>
    78                 Some text.<br>
    7979            </div>
    8080        </div>
    … …  
    9292                Some text.<br>
    9393                Some text.<br>
    94                 Some text.<br>
    9594            </div>
    9695        </div>
    … …  
    9998        <div class="grey-box3 greyColor">
    10099            <div class="green-box">
    101                  Some text.<br>
     100                Some text.<br>
     101                Some text.<br>
     102                Some text.<br>
    102103            </div>
    103104        </div>

  • trunk/LayoutTests/fast/regions/positioned-objects-block-static-spanning-regions-rtl.html

    r97701 r137479  
    22<html style="direction:rtl">
    33<head>
    4  <style>
     4<style>
    55    #content {
    66       -webkit-flow-into: flow1;
    77    }
    8    
     8
    99    #first-box {
    1010        margin:  10%;
    … …  
    1212        background-color:#cccccc;
    1313    }
    14    
     14
    1515    #second-box {
    1616        position:absolute;
    … …  
    1919        width:50%;
    2020        background-color:#00a000;
    21         color:#00a000
     21        color:#ffff00;
     22        font: 16px/1.25 monospace;
    2223    }
    23    
     24
    2425    #region1, #region2, #region3 {
    2526        border: 1px solid black;
    … …  
    3132        height: 150px;
    3233    }
    33    
     34
    3435    #region2 {
    3536        width: 300px;
    3637        height: 180px;
    3738    }
    38    
     39
    3940    #region3 {
    4041        width: 120px;
    … …  
    5253        <div id="second-box">
    5354            Some text.<br>
    54              Some text.<br>
    55               Some text.<br>
    56                Some text.<br>
    57                 Some text.<br> Some text.<br> Some text.<br> Some text.<br> Some text.<br> Some text.<br> Some text.<br> Some text.<br> Some text.<br> Some text.<br> Some text.<br> Some text.<br> Some text.<br> Some text.<br> Some text.<br>      </div>
     55            Some text.<br>
     56            Some text.<br>
     57            Some text.<br>
     58            Some text.<br>
     59            Some text.<br>
     60            Some text.<br>
     61            Some text.<br>
     62            Some text.<br>
     63            Some text.<br>
     64            Some text.<br>
     65            Some text.<br>
     66            Some text.<br>
     67            Some text.<br>
     68            Some text.<br>
     69            Some text.<br>
     70            Some text.<br>
     71            Some text.<br>
     72            Some text.<br>
     73        </div>
    5874    </div>
    5975</div>
    … …  
    6480    <div id="region3"></div>
    6581</div>
     82</body>
     83</html>

  • trunk/LayoutTests/fast/regions/positioned-objects-block-static-spanning-regions.html

    r97701 r137479  
    11<!doctype html>
    2 
    3  <style>
     2<html>
     3<head>
     4<style>
    45    #content {
    56       -webkit-flow-into: flow1;
    67    }
    7    
     8
    89    #first-box {
    9         margin:  10%;
     10        margin: 10%;
    1011        height:350px;
    1112        background-color:#cccccc;
    1213    }
    13    
     14
    1415    #second-box {
    1516        position:absolute;
    … …  
    1819        width:50%;
    1920        background-color:#00a000;
    20         color:#00a000
     21        color:#ffff00;
     22        font: 16px/1.25 monospace;
    2123    }
    22    
     24
    2325    #region1, #region2, #region3 {
    2426        border: 1px solid black;
    … …  
    3032        height: 150px;
    3133    }
    32    
     34
    3335    #region2 {
    3436        width: 300px;
    3537        height: 180px;
    3638    }
    37    
     39
    3840    #region3 {
    3941        width: 120px;
    … …  
    4143    }
    4244</style>
    43 
     45</head>
    4446<body>
    4547<p>The green positioned object should go through all three regions. Its left edge should align with
    4648the left side of the light grey boxes in each region. No red should be visible.</p>
    47 
    4849<div id="content">
    4950    <div id="first-box">
    … …  
    5152        <div id="second-box">
    5253            Some text.<br>
    53              Some text.<br>
    54               Some text.<br>
    55                Some text.<br>
    56                 Some text.<br> Some text.<br> Some text.<br> Some text.<br> Some text.<br> Some text.<br> Some text.<br> Some text.<br> Some text.<br> Some text.<br> Some text.<br> Some text.<br> Some text.<br> Some text.<br> Some text.<br>      </div>
     54            Some text.<br>
     55            Some text.<br>
     56            Some text.<br>
     57            Some text.<br>
     58            Some text.<br>
     59            Some text.<br>
     60            Some text.<br>
     61            Some text.<br>
     62            Some text.<br>
     63            Some text.<br>
     64            Some text.<br>
     65            Some text.<br>
     66            Some text.<br>
     67            Some text.<br>
     68            Some text.<br>
     69            Some text.<br>
     70            Some text.<br>
     71            Some text.<br>
     72        </div>
    5773    </div>
    5874</div>
    … …  
    6379    <div id="region3"></div>
    6480</div>
     81</body>
     82</html>

  • trunk/LayoutTests/platform/chromium/TestExpectations

    r137476 r137479  
    27672767webkit.org/b/98315 css3/compositing/should-have-compositing-layer.html [ Failure ]
    27682768
    2769 # two regions reftests failing on Chromium
    2770 webkit.org/b/74219 fast/regions/positioned-objects-block-static-spanning-regions-rtl.html [ ImageOnlyFailure Pass ]
    2771 webkit.org/b/74219 fast/regions/positioned-objects-block-static-spanning-regions.html [ ImageOnlyFailure Pass ]
    2772 
    27732769webkit.org/b/96267 fast/regions/autoheight-regions-mark.html [ Pass ]
    27742770

  • trunk/LayoutTests/platform/efl-wk2/TestExpectations

    r137303 r137479  
    492492webkit.org/b/103468 fast/regions/positioned-objects-block-static-in-regions.html [ ImageOnlyFailure Pass ]
    493493webkit.org/b/103468 fast/regions/positioned-objects-block-static-in-rtl-regions.html [ ImageOnlyFailure Pass ]
    494 webkit.org/b/103468 fast/regions/positioned-objects-block-static-spanning-regions.html [ ImageOnlyFailure Pass ]
    495494webkit.org/b/103468 fast/regions/positioned-objects-clipped-spanning-regions.html [ ImageOnlyFailure Pass ]
    496495webkit.org/b/103468 fast/regions/positioned-objects-in-regions.html [ ImageOnlyFailure Pass ]

  • trunk/LayoutTests/platform/efl/TestExpectations

    r137465 r137479  
    752752# FAILING TESTS
    753753#////////////////////////////////////////////////////////////////////////////////////////
    754 
    755 # CSS Regions Reftest issues.
    756 webkit.org/b/74219 fast/regions/positioned-objects-block-static-spanning-regions-rtl.html [ ImageOnlyFailure ]
    757754
    758755# CSS Regions issues.

  • trunk/LayoutTests/platform/gtk/TestExpectations

    r137471 r137479  
    12871287webkit.org/b/90007 http/tests/security/mixedContent/insecure-audio-video-in-main-frame.html [ Failure ]
    12881288
    1289 webkit.org/b/74219 fast/regions/positioned-objects-block-static-spanning-regions-rtl.html [ ImageOnlyFailure ]
    1290 
    12911289# This failure appears to be GTK-specific
    12921290webkit.org/b/91319 css2.1/20110323/vertical-align-boxes-001.htm [ ImageOnlyFailure ]

  • trunk/LayoutTests/platform/qt/TestExpectations

    r137461 r137479  
    21352135svg/transforms/transformed-text-fill-gradient.html
    21362136fast/regions/floats-basic-in-variable-width-regions.html
    2137 fast/regions/positioned-objects-block-static-spanning-regions-rtl.html
    21382137fast/regions/region-style-rule-position.html
    21392138
Note: See TracChangeset for help on using the changeset viewer.