Changeset 137490 in webkit

Timestamp:

Dec 12, 2012 11:32:12 AM (11 years ago)

Author:

pilgrim@chromium.org

Message:

[Chromium] Remove all references to sharedWorkerRepository()
​https://bugs.webkit.org/show_bug.cgi?id=104704

Reviewed by James Robinson.

Now that Chromium calls setSharedWorkerRepository upon
initializing WebKit (
​https://chromiumcodereview.appspot.com/10990121/ ) and no longer
tries to override sharedWorkerRepository, it is safe to remove
all references to this function.

• public/platform/WebKitPlatformSupport.h:

(WebKit):
(WebKit::WebKitPlatformSupport::idbFactory):

• src/SharedWorkerRepository.cpp:

(WebKit::sharedWorkerRepository):
(WebCore::SharedWorkerRepository::isAvailable):

Location:

trunk/Source/WebKit/chromium

Files:

• ChangeLog (modified) (1 diff)
• public/platform/WebKitPlatformSupport.h (modified) (2 diffs)
• src/SharedWorkerRepository.cpp (modified) (2 diffs)

trunk/Source/WebKit/chromium/ChangeLog

@@ +1 @@
+2012-12-12  Mark Pilgrim  <pilgrim@chromium.org>
+
+        [Chromium] Remove all references to sharedWorkerRepository()
+        https://bugs.webkit.org/show_bug.cgi?id=104704
+
+        Reviewed by James Robinson.
+
+        Now that Chromium calls setSharedWorkerRepository upon
+        initializing WebKit (
+        https://chromiumcodereview.appspot.com/10990121/ ) and no longer
+        tries to override sharedWorkerRepository, it is safe to remove
+        all references to this function.
+
+        * public/platform/WebKitPlatformSupport.h:
+        (WebKit):
+        (WebKit::WebKitPlatformSupport::idbFactory):
+        * src/SharedWorkerRepository.cpp:
+        (WebKit::sharedWorkerRepository):
+        (WebCore::SharedWorkerRepository::isAvailable):
+
 2012-12-12  Tommy Widenflycht  <tommyw@google.com>
 

trunk/Source/WebKit/chromium/public/platform/WebKitPlatformSupport.h

@@ -37 +37 @@
 
 class WebIDBFactory; // FIXME: Does this belong in platform?
-class WebSharedWorkerRepository; // FIXME: Does this belong in platform?
 
 // FIXME: Eventually all these API will need to move to WebKit::Platform.
@@ -46 +45 @@
     virtual WebIDBFactory* idbFactory() { return 0; }
 
-
-    // Shared Workers ------------------------------------------------------
-
-    virtual WebSharedWorkerRepository* sharedWorkerRepository() { return 0; }
-
 protected:
     ~WebKitPlatformSupport() { }

trunk/Source/WebKit/chromium/src/SharedWorkerRepository.cpp

@@ -70 +70 @@
 static WebSharedWorkerRepository* sharedWorkerRepository()
 {
-    WebSharedWorkerRepository* repository;
-
-    repository = s_sharedWorkerRepository;
-    if (!repository) {
-        repository = webKitPlatformSupport()->sharedWorkerRepository();
-        setSharedWorkerRepository(repository);
-    }
-
-    return repository;
+    // Will only be non-zero if the embedder has set the shared worker repository upon initialization. Nothing in WebKit sets this.
+    return s_sharedWorkerRepository;
 }
 
@@ -219 +212 @@
 bool SharedWorkerRepository::isAvailable()
 {
-    // Allow the WebKitPlatformSupport to determine if SharedWorkers
-    // are available.
     return WebKit::sharedWorkerRepository();
 }