Changeset 137494 in webkit


Ignore:
Timestamp:
Dec 12, 2012 11:43:45 AM (11 years ago)
Author:
robert@webkit.org
Message:

White space between inline blocks should be affected by word-spacing property
​https://bugs.webkit.org/show_bug.cgi?id=69072

Reviewed by Levi Weintraub.

Source/WebCore:

Allow word-spacing to get added to the spaces between inline blocks in placeBoxesInInlineDirection by setting
needsWordSpacing to true each time an inline block is encountered. This ensures that the next space encountered
in a text run will be treated as a space between two words and will get word-spacing added to it if it is present
in the style.

Tests: fast/css/word-spacing-between-blocks.html

fast/css/word-spacing-between-inlines.html

  • rendering/InlineFlowBox.cpp:

(WebCore::InlineFlowBox::placeBoxRangeInInlineDirection):

LayoutTests:

  • fast/css/word-spacing-between-blocks-expected.html: Added.
  • fast/css/word-spacing-between-blocks.html: Added.
  • fast/css/word-spacing-between-inlines-expected.html: Added.
  • fast/css/word-spacing-between-inlines.html: Added.
Location:
trunk
Files:
4 added
3 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r137493 r137494  
     12012-12-12  Robert Hogan  <robert@webkit.org>
     2
     3        White space between inline blocks should be affected by word-spacing property
     4        https://bugs.webkit.org/show_bug.cgi?id=69072
     5
     6        Reviewed by Levi Weintraub.
     7
     8        * fast/css/word-spacing-between-blocks-expected.html: Added.
     9        * fast/css/word-spacing-between-blocks.html: Added.
     10        * fast/css/word-spacing-between-inlines-expected.html: Added.
     11        * fast/css/word-spacing-between-inlines.html: Added.
     12
    1132012-12-12  Adam Klein  <adamk@chromium.org>
    214

  • trunk/Source/WebCore/ChangeLog

    r137492 r137494  
     12012-12-12  Robert Hogan  <robert@webkit.org>
     2
     3        White space between inline blocks should be affected by word-spacing property
     4        https://bugs.webkit.org/show_bug.cgi?id=69072
     5
     6        Reviewed by Levi Weintraub.
     7
     8        Allow word-spacing to get added to the spaces between inline blocks in placeBoxesInInlineDirection by setting
     9        needsWordSpacing to true each time an inline block is encountered. This ensures that the next space encountered
     10        in a text run will be treated as a space between two words and will get word-spacing added to it if it is present
     11        in the style.
     12
     13        Tests: fast/css/word-spacing-between-blocks.html
     14               fast/css/word-spacing-between-inlines.html
     15
     16        * rendering/InlineFlowBox.cpp:
     17        (WebCore::InlineFlowBox::placeBoxRangeInInlineDirection):
     18
    1192012-12-12  Xianzhu Wang  <wangxianzhu@chromium.org>
    220

  • trunk/Source/WebCore/rendering/InlineFlowBox.cpp

    r137359 r137494  
    436436                    maxLogicalRight = max(logicalLeft, maxLogicalRight);
    437437                logicalLeft += logicalRightMargin;
     438                // If we encounter any space after this inline block then ensure it is treated as the space between two words.
     439                needsWordSpacing = true;
    438440            }
    439441        }
Note: See TracChangeset for help on using the changeset viewer.