Changeset 137633 in webkit

Timestamp:

Dec 13, 2012 11:51:49 AM (11 years ago)

Author:

commit-queue@webkit.org

Message:

[GTK] Safeguard against possible NULL-dereference
​https://bugs.webkit.org/show_bug.cgi?id=104931

Patch by Claudio Saavedra <Claudio Saavedra> on 2012-12-13
Reviewed by Chris Fleizach.

This was spotted by Coverity. See bug 104114.

• accessibility/atk/WebKitAccessibleWrapperAtk.cpp:

(webkitAccessibleGetIndexInParent): If parent is NULL
bail out early.

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• accessibility/atk/WebKitAccessibleWrapperAtk.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2012-12-13  Claudio Saavedra  <csaavedra@igalia.com>
+
+        [GTK] Safeguard against possible NULL-dereference
+        https://bugs.webkit.org/show_bug.cgi?id=104931
+
+        Reviewed by Chris Fleizach.
+
+        This was spotted by Coverity. See bug 104114.
+
+        * accessibility/atk/WebKitAccessibleWrapperAtk.cpp:
+        (webkitAccessibleGetIndexInParent): If parent is NULL
+        bail out early.
+
 2012-12-13  David Barton  <dbarton@mathscribe.com>
 

trunk/Source/WebCore/accessibility/atk/WebKitAccessibleWrapperAtk.cpp

@@ -407 +407 @@
     AccessibilityObject* coreObject = core(object);
     AccessibilityObject* parent = coreObject->parentObjectUnignored();
+
+    if (!parent)
+        return -1;
 
     if (!parent && isRootObject(coreObject)) {