Changeset 137870 in webkit


Ignore:
Timestamp:
Dec 16, 2012 8:56:39 PM (11 years ago)
Author:
hayato@chromium.org
Message:

[Shadow DOM] Kill ShadowRoot constructor
​https://bugs.webkit.org/show_bug.cgi?id=102913

Reviewed by Dimitri Glazkov.

Source/WebCore:

Re-landing r137408 which breaks browser tests on chromium. I've
updated the browser tests on chromium so that they do not use
WebKitShadowRoot constructor.

No new tests. Updating existing layout tests.

  • dom/ShadowRoot.idl:
  • page/DOMWindow.idl:

LayoutTests:

  • fast/js/global-constructors-expected.txt:
  • platform/efl/fast/js/global-constructors-expected.txt:
  • platform/gtk/fast/js/global-constructors-expected.txt:
Location:
trunk
Files:
7 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r137861 r137870  
     12012-12-16  Hayato Ito  <hayato@chromium.org>
     2
     3        [Shadow DOM] Kill ShadowRoot constructor
     4        https://bugs.webkit.org/show_bug.cgi?id=102913
     5
     6        Reviewed by Dimitri Glazkov.
     7
     8        * fast/js/global-constructors-expected.txt:
     9        * platform/efl/fast/js/global-constructors-expected.txt:
     10        * platform/gtk/fast/js/global-constructors-expected.txt:
     11
    1122012-12-16  Kentaro Hara  <haraken@chromium.org>
    213

  • trunk/LayoutTests/fast/js/global-constructors-expected.txt

    r137425 r137870  
    330330FAIL WebKitMutationObserver.toString() should be [object WebKitMutationObserverConstructor]. Was [object MutationObserverConstructor].
    331331PASS WebKitPoint.toString() is '[object WebKitPointConstructor]'
    332 FAIL WebKitShadowRoot.toString() should be [object WebKitShadowRootConstructor]. Was [object ShadowRootConstructor].
    333332PASS WebKitTransitionEvent.toString() is '[object WebKitTransitionEventConstructor]'
    334333PASS WebSocket.toString() is '[object WebSocketConstructor]'

  • trunk/LayoutTests/platform/efl/fast/js/global-constructors-expected.txt

    r137425 r137870  
    336336FAIL WebKitMutationObserver.toString() should be [object WebKitMutationObserverConstructor]. Was [object MutationObserverConstructor].
    337337PASS WebKitPoint.toString() is '[object WebKitPointConstructor]'
    338 FAIL WebKitShadowRoot.toString() should be [object WebKitShadowRootConstructor]. Was [object ShadowRootConstructor].
    339338PASS WebKitTransitionEvent.toString() is '[object WebKitTransitionEventConstructor]'
    340339PASS WebSocket.toString() is '[object WebSocketConstructor]'

  • trunk/LayoutTests/platform/gtk/fast/js/global-constructors-expected.txt

    r137440 r137870  
    331331FAIL WebKitMutationObserver.toString() should be [object WebKitMutationObserverConstructor]. Was [object MutationObserverConstructor].
    332332PASS WebKitPoint.toString() is '[object WebKitPointConstructor]'
    333 FAIL WebKitShadowRoot.toString() should be [object WebKitShadowRootConstructor]. Was [object ShadowRootConstructor].
    334333PASS WebKitTransitionEvent.toString() is '[object WebKitTransitionEventConstructor]'
    335334PASS WebSocket.toString() is '[object WebSocketConstructor]'

  • trunk/Source/WebCore/ChangeLog

    r137868 r137870  
     12012-12-16  Hayato Ito  <hayato@chromium.org>
     2
     3        [Shadow DOM] Kill ShadowRoot constructor
     4        https://bugs.webkit.org/show_bug.cgi?id=102913
     5
     6        Reviewed by Dimitri Glazkov.
     7
     8        Re-landing r137408 which breaks browser tests on chromium. I've
     9        updated the browser tests on chromium so that they do not use
     10        WebKitShadowRoot constructor.
     11
     12        No new tests. Updating existing layout tests.
     13
     14        * dom/ShadowRoot.idl:
     15        * page/DOMWindow.idl:
     16
    1172012-12-16  Jon Lee  <jonlee@apple.com>
    218

  • trunk/Source/WebCore/dom/ShadowRoot.idl

    r137425 r137870  
    2727[
    2828    Conditional=SHADOW_DOM,
    29     Constructor(in Element host),
    30     ConstructorRaisesException,
    3129    JSGenerateToJSObject
    3230] interface ShadowRoot : DocumentFragment {

  • trunk/Source/WebCore/page/DOMWindow.idl

    r137835 r137870  
    402402    attribute EntityReferenceConstructor EntityReference;
    403403    attribute ProcessingInstructionConstructor ProcessingInstruction;
    404     [Conditional=SHADOW_DOM, V8EnabledAtRuntime=shadowDOM] attribute ShadowRootConstructor WebKitShadowRoot;
    405404    [Conditional=SHADOW_DOM, V8EnabledAtRuntime=shadowDOM] attribute HTMLContentElementConstructor HTMLContentElement;
    406405    [Conditional=SHADOW_DOM, V8EnabledAtRuntime=shadowDOM] attribute HTMLShadowElementConstructor HTMLShadowElement;
Note: See TracChangeset for help on using the changeset viewer.