Changeset 137909 in webkit

Timestamp:

Dec 17, 2012 8:20:28 AM (11 years ago)

Author:

akling@apple.com

Message:

Attribute: Remove unused constructor and isNull().
<​http://webkit.org/b/105179>

Reviewed by Antti Koivisto.

Removed the Attribute constructor that takes a localName rather than a full QualifiedName as that was never used.
Also removed Attribute::isNull(), since that was only called in one place where isNull() will never be true.

• dom/Attribute.h:
• html/HTMLIFrameElement.cpp:

(WebCore::HTMLIFrameElement::collectStyleForPresentationAttribute):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• dom/Attribute.h (modified) (2 diffs)
• html/HTMLIFrameElement.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2012-12-17  Andreas Kling  <akling@apple.com>
+
+        Attribute: Remove unused constructor and isNull().
+        <http://webkit.org/b/105179>
+
+        Reviewed by Antti Koivisto.
+
+        Removed the Attribute constructor that takes a localName rather than a full QualifiedName as that was never used.
+        Also removed Attribute::isNull(), since that was only called in one place where isNull() will never be true.
+
+        * dom/Attribute.h:
+        * html/HTMLIFrameElement.cpp:
+        (WebCore::HTMLIFrameElement::collectStyleForPresentationAttribute):
+
 2012-12-17  Anthony Scian  <ascian@rim.com>
 

trunk/Source/WebCore/dom/Attribute.h

@@ -42 +42 @@
     }
 
-    Attribute(const AtomicString& name, const AtomicString& value)
-        : m_name(nullAtom, name, nullAtom)
-        , m_value(value)
-    {
-    }
-
     // NOTE: The references returned by these functions are only valid for as long
     // as the Attribute stays in place. For example, calling a function that mutates
@@ -58 +52 @@
     const QualifiedName& name() const { return m_name; }
 
-    bool isNull() const { return m_value.isNull(); }
     bool isEmpty() const { return m_value.isEmpty(); }
 

trunk/Source/WebCore/html/HTMLIFrameElement.cpp

@@ -70 +70 @@
         // Frame border doesn't really match the HTML4 spec definition for iframes. It simply adds
         // a presentational hint that the border should be off if set to zero.
-        if (!attribute.isNull() && !attribute.value().toInt()) {
+        if (!attribute.value().toInt()) {
             // Add a rule that nulls out our border width.
             addPropertyToPresentationAttributeStyle(style, CSSPropertyBorderWidth, 0, CSSPrimitiveValue::CSS_PX);