Changeset 138165 in webkit


Ignore:
Timestamp:
Dec 19, 2012 8:09:46 AM (11 years ago)
Author:
hayato@chromium.org
Message:

Expose WebKitShadowRoot constructor to DOMWindow.
​https://bugs.webkit.org/show_bug.cgi?id=105385

Reviewed by Dimitri Glazkov.

Source/WebCore:

This is a follow-up patch for r137870. WebKitShadowRoot
constructor should be in DOMWindow, just like all of the other
not-callable-constructors like HTMLDivElement, etc. We need it
for instanceof tests and so on.

Test: fast/dom/shadow/shadow-root-js-api.html

fast/js/global-constructors-expected.html

  • page/DOMWindow.idl:

LayoutTests:

  • fast/dom/shadow/shadow-root-js-api-expected.txt:
  • fast/dom/shadow/shadow-root-js-api.html:
  • fast/js/global-constructors-expected.txt:
  • platform/efl/fast/js/global-constructors-expected.txt:
  • platform/gtk/fast/js/global-constructors-expected.txt:
Location:
trunk
Files:
8 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r138162 r138165  
     12012-12-19  Hayato Ito  <hayato@chromium.org>
     2
     3        Expose WebKitShadowRoot constructor to DOMWindow.
     4        https://bugs.webkit.org/show_bug.cgi?id=105385
     5
     6        Reviewed by Dimitri Glazkov.
     7
     8        * fast/dom/shadow/shadow-root-js-api-expected.txt:
     9        * fast/dom/shadow/shadow-root-js-api.html:
     10        * fast/js/global-constructors-expected.txt:
     11        * platform/efl/fast/js/global-constructors-expected.txt:
     12        * platform/gtk/fast/js/global-constructors-expected.txt:
     13
    1142012-12-19  Tim Volodine  <timvolodine@chromium.org>
    215

  • trunk/LayoutTests/fast/dom/shadow/shadow-root-js-api-expected.txt

    r137408 r138165  
    44
    55
     6PASS window.ShadowRoot is undefined.
     7PASS window.WebKitShadowRoot is defined.
     8PASS new window.WebKitShadowRoot(document.createElement('div')) threw exception TypeError: Illegal constructor.
     9PASS shadowRoot instanceof window.WebKitShadowRoot is true
    610PASS shadowRoot.getElementById('div1') is div1
    711PASS shadowRoot.getElementById('foo') is null

  • trunk/LayoutTests/fast/dom/shadow/shadow-root-js-api.html

    r137408 r138165  
    1515if (window.testRunner)
    1616    testRunner.dumpAsText();
     17
     18shouldBeUndefined("window.ShadowRoot");
     19shouldBeDefined("window.WebKitShadowRoot");
     20shouldThrow("new window.WebKitShadowRoot(document.createElement('div'))");
     21
    1722var shadowHost = document.createElement('div');
    1823document.body.appendChild(shadowHost);
    1924var shadowRoot = shadowHost.webkitCreateShadowRoot();
     25
     26shouldBeTrue("shadowRoot instanceof window.WebKitShadowRoot");
    2027
    2128var div1 = document.createElement("div");

  • trunk/LayoutTests/fast/js/global-constructors-expected.txt

    r137870 r138165  
    330330FAIL WebKitMutationObserver.toString() should be [object WebKitMutationObserverConstructor]. Was [object MutationObserverConstructor].
    331331PASS WebKitPoint.toString() is '[object WebKitPointConstructor]'
     332FAIL WebKitShadowRoot.toString() should be [object WebKitShadowRootConstructor]. Was [object ShadowRootConstructor].
    332333PASS WebKitTransitionEvent.toString() is '[object WebKitTransitionEventConstructor]'
    333334PASS WebSocket.toString() is '[object WebSocketConstructor]'

  • trunk/LayoutTests/platform/efl/fast/js/global-constructors-expected.txt

    r137870 r138165  
    336336FAIL WebKitMutationObserver.toString() should be [object WebKitMutationObserverConstructor]. Was [object MutationObserverConstructor].
    337337PASS WebKitPoint.toString() is '[object WebKitPointConstructor]'
     338FAIL WebKitShadowRoot.toString() should be [object WebKitShadowRootConstructor]. Was [object ShadowRootConstructor].
    338339PASS WebKitTransitionEvent.toString() is '[object WebKitTransitionEventConstructor]'
    339340PASS WebSocket.toString() is '[object WebSocketConstructor]'

  • trunk/LayoutTests/platform/gtk/fast/js/global-constructors-expected.txt

    r137870 r138165  
    331331FAIL WebKitMutationObserver.toString() should be [object WebKitMutationObserverConstructor]. Was [object MutationObserverConstructor].
    332332PASS WebKitPoint.toString() is '[object WebKitPointConstructor]'
     333FAIL WebKitShadowRoot.toString() should be [object WebKitShadowRootConstructor]. Was [object ShadowRootConstructor].
    333334PASS WebKitTransitionEvent.toString() is '[object WebKitTransitionEventConstructor]'
    334335PASS WebSocket.toString() is '[object WebSocketConstructor]'

  • trunk/Source/WebCore/ChangeLog

    r138164 r138165  
     12012-12-19  Hayato Ito  <hayato@chromium.org>
     2
     3        Expose WebKitShadowRoot constructor to DOMWindow.
     4        https://bugs.webkit.org/show_bug.cgi?id=105385
     5
     6        Reviewed by Dimitri Glazkov.
     7
     8        This is a follow-up patch for r137870.  WebKitShadowRoot
     9        constructor should be in DOMWindow, just like all of the other
     10        not-callable-constructors like HTMLDivElement, etc.  We need it
     11        for instanceof tests and so on.
     12
     13        Test: fast/dom/shadow/shadow-root-js-api.html
     14              fast/js/global-constructors-expected.html
     15
     16        * page/DOMWindow.idl:
     17
    1182012-12-19  Andrey Lushnikov  <lushnikov@chromium.com>
    219

  • trunk/Source/WebCore/page/DOMWindow.idl

    r137870 r138165  
    402402    attribute EntityReferenceConstructor EntityReference;
    403403    attribute ProcessingInstructionConstructor ProcessingInstruction;
     404    [Conditional=SHADOW_DOM, V8EnabledAtRuntime=shadowDOM] attribute ShadowRootConstructor WebKitShadowRoot;
    404405    [Conditional=SHADOW_DOM, V8EnabledAtRuntime=shadowDOM] attribute HTMLContentElementConstructor HTMLContentElement;
    405406    [Conditional=SHADOW_DOM, V8EnabledAtRuntime=shadowDOM] attribute HTMLShadowElementConstructor HTMLShadowElement;
Note: See TracChangeset for help on using the changeset viewer.