Changeset 138348 in webkit

Timestamp:

Dec 20, 2012 10:07:18 PM (11 years ago)

Author:

toyoshim@chromium.org

Message:

Disable Nagle algorithm on WebSocket implementation for CF.
​https://bugs.webkit.org/show_bug.cgi?id=102079

Reviewed by Alexey Proskuryakov.

Set TCP_NODELAY on CFWriteStream for SocketStreamHandle to improve
communication latency. Combination of Nagle and delayed-ACK could
affect performance in some environment, e.g., over Wifi network.

• platform/network/cf/SocketStreamHandleCFNet.cpp:

(WebCore::SocketStreamHandle::createStreams):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• platform/network/cf/SocketStreamHandleCFNet.cpp (modified) (2 diffs)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2012-12-20  Takashi Toyoshima  <toyoshim@chromium.org>
+
+        Disable Nagle algorithm on WebSocket implementation for CF.
+        https://bugs.webkit.org/show_bug.cgi?id=102079
+
+        Reviewed by Alexey Proskuryakov.
+
+        Set TCP_NODELAY on CFWriteStream for SocketStreamHandle to improve
+        communication latency. Combination of Nagle and delayed-ACK could
+        affect performance in some environment, e.g., over Wifi network.
+
+        * platform/network/cf/SocketStreamHandleCFNet.cpp:
+        (WebCore::SocketStreamHandle::createStreams):
+
 2012-12-20  Huang Dongsung  <luxtella@company100.net>
 

trunk/Source/WebCore/platform/network/cf/SocketStreamHandleCFNet.cpp

@@ -54 +54 @@
 #endif
 
+#if !PLATFORM(WIN)
+extern "C" const CFStringRef _kCFStreamSocketSetNoDelay;
+#endif
 
 namespace WebCore {
@@ -276 +279 @@
     CFWriteStreamRef writeStream = 0;
     CFStreamCreatePairWithSocketToHost(0, host.get(), port(), &readStream, &writeStream);
+#if !PLATFORM(WIN)
+    // <rdar://problem/12855587> _kCFStreamSocketSetNoDelay is not exported on Windows
+    CFWriteStreamSetProperty(writeStream, _kCFStreamSocketSetNoDelay, kCFBooleanTrue);
+#endif
 
     m_readStream.adoptCF(readStream);