Changeset 138446 in webkit


Ignore:
Timestamp:
Dec 24, 2012 10:28:16 AM (11 years ago)
Author:
mihnea@adobe.com
Message:

[CSS Regions] Convert some fast/regions pixel tests to reftests
​https://bugs.webkit.org/show_bug.cgi?id=80191

Reviewed by Tony Chang.

Convert fast/regions/bottom-overflow-out-of-first-region.html to a ref test.
Used a monospace font, removed text-align and margins for text flowing into regions so that
the text fits nicely in the two regions of the test.

  • fast/regions/bottom-overflow-out-of-first-region-expected.html: Added.
  • fast/regions/bottom-overflow-out-of-first-region-expected.png: Removed.
  • fast/regions/bottom-overflow-out-of-first-region.html:
  • platform/chromium-linux/fast/regions/bottom-overflow-out-of-first-region-expected.png: Removed.
  • platform/chromium-mac-lion/fast/regions/bottom-overflow-out-of-first-region-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fast/regions/bottom-overflow-out-of-first-region-expected.png: Removed.
  • platform/chromium-mac/fast/regions/bottom-overflow-out-of-first-region-expected.png: Removed.
  • platform/chromium-mac/fast/regions/bottom-overflow-out-of-first-region-expected.txt: Removed.
  • platform/chromium-win/fast/regions/bottom-overflow-out-of-first-region-expected.png: Removed.
  • platform/chromium-win/fast/regions/bottom-overflow-out-of-first-region-expected.txt: Removed.
  • platform/efl/fast/regions/bottom-overflow-out-of-first-region-expected.txt: Removed.
  • platform/gtk/fast/regions/bottom-overflow-out-of-first-region-expected.txt: Removed.
  • platform/mac/fast/regions/bottom-overflow-out-of-first-region-expected.png: Removed.
  • platform/mac/fast/regions/bottom-overflow-out-of-first-region-expected.txt: Removed.
  • platform/qt/fast/regions/bottom-overflow-out-of-first-region-expected.png: Removed.
  • platform/qt/fast/regions/bottom-overflow-out-of-first-region-expected.txt: Removed.
Location:
trunk/LayoutTests
Files:
1 added
14 deleted
2 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r138438 r138446  
     12012-12-24  Mihnea Ovidenie  <mihnea@adobe.com>
     2
     3        [CSS Regions] Convert some fast/regions pixel tests to reftests
     4        https://bugs.webkit.org/show_bug.cgi?id=80191
     5
     6        Reviewed by Tony Chang.
     7
     8        Convert fast/regions/bottom-overflow-out-of-first-region.html to a ref test.
     9        Used a monospace font, removed text-align and margins for text flowing into regions so that
     10        the text fits nicely in the two regions of the test.
     11
     12        * fast/regions/bottom-overflow-out-of-first-region-expected.html: Added.
     13        * fast/regions/bottom-overflow-out-of-first-region-expected.png: Removed.
     14        * fast/regions/bottom-overflow-out-of-first-region.html:
     15        * platform/chromium-linux/fast/regions/bottom-overflow-out-of-first-region-expected.png: Removed.
     16        * platform/chromium-mac-lion/fast/regions/bottom-overflow-out-of-first-region-expected.png: Removed.
     17        * platform/chromium-mac-snowleopard/fast/regions/bottom-overflow-out-of-first-region-expected.png: Removed.
     18        * platform/chromium-mac/fast/regions/bottom-overflow-out-of-first-region-expected.png: Removed.
     19        * platform/chromium-mac/fast/regions/bottom-overflow-out-of-first-region-expected.txt: Removed.
     20        * platform/chromium-win/fast/regions/bottom-overflow-out-of-first-region-expected.png: Removed.
     21        * platform/chromium-win/fast/regions/bottom-overflow-out-of-first-region-expected.txt: Removed.
     22        * platform/efl/fast/regions/bottom-overflow-out-of-first-region-expected.txt: Removed.
     23        * platform/gtk/fast/regions/bottom-overflow-out-of-first-region-expected.txt: Removed.
     24        * platform/mac/fast/regions/bottom-overflow-out-of-first-region-expected.png: Removed.
     25        * platform/mac/fast/regions/bottom-overflow-out-of-first-region-expected.txt: Removed.
     26        * platform/qt/fast/regions/bottom-overflow-out-of-first-region-expected.png: Removed.
     27        * platform/qt/fast/regions/bottom-overflow-out-of-first-region-expected.txt: Removed.
     28
    1292012-12-24  Andrey Lushnikov  <lushnikov@chromium.com>
    230

  • trunk/LayoutTests/fast/regions/bottom-overflow-out-of-first-region.html

    r128155 r138446  
    11<!doctype html>
     2<html>
     3    <head>
     4        <style>
     5            body { font: 16px/1.25 monospace; }
    26
    3  <style>
    4     #content {
    5         -webkit-flow-into: flow1;
    6         text-align: justify;
    7         padding: 5px;
    8     }
    9    
    10     #first-box {
    11         border: 1px solid blue;
    12         height:188px;
    13     }
    14    
    15     #second-box {
    16         margin:auto;
    17         border: 1px solid green;
    18         width:75%
    19     }
    20    
    21     #region1, #region2, #region3 {
    22         border: 1px solid black;
    23         -webkit-flow-from: flow1;
    24     }
     7            #content {
     8                -webkit-flow-into: flow1;
     9                padding: 5px;
     10            }
    2511
    26     #region1 {
    27         width: 400px;
    28         height: 200px;
    29     }
    30    
    31     #region2 {
    32         width: 300px;
    33         height: 100px;
    34     }
     12            #first-box {
     13                border: 1px solid blue;
     14                height:200px;
     15            }
    3516
    36     #region3 {
    37         width: 0px;
    38         height: 0px;
    39     }
    40 </style>
     17            #second-box {
     18                margin:auto;
     19                border: 1px solid green;
     20                width:75%;
     21            }
    4122
    42 <body>
     23            #region1, #region2 {
     24                border: 1px solid black;
     25                -webkit-flow-from: flow1;
     26            }
    4327
    44 <p>In the test case below, the green block's width should not vary and should use the first region to determine its width.
    45 It is overflowing downwards out of the blue block, and so the portion that overflows should continue to use the blue block's
    46 containing block width. The blue block does not exist in region two, so using some hypothetical made-up width is incorrect.
    47 The overflow should be spilling out of the top of region one and be painted in region two.
     28            #region1 {
     29                width: 412px;
     30                height: 210px;
     31            }
    4832
    49 <div id="content">
    50     <div id="first-box">
    51         <div id="second-box">
    52             <p>These lines should all fit to the width of the block in the first region and spill out of the bottom of the first
    53             region.</P>
    54              <p>These lines should all fit to the width of the block in the first region and spill out of the bottom of the first
    55             region.</P>
    56              <p>These lines should all fit to the width of the block in the first region and spill out of the bottom of the first
    57             region.</P>
     33            #region2 {
     34                width: 300px;
     35                height: 150px;
     36            }
     37            #p1, #p2, #p3 {
     38                margin: 0;
     39            }
     40        </style>
     41    </head>
     42    <body>
     43        <p>In the test case below, the green block's width should not vary and should use the first region to determine its width. It is overflowing downwards out of the blue block, and so the portion that overflows should continue to use the blue block's containing block width. The blue block does not exist in region two, so using some hypothetical made-up width is incorrect. The overflow should be spilling out of the top of region one and be painted in region two.</p>
     44        <div id="content">
     45            <div id="first-box">
     46                <div id="second-box">
     47                    <p id="p1">These lines should all fit to the width of the block in the first region and spill out of the bottom of the first region.</p>
     48                    <p id="p2">These lines should all fit to the width of the block in the first region and spill out of the bottom of the first region.</p>
     49                    <p id="p3">These lines should all fit to the width of the block in the first region and spill out of the bottom of the first region.</p>
     50                </div>
     51            </div>
    5852        </div>
    59     </div>
    60 </div>
    6153
    62 <div id="container">
    63     <div id="region1"></div>
    64     <div id="region2"></div>
    65     <div id="region3"></div>
    66 </div>
     54        <div id="container">
     55            <div id="region1"></div>
     56            <div id="region2"></div>
     57        </div>
     58    </body>
     59</html>
Note: See TracChangeset for help on using the changeset viewer.