Changeset 138568 in webkit

Timestamp:

Dec 29, 2012 11:10:56 AM (11 years ago)

Author:

commit-queue@webkit.org

Message:

[BlackBerry] Cookies with an IP domain are not being loaded properly into memory
​https://bugs.webkit.org/show_bug.cgi?id=105859

PR 271597

Patch by Otto Derek Cheung <​otcheung@rim.com> on 2012-12-29
Reviewed by George Staikos.

The isIP flag isn't persistented in the database. We need to check it
again when we load it into memory.

• platform/blackberry/CookieManager.cpp:

(WebCore::CookieManager::getBackingStoreCookies):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• platform/blackberry/CookieManager.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2012-12-29  Otto Derek Cheung  <otcheung@rim.com>
+
+        [BlackBerry] Cookies with an IP domain are not being loaded properly into memory
+        https://bugs.webkit.org/show_bug.cgi?id=105859
+
+        PR 271597
+
+        Reviewed by George Staikos.
+
+        The isIP flag isn't persistented in the database. We need to check it
+        again when we load it into memory.
+
+        * platform/blackberry/CookieManager.cpp:
+        (WebCore::CookieManager::getBackingStoreCookies):
+
 2012-12-29  Kondapally Kalyan  <kalyan.kondapally@intel.com>
 

trunk/Source/WebCore/platform/blackberry/CookieManager.cpp

@@ -536 +536 @@
     for (size_t i = 0; i < cookies.size(); ++i) {
         ParsedCookie* newCookie = cookies[i];
+
+        // The IP flag is not persisted in the database.
+        if (BlackBerry::Platform::isIPAddress(newCookie->domain().utf8().data()))
+            newCookie->setDomain(newCookie->domain(), true);
+
         checkAndTreatCookie(newCookie, BackingStoreCookieEntry);
     }