Changeset 138608 in webkit


Ignore:
Timestamp:
Jan 1, 2013 10:53:25 PM (11 years ago)
Author:
Christophe Dumez
Message:

[WK2] plugins/clicking-missing-plugin-fires-delegate.html is failing
​https://bugs.webkit.org/show_bug.cgi?id=105897

Reviewed by Alexey Proskuryakov.

Tools:

Dump in WebKitTestRunner the message that is expected by layout tests
when the missing plugin button is clicked.

  • WebKitTestRunner/TestController.cpp:

(WTR::TestController::createWebViewWithOptions):
(WTR::TestController::unavailablePluginButtonClicked):
(WTR):

  • WebKitTestRunner/TestController.h:

(TestController):

LayoutTests:

Unskip plugins/clicking-missing-plugin-fires-delegate.html for
WK2 now that WebKitTestRunner is dumping the expected text when
the missing plugin button is clicked.

  • platform/efl-wk2/TestExpectations:
  • platform/mac-wk2/TestExpectations:
Location:
trunk
Files:
6 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r138602 r138608  
     12013-01-01  Christophe Dumez  <christophe.dumez@intel.com>
     2
     3        [WK2] plugins/clicking-missing-plugin-fires-delegate.html is failing
     4        https://bugs.webkit.org/show_bug.cgi?id=105897
     5
     6        Reviewed by Alexey Proskuryakov.
     7
     8        Unskip plugins/clicking-missing-plugin-fires-delegate.html for
     9        WK2 now that WebKitTestRunner is dumping the expected text when
     10        the missing plugin button is clicked.
     11
     12        * platform/efl-wk2/TestExpectations:
     13        * platform/mac-wk2/TestExpectations:
     14
    1152013-01-01  Kangil Han  <kangil.han@samsung.com>
    216

  • trunk/LayoutTests/platform/efl-wk2/TestExpectations

    r138577 r138608  
    328328
    329329# Mouse event problem with plugin test.
    330 webkit.org/b/98745 plugins/clicking-missing-plugin-fires-delegate.html [ Failure ]
    331330webkit.org/b/98745 plugins/keyboard-events.html [ Failure ]
    332331webkit.org/b/98745 plugins/mouse-events-fixedpos.html [ Failure ]

  • trunk/LayoutTests/platform/mac-wk2/TestExpectations

    r138405 r138608  
    158158platform/mac/editing/pasteboard/drag-selections-to-contenteditable.html
    159159platform/mac/fast/forms/listbox-scrollbar-hit-test.html
    160 plugins/clicking-missing-plugin-fires-delegate.html
    161160scrollbars/scrollbar-iframe-click-does-not-blur-content.html
    162161scrollbars/scrollevent-iframe-no-scrolling-wheel.html

  • trunk/Tools/ChangeLog

    r138605 r138608  
     12013-01-01  Christophe Dumez  <christophe.dumez@intel.com>
     2
     3        [WK2] plugins/clicking-missing-plugin-fires-delegate.html is failing
     4        https://bugs.webkit.org/show_bug.cgi?id=105897
     5
     6        Reviewed by Alexey Proskuryakov.
     7
     8        Dump in WebKitTestRunner the message that is expected by layout tests
     9        when the missing plugin button is clicked.
     10
     11        * WebKitTestRunner/TestController.cpp:
     12        (WTR::TestController::createWebViewWithOptions):
     13        (WTR::TestController::unavailablePluginButtonClicked):
     14        (WTR):
     15        * WebKitTestRunner/TestController.h:
     16        (TestController):
     17
    1182013-01-01  KwangYong Choi  <ky0.choi@samsung.com>
    219

  • trunk/Tools/WebKitTestRunner/TestController.cpp

    r136848 r138608  
    413413        0, // mouseDidMoveOverElement
    414414        decidePolicyForNotificationPermissionRequest, // decidePolicyForNotificationPermissionRequest
    415         0, // unavailablePluginButtonClicked
     415        unavailablePluginButtonClicked,
    416416        0, // showColorPicker
    417417        0, // hideColorPicker
    … …  
    11101110}
    11111111
     1112void TestController::unavailablePluginButtonClicked(WKPageRef, WKPluginUnavailabilityReason, WKStringRef, WKStringRef, WKStringRef, const void*)
     1113{
     1114    printf("MISSING PLUGIN BUTTON PRESSED\n");
     1115}
     1116
    11121117void TestController::decidePolicyForNavigationAction(WKPageRef, WKFrameRef, WKFrameNavigationType, WKEventModifiers, WKEventMouseButton, WKURLRequestRef, WKFramePolicyListenerRef listener, WKTypeRef, const void* clientInfo)
    11131118{

  • trunk/Tools/WebKitTestRunner/TestController.h

    r135496 r138608  
    121121    void decidePolicyForNotificationPermissionRequest(WKPageRef, WKSecurityOriginRef, WKNotificationPermissionRequestRef);
    122122
     123    static void unavailablePluginButtonClicked(WKPageRef, WKPluginUnavailabilityReason, WKStringRef, WKStringRef, WKStringRef, const void*);
     124
    123125    // WKPagePolicyClient
    124126    static void decidePolicyForNavigationAction(WKPageRef, WKFrameRef, WKFrameNavigationType, WKEventModifiers, WKEventMouseButton, WKURLRequestRef, WKFramePolicyListenerRef, WKTypeRef, const void*);
Note: See TracChangeset for help on using the changeset viewer.