Changeset 138720 in webkit

Timestamp:

Jan 3, 2013 10:48:41 AM (11 years ago)

Author:

tsepez@chromium.org

Message:

PingLoader.h missing virtual and OVERRIDE keywords on its inherited methods.
​https://bugs.webkit.org/show_bug.cgi?id=105975

Reviewed by Nate Chapin.

Change adds compile-time checks only, so no new tests.

• loader/PingLoader.h:

(PingLoader):
(WebCore::PingLoader::timeout):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• loader/PingLoader.h (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2013-01-03  Tom Sepez  <tsepez@chromium.org>
+
+        PingLoader.h missing virtual and OVERRIDE keywords on its inherited methods.
+        https://bugs.webkit.org/show_bug.cgi?id=105975
+
+        Reviewed by Nate Chapin.
+
+        Change adds compile-time checks only, so no new tests.
+
+        * loader/PingLoader.h:
+        (PingLoader):
+        (WebCore::PingLoader::timeout):
+
 2013-01-02  Levi Weintraub  <leviw@chromium.org>
 

trunk/Source/WebCore/loader/PingLoader.h

@@ -59 +59 @@
     static void sendViolationReport(Frame*, const KURL& reportURL, PassRefPtr<FormData> report);
 
-    ~PingLoader();
+    virtual ~PingLoader();
 
 private:
     PingLoader(Frame*, ResourceRequest&);
 
-    void didReceiveResponse(ResourceHandle*, const ResourceResponse&) { delete this; }
-    void didReceiveData(ResourceHandle*, const char*, int, int) { delete this; }
-    void didFinishLoading(ResourceHandle*, double) { delete this; }
-    void didFail(ResourceHandle*, const ResourceError&) { delete this; }
+    virtual void didReceiveResponse(ResourceHandle*, const ResourceResponse&) OVERRIDE { delete this; }
+    virtual void didReceiveData(ResourceHandle*, const char*, int, int) OVERRIDE { delete this; }
+    virtual void didFinishLoading(ResourceHandle*, double) OVERRIDE { delete this; }
+    virtual void didFail(ResourceHandle*, const ResourceError&) OVERRIDE { delete this; }
+    virtual bool shouldUseCredentialStorage(ResourceHandle*)  OVERRIDE { return m_shouldUseCredentialStorage; }
     void timeout(Timer<PingLoader>*) { delete this; }
-    bool shouldUseCredentialStorage(ResourceHandle*) { return m_shouldUseCredentialStorage; }
 
     RefPtr<ResourceHandle> m_handle;