Changeset 138721 in webkit


Ignore:
Timestamp:
Jan 3, 2013 11:05:44 AM (11 years ago)
Author:
alexis@webkit.org
Message:

Add tests to cover what transition-timing-function accepts for cubic-bezier values.
​https://bugs.webkit.org/show_bug.cgi?id=105426

Reviewed by Simon Fraser.

​http://www.w3.org/TR/css3-transitions/#transition-timing-function-property
has not yet been updated following the discussions
​http://lists.w3.org/Archives/Public/www-style/2010Apr/0489.html and
​http://lists.w3.org/Archives/Public/www-style/2010Jun/0254.html where
the range restriction of Y values for cubic-bezier type has been
removed. This patch add tests to cover that behavior to avoid breakage
in the future and test also various other different cubic-bezier use
cases.

  • transitions/transitions-parsing-expected.txt:
  • transitions/transitions-parsing.html:
Location:
trunk/LayoutTests
Files:
3 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r138718 r138721  
     12013-01-03  Alexis Menard  <alexis@webkit.org>
     2
     3        Add tests to cover what transition-timing-function accepts for cubic-bezier values.
     4        https://bugs.webkit.org/show_bug.cgi?id=105426
     5
     6        Reviewed by Simon Fraser.
     7
     8        http://www.w3.org/TR/css3-transitions/#transition-timing-function-property
     9        has not yet been updated following the discussions
     10        http://lists.w3.org/Archives/Public/www-style/2010Apr/0489.html and
     11        http://lists.w3.org/Archives/Public/www-style/2010Jun/0254.html where
     12        the range restriction of Y values for cubic-bezier type has been
     13        removed. This patch add tests to cover that behavior to avoid breakage
     14        in the future and test also various other different cubic-bezier use
     15        cases.
     16
     17        * transitions/transitions-parsing-expected.txt:
     18        * transitions/transitions-parsing.html:
     19
    1202013-01-03  Ryosuke Niwa  <rniwa@webkit.org>
    221

  • trunk/LayoutTests/transitions/transitions-parsing-expected.txt

    r138184 r138721  
    119119PASS style.webkitTransitionTimingFunction is 'cubic-bezier(0.1, 0, 0.23, 0.4)'
    120120PASS computedStyle.webkitTransitionTimingFunction is 'cubic-bezier(0.1, 0, 0.23, 0.4)'
     121PASS style.transitionTimingFunction is 'cubic-bezier(0.1, 0, 0.23, 3)'
     122PASS computedStyle.transitionTimingFunction is 'cubic-bezier(0.1, 0, 0.23, 3)'
     123PASS style.webkitTransitionTimingFunction is 'cubic-bezier(0.1, 0, 0.23, 3)'
     124PASS computedStyle.webkitTransitionTimingFunction is 'cubic-bezier(0.1, 0, 0.23, 3)'
     125PASS style.transitionTimingFunction is 'cubic-bezier(0.1, 5, 0.23, 3)'
     126PASS computedStyle.transitionTimingFunction is 'cubic-bezier(0.1, 5, 0.23, 3)'
     127PASS style.webkitTransitionTimingFunction is 'cubic-bezier(0.1, 5, 0.23, 3)'
     128PASS computedStyle.webkitTransitionTimingFunction is 'cubic-bezier(0.1, 5, 0.23, 3)'
     129PASS style.transitionTimingFunction is 'cubic-bezier(0.1, 5, 0.23, 0)'
     130PASS computedStyle.transitionTimingFunction is 'cubic-bezier(0.1, 5, 0.23, 0)'
     131PASS style.webkitTransitionTimingFunction is 'cubic-bezier(0.1, 5, 0.23, 0)'
     132PASS computedStyle.webkitTransitionTimingFunction is 'cubic-bezier(0.1, 5, 0.23, 0)'
     133PASS style.transitionTimingFunction is 'cubic-bezier(0.2, 2, 0.2, -0.4)'
     134PASS computedStyle.transitionTimingFunction is 'cubic-bezier(0.2, 2, 0.2, -0.4)'
     135PASS style.webkitTransitionTimingFunction is 'cubic-bezier(0.2, 2, 0.2, -0.4)'
     136PASS computedStyle.webkitTransitionTimingFunction is 'cubic-bezier(0.2, 2, 0.2, -0.4)'
     137PASS style.transitionTimingFunction is 'cubic-bezier(0.2, -2, 0.2, 0.4)'
     138PASS computedStyle.transitionTimingFunction is 'cubic-bezier(0.2, -2, 0.2, 0.4)'
     139PASS style.webkitTransitionTimingFunction is 'cubic-bezier(0.2, -2, 0.2, 0.4)'
     140PASS computedStyle.webkitTransitionTimingFunction is 'cubic-bezier(0.2, -2, 0.2, 0.4)'
     141PASS style.transitionTimingFunction is 'cubic-bezier(3, 0.1, 4, 1)'
     142PASS computedStyle.transitionTimingFunction is 'cubic-bezier(3, 0.1, 4, 1)'
     143PASS style.webkitTransitionTimingFunction is 'cubic-bezier(3, 0.1, 4, 1)'
     144PASS computedStyle.webkitTransitionTimingFunction is 'cubic-bezier(3, 0.1, 4, 1)'
     145PASS style.transitionTimingFunction is 'cubic-bezier(1, 0.1, 3, 1)'
     146PASS computedStyle.transitionTimingFunction is 'cubic-bezier(1, 0.1, 3, 1)'
     147PASS style.webkitTransitionTimingFunction is 'cubic-bezier(1, 0.1, 3, 1)'
     148PASS computedStyle.webkitTransitionTimingFunction is 'cubic-bezier(1, 0.1, 3, 1)'
    121149PASS style.transitionTimingFunction is 'cubic-bezier(0.1, 0, 4, 0.4)'
    122150PASS computedStyle.transitionTimingFunction is 'cubic-bezier(0.1, 0, 4, 0.4)'
    … …  
    131159PASS style.webkitTransitionTimingFunction is 'cubic-bezier(3, 0, 0.2, 0.4)'
    132160PASS computedStyle.webkitTransitionTimingFunction is 'cubic-bezier(3, 0, 0.2, 0.4)'
     161PASS style.transitionTimingFunction is 'cubic-bezier(-0.2, 0, 0.2, 0.4)'
     162PASS computedStyle.transitionTimingFunction is 'cubic-bezier(-0.2, 0, 0.2, 0.4)'
     163PASS style.webkitTransitionTimingFunction is 'cubic-bezier(-0.2, 0, 0.2, 0.4)'
     164PASS computedStyle.webkitTransitionTimingFunction is 'cubic-bezier(-0.2, 0, 0.2, 0.4)'
     165PASS style.transitionTimingFunction is 'cubic-bezier(0.2, 2, -0.2, 0.4)'
     166PASS computedStyle.transitionTimingFunction is 'cubic-bezier(0.2, 2, -0.2, 0.4)'
     167PASS style.webkitTransitionTimingFunction is 'cubic-bezier(0.2, 2, -0.2, 0.4)'
     168PASS computedStyle.webkitTransitionTimingFunction is 'cubic-bezier(0.2, 2, -0.2, 0.4)'
    133169PASS style.transitionTimingFunction is 'step-start'
    134170PASS computedStyle.transitionTimingFunction is 'steps(1, start)'

  • trunk/LayoutTests/transitions/transitions-parsing.html

    r138184 r138721  
    240240shouldBe("computedStyle.webkitTransitionTimingFunction", "'cubic-bezier(0.1, 0, 0.23, 0.4)'");
    241241
     242style.transitionTimingFunction = "cubic-bezier(0.1, 0, 0.23, 3)";
     243shouldBe("style.transitionTimingFunction", "'cubic-bezier(0.1, 0, 0.23, 3)'");
     244shouldBe("computedStyle.transitionTimingFunction", "'cubic-bezier(0.1, 0, 0.23, 3)'");
     245shouldBe("style.webkitTransitionTimingFunction", "'cubic-bezier(0.1, 0, 0.23, 3)'");
     246shouldBe("computedStyle.webkitTransitionTimingFunction", "'cubic-bezier(0.1, 0, 0.23, 3)'");
     247
     248style.transitionTimingFunction = "cubic-bezier(0.1, 5, 0.23, 3)";
     249shouldBe("style.transitionTimingFunction", "'cubic-bezier(0.1, 5, 0.23, 3)'");
     250shouldBe("computedStyle.transitionTimingFunction", "'cubic-bezier(0.1, 5, 0.23, 3)'");
     251shouldBe("style.webkitTransitionTimingFunction", "'cubic-bezier(0.1, 5, 0.23, 3)'");
     252shouldBe("computedStyle.webkitTransitionTimingFunction", "'cubic-bezier(0.1, 5, 0.23, 3)'");
     253
     254style.transitionTimingFunction = "cubic-bezier(0.1, 5, 0.23, 0)";
     255shouldBe("style.transitionTimingFunction", "'cubic-bezier(0.1, 5, 0.23, 0)'");
     256shouldBe("computedStyle.transitionTimingFunction", "'cubic-bezier(0.1, 5, 0.23, 0)'");
     257shouldBe("style.webkitTransitionTimingFunction", "'cubic-bezier(0.1, 5, 0.23, 0)'");
     258shouldBe("computedStyle.webkitTransitionTimingFunction", "'cubic-bezier(0.1, 5, 0.23, 0)'");
     259
     260style.transitionTimingFunction = "cubic-bezier(0.2, 2, 0.2, -0.4)";
     261shouldBe("style.transitionTimingFunction", "'cubic-bezier(0.2, 2, 0.2, -0.4)'");
     262shouldBe("computedStyle.transitionTimingFunction", "'cubic-bezier(0.2, 2, 0.2, -0.4)'");
     263shouldBe("style.webkitTransitionTimingFunction", "'cubic-bezier(0.2, 2, 0.2, -0.4)'");
     264shouldBe("computedStyle.webkitTransitionTimingFunction", "'cubic-bezier(0.2, 2, 0.2, -0.4)'");
     265
     266style.transitionTimingFunction = "cubic-bezier(0.2, -2, 0.2, 0.4)";
     267shouldBe("style.transitionTimingFunction", "'cubic-bezier(0.2, -2, 0.2, 0.4)'");
     268shouldBe("computedStyle.transitionTimingFunction", "'cubic-bezier(0.2, -2, 0.2, 0.4)'");
     269shouldBe("style.webkitTransitionTimingFunction", "'cubic-bezier(0.2, -2, 0.2, 0.4)'");
     270shouldBe("computedStyle.webkitTransitionTimingFunction", "'cubic-bezier(0.2, -2, 0.2, 0.4)'");
     271
     272style.transitionTimingFunction = "cubic-bezier(3, 0.1, 4, 1)";
     273shouldBe("style.transitionTimingFunction", "'cubic-bezier(3, 0.1, 4, 1)'");
     274shouldBe("computedStyle.transitionTimingFunction", "'cubic-bezier(3, 0.1, 4, 1)'");
     275shouldBe("style.webkitTransitionTimingFunction", "'cubic-bezier(3, 0.1, 4, 1)'");
     276shouldBe("computedStyle.webkitTransitionTimingFunction", "'cubic-bezier(3, 0.1, 4, 1)'");
     277
     278style.transitionTimingFunction = "cubic-bezier(1, 0.1, 3, 1)";
     279shouldBe("style.transitionTimingFunction", "'cubic-bezier(1, 0.1, 3, 1)'");
     280shouldBe("computedStyle.transitionTimingFunction", "'cubic-bezier(1, 0.1, 3, 1)'");
     281shouldBe("style.webkitTransitionTimingFunction", "'cubic-bezier(1, 0.1, 3, 1)'");
     282shouldBe("computedStyle.webkitTransitionTimingFunction", "'cubic-bezier(1, 0.1, 3, 1)'");
     283
    242284style.transitionTimingFunction = "cubic-bezier(0.1, 0, 4, 0.4)";
    243285shouldBe("style.transitionTimingFunction", "'cubic-bezier(0.1, 0, 4, 0.4)'");
    … …  
    258300shouldBe("computedStyle.webkitTransitionTimingFunction", "'cubic-bezier(3, 0, 0.2, 0.4)'");
    259301
     302style.transitionTimingFunction = "cubic-bezier(-0.2, 0, 0.2, 0.4)";
     303shouldBe("style.transitionTimingFunction", "'cubic-bezier(-0.2, 0, 0.2, 0.4)'");
     304shouldBe("computedStyle.transitionTimingFunction", "'cubic-bezier(-0.2, 0, 0.2, 0.4)'");
     305shouldBe("style.webkitTransitionTimingFunction", "'cubic-bezier(-0.2, 0, 0.2, 0.4)'");
     306shouldBe("computedStyle.webkitTransitionTimingFunction", "'cubic-bezier(-0.2, 0, 0.2, 0.4)'");
     307
     308style.transitionTimingFunction = "cubic-bezier(0.2, 2, -0.2, 0.4)";
     309shouldBe("style.transitionTimingFunction", "'cubic-bezier(0.2, 2, -0.2, 0.4)'");
     310shouldBe("computedStyle.transitionTimingFunction", "'cubic-bezier(0.2, 2, -0.2, 0.4)'");
     311shouldBe("style.webkitTransitionTimingFunction", "'cubic-bezier(0.2, 2, -0.2, 0.4)'");
     312shouldBe("computedStyle.webkitTransitionTimingFunction", "'cubic-bezier(0.2, 2, -0.2, 0.4)'");
     313
    260314style.transitionTimingFunction = "step-start";
    261315shouldBe("style.transitionTimingFunction", "'step-start'");
    … …  
    359413shouldBe("style.webkitTransitionTimingFunction", "''");
    360414shouldBe("computedStyle.webkitTransitionTimingFunction", "'cubic-bezier(0.25, 0.1, 0.25, 1)'");
    361 
    362 // Tracked by https://bugs.webkit.org/show_bug.cgi?id=105426.
    363 /*style.transitionTimingFunction = "cubic-bezier(3, 0.1, 4, 1)";
    364 shouldBe("style.transitionTimingFunction", "''");
    365 shouldBe("computedStyle.transitionTimingFunction", "'cubic-bezier(0.25, 0.1, 0.25, 1)'");
    366 shouldBe("style.webkitTransitionTimingFunction", "''");
    367 shouldBe("computedStyle.webkitTransitionTimingFunction", "'cubic-bezier(0.25, 0.1, 0.25, 1)'");
    368 
    369 style.transitionTimingFunction = "cubic-bezier(1, 0.1, 3, 1)";
    370 shouldBe("style.transitionTimingFunction", "''");
    371 shouldBe("computedStyle.transitionTimingFunction", "'cubic-bezier(0.25, 0.1, 0.25, 1)'");
    372 shouldBe("style.webkitTransitionTimingFunction", "''");
    373 shouldBe("computedStyle.webkitTransitionTimingFunction", "'cubic-bezier(0.25, 0.1, 0.25, 1)'");*/
    374415
    375416debug("Valid transition-delay values.");
Note: See TracChangeset for help on using the changeset viewer.