Changeset 138725 in webkit
- Timestamp:
- Jan 3, 2013 11:59:02 AM (11 years ago)
- Location:
- trunk/Source/WebCore
- Files:
-
- 3 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/Source/WebCore/ChangeLog
r138724 r138725 1 2013-01-03 Arko Saha <arko@motorola.com> 2 3 Microdata: Fix build failure after r137003 4 https://bugs.webkit.org/show_bug.cgi?id=106023 5 6 Reviewed by Ryosuke Niwa. 7 8 Set HTMLCollection::namedPropertyGetter as named property getter for 9 HTMLPropertiesCollection in GenerateImplementationNamedPropertyGetter. 10 11 * bindings/scripts/CodeGeneratorV8.pm: 12 (GenerateImplementationNamedPropertyGetter): 13 * bindings/v8/custom/V8HTMLCollectionCustom.cpp: 14 (WebCore::V8HTMLCollection::namedPropertyGetter): 15 1 16 2013-01-03 Adam Klein <adamk@chromium.org> 2 17 -
trunk/Source/WebCore/bindings/scripts/CodeGeneratorV8.pm
r138665 r138725 2566 2566 } 2567 2567 2568 push(@implContent, " desc->${setOn}Template()->SetNamedPropertyHandler(${v8InterfaceName}::namedPropertyGetter, "); 2568 if ($interfaceName eq "HTMLPropertiesCollection") { 2569 push(@implContent, " desc->${setOn}Template()->SetNamedPropertyHandler(V8HTMLCollection::namedPropertyGetter, "); 2570 } else { 2571 push(@implContent, " desc->${setOn}Template()->SetNamedPropertyHandler(${v8InterfaceName}::namedPropertyGetter, "); 2572 } 2569 2573 push(@implContent, $hasCustomNamedSetter ? "${v8InterfaceName}::namedPropertySetter, " : "0, "); 2570 2574 # If there is a custom enumerator, there MUST be custom query to properly communicate property attributes. -
trunk/Source/WebCore/bindings/v8/custom/V8HTMLCollectionCustom.cpp
r138677 r138725 41 41 #include "V8NamedNodesCollection.h" 42 42 #include "V8Node.h" 43 #include "V8PropertyNodeList.h" 43 44 44 45 namespace WebCore { … … 54 55 #if ENABLE(MICRODATA) 55 56 if (imp->type() == ItemProperties) { 56 PropertyNodeList* item = static_cast<HTMLPropertiesCollection*>(imp)->propertyNodeList(toWebCoreAtomicString(name)) ;57 PropertyNodeList* item = static_cast<HTMLPropertiesCollection*>(imp)->propertyNodeList(toWebCoreAtomicString(name)).get(); 57 58 if (!item) 58 59 return v8Undefined();
Note: See TracChangeset
for help on using the changeset viewer.