Changeset 138725 in webkit


Ignore:
Timestamp:
Jan 3, 2013 11:59:02 AM (11 years ago)
Author:
arko@motorola.com
Message:

Microdata: Fix build failure after r137003
https://bugs.webkit.org/show_bug.cgi?id=106023

Reviewed by Ryosuke Niwa.

Set HTMLCollection::namedPropertyGetter as named property getter for
HTMLPropertiesCollection in GenerateImplementationNamedPropertyGetter.

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateImplementationNamedPropertyGetter):

  • bindings/v8/custom/V8HTMLCollectionCustom.cpp:

(WebCore::V8HTMLCollection::namedPropertyGetter):

Location:
trunk/Source/WebCore
Files:
3 edited

Legend:

Unmodified
Added
Removed
  • trunk/Source/WebCore/ChangeLog

    r138724 r138725  
     12013-01-03   Arko Saha  <arko@motorola.com>
     2
     3        Microdata: Fix build failure after r137003
     4        https://bugs.webkit.org/show_bug.cgi?id=106023
     5
     6        Reviewed by Ryosuke Niwa.
     7
     8        Set HTMLCollection::namedPropertyGetter as named property getter for
     9        HTMLPropertiesCollection in GenerateImplementationNamedPropertyGetter.
     10
     11        * bindings/scripts/CodeGeneratorV8.pm:
     12        (GenerateImplementationNamedPropertyGetter):
     13        * bindings/v8/custom/V8HTMLCollectionCustom.cpp:
     14        (WebCore::V8HTMLCollection::namedPropertyGetter):
     15
    1162013-01-03  Adam Klein  <adamk@chromium.org>
    217
  • trunk/Source/WebCore/bindings/scripts/CodeGeneratorV8.pm

    r138665 r138725  
    25662566    }
    25672567
    2568     push(@implContent, "    desc->${setOn}Template()->SetNamedPropertyHandler(${v8InterfaceName}::namedPropertyGetter, ");
     2568    if ($interfaceName eq "HTMLPropertiesCollection") {
     2569        push(@implContent, "    desc->${setOn}Template()->SetNamedPropertyHandler(V8HTMLCollection::namedPropertyGetter, ");
     2570    } else {
     2571        push(@implContent, "    desc->${setOn}Template()->SetNamedPropertyHandler(${v8InterfaceName}::namedPropertyGetter, ");
     2572    }
    25692573    push(@implContent, $hasCustomNamedSetter ? "${v8InterfaceName}::namedPropertySetter, " : "0, ");
    25702574    # If there is a custom enumerator, there MUST be custom query to properly communicate property attributes.
  • trunk/Source/WebCore/bindings/v8/custom/V8HTMLCollectionCustom.cpp

    r138677 r138725  
    4141#include "V8NamedNodesCollection.h"
    4242#include "V8Node.h"
     43#include "V8PropertyNodeList.h"
    4344
    4445namespace WebCore {
     
    5455#if ENABLE(MICRODATA)
    5556    if (imp->type() == ItemProperties) {
    56         PropertyNodeList* item = static_cast<HTMLPropertiesCollection*>(imp)->propertyNodeList(toWebCoreAtomicString(name));
     57        PropertyNodeList* item = static_cast<HTMLPropertiesCollection*>(imp)->propertyNodeList(toWebCoreAtomicString(name)).get();
    5758        if (!item)
    5859            return v8Undefined();
Note: See TracChangeset for help on using the changeset viewer.