Changeset 138746 in webkit


Ignore:
Timestamp:
Jan 3, 2013 2:44:11 PM (11 years ago)
Author:
commit-queue@webkit.org
Message:

webkit fails IETC column-width-negative-001.htm
​https://bugs.webkit.org/show_bug.cgi?id=84778

Patch by Uday Kiran <​udaykiran@motorola.com> on 2013-01-03
Reviewed by Tony Chang.

Source/WebCore:

CSS3 multicolumn 'column-width' property value must be greater than zero.
​http://dev.w3.org/csswg/css3-multicol/#column-width

Test: fast/multicol/column-width-zero.html
Negative value test covered by ietestcenter/css3/multicolumn/column-width-negative-001.htm

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseValue): Check for value greater than zero while parsing.

LayoutTests:

New test for multicolumn 'column-width' property with zero value.
Enable IETC column-width-negative test.

  • fast/multicol/column-width-zero-expected.txt: Added.
  • fast/multicol/column-width-zero.html: Added.
  • platform/chromium/TestExpectations:
  • platform/efl/TestExpectations:
  • platform/gtk/TestExpectations:
  • platform/mac/TestExpectations:
  • platform/qt/TestExpectations:
Location:
trunk
Files:
2 added
8 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r138743 r138746  
     12013-01-03  Uday Kiran  <udaykiran@motorola.com>
     2
     3        webkit fails IETC column-width-negative-001.htm
     4        https://bugs.webkit.org/show_bug.cgi?id=84778
     5
     6        Reviewed by Tony Chang.
     7
     8        New test for multicolumn 'column-width' property with zero value.
     9        Enable IETC column-width-negative test.
     10
     11        * fast/multicol/column-width-zero-expected.txt: Added.
     12        * fast/multicol/column-width-zero.html: Added.
     13        * platform/chromium/TestExpectations:
     14        * platform/efl/TestExpectations:
     15        * platform/gtk/TestExpectations:
     16        * platform/mac/TestExpectations:
     17        * platform/qt/TestExpectations:
     18
    1192013-01-03  Ryosuke Niwa  <rniwa@webkit.org>
    220

  • trunk/LayoutTests/platform/chromium/TestExpectations

    r138717 r138746  
    33623362webkit.org/b/84773 ietestcenter/css3/multicolumn/column-width-applies-to-012.htm [ ImageOnlyFailure ]
    33633363webkit.org/b/84777 ietestcenter/css3/multicolumn/column-width-applies-to-015.htm [ ImageOnlyFailure ]
    3364 webkit.org/b/84778 ietestcenter/css3/multicolumn/column-width-negative-001.htm [ ImageOnlyFailure ]
    33653364
    33663365webkit.org/b/102163 [ MountainLion ] ietestcenter/css3/multicolumn/column-block-formatting-context-001.htm [ ImageOnlyFailure ]

  • trunk/LayoutTests/platform/efl/TestExpectations

    r138594 r138746  
    11901190webkit.org/b/84773 ietestcenter/css3/multicolumn/column-width-applies-to-012.htm [ ImageOnlyFailure ]
    11911191webkit.org/b/84777 ietestcenter/css3/multicolumn/column-width-applies-to-015.htm [ ImageOnlyFailure ]
    1192 webkit.org/b/84778 ietestcenter/css3/multicolumn/column-width-negative-001.htm [ ImageOnlyFailure ]
    11931192
    11941193webkit.org/b/72363 fast/dom/Window/window-postmessage-arrays.html [ Failure ]

  • trunk/LayoutTests/platform/gtk/TestExpectations

    r138566 r138746  
    12151215webkit.org/b/84773 ietestcenter/css3/multicolumn/column-width-applies-to-012.htm [ ImageOnlyFailure ]
    12161216webkit.org/b/84777 ietestcenter/css3/multicolumn/column-width-applies-to-015.htm [ ImageOnlyFailure ]
    1217 webkit.org/b/84778 ietestcenter/css3/multicolumn/column-width-negative-001.htm [ ImageOnlyFailure ]
    12181217
    12191218webkit.org/b/87951 fast/dom/Window/mozilla-focus-blur.html [ Failure ]

  • trunk/LayoutTests/platform/mac/TestExpectations

    r138734 r138746  
    10921092webkit.org/b/84773 ietestcenter/css3/multicolumn/column-width-applies-to-012.htm [ ImageOnlyFailure ]
    10931093webkit.org/b/84777 ietestcenter/css3/multicolumn/column-width-applies-to-015.htm [ ImageOnlyFailure ]
    1094 webkit.org/b/84778 ietestcenter/css3/multicolumn/column-width-negative-001.htm [ ImageOnlyFailure ]
    10951094
    10961095webkit.org/b/60731 ietestcenter/css3/grid/grid-column-001.htm [ ImageOnlyFailure ]

  • trunk/LayoutTests/platform/qt/TestExpectations

    r138710 r138746  
    23522352webkit.org/b/84773 ietestcenter/css3/multicolumn/column-width-applies-to-012.htm [ ImageOnlyFailure ]
    23532353webkit.org/b/84777 ietestcenter/css3/multicolumn/column-width-applies-to-015.htm [ ImageOnlyFailure ]
    2354 webkit.org/b/84778 ietestcenter/css3/multicolumn/column-width-negative-001.htm [ ImageOnlyFailure ]
    23552354
    23562355# IETC flexbox failures

  • trunk/Source/WebCore/ChangeLog

    r138738 r138746  
     12013-01-03  Uday Kiran  <udaykiran@motorola.com>
     2
     3        webkit fails IETC column-width-negative-001.htm
     4        https://bugs.webkit.org/show_bug.cgi?id=84778
     5
     6        Reviewed by Tony Chang.
     7
     8        CSS3 multicolumn 'column-width' property value must be greater than zero.
     9        http://dev.w3.org/csswg/css3-multicol/#column-width
     10
     11        Test: fast/multicol/column-width-zero.html
     12        Negative value test covered by ietestcenter/css3/multicolumn/column-width-negative-001.htm
     13
     14        * css/CSSParser.cpp:
     15        (WebCore::CSSParser::parseValue): Check for value greater than zero while parsing.
     16
    1172013-01-03  Tommy Widenflycht  <tommyw@google.com>
    218

  • trunk/Source/WebCore/css/CSSParser.cpp

    r138141 r138746  
    25642564            validPrimitive = true;
    25652565        else // Always parse this property in strict mode, since it would be ambiguous otherwise when used in the 'columns' shorthand property.
    2566             validPrimitive = validUnit(value, FLength, CSSStrictMode);
     2566            validPrimitive = validUnit(value, FLength | FNonNeg, CSSStrictMode) && value->fValue;
    25672567        break;
    25682568    // End of CSS3 properties
Note: See TracChangeset for help on using the changeset viewer.