Changeset 138808 in webkit


Ignore:
Timestamp:
Jan 4, 2013 9:58:11 AM (11 years ago)
Author:
commit-queue@webkit.org
Message:

Existence of window.Touch can break websites mobile device detection
​https://bugs.webkit.org/show_bug.cgi?id=106071

Source/WebCore:

Patch by Rick Byers <​rbyers@chromium.org> on 2013-01-04
Reviewed by Ojan Vafai.

Revert ​http://trac.webkit.org/changeset/135562 for now while I work
on a slightly safer version.

  • page/DOMWindow.idl:

LayoutTests:

Revert ​http://trac.webkit.org/changeset/135562 for now while I work
on a slightly safer version.

Patch by Rick Byers <​rbyers@chromium.org> on 2013-01-04
Reviewed by Ojan Vafai.

  • fast/events/touch/document-create-touch-list-expected.txt:
  • fast/events/touch/script-tests/document-create-touch-list.js:
  • platform/efl/fast/js/global-constructors-expected.txt:
  • platform/qt-5.0/fast/js/global-constructors-expected.txt:
  • platform/qt/fast/js/global-constructors-expected.txt:
Location:
trunk
Files:
8 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r138807 r138808  
     12013-01-04  Rick Byers  <rbyers@chromium.org>
     2
     3        Existence of window.Touch can break websites mobile device detection
     4        https://bugs.webkit.org/show_bug.cgi?id=106071
     5
     6        Revert http://trac.webkit.org/changeset/135562 for now while I work
     7        on a slightly safer version.
     8
     9        Reviewed by Ojan Vafai.
     10
     11        * fast/events/touch/document-create-touch-list-expected.txt:
     12        * fast/events/touch/script-tests/document-create-touch-list.js:
     13        * platform/efl/fast/js/global-constructors-expected.txt:
     14        * platform/qt-5.0/fast/js/global-constructors-expected.txt:
     15        * platform/qt/fast/js/global-constructors-expected.txt:
     16
    1172013-01-04  Csaba Osztrogonác  <ossy@webkit.org>
    218

  • trunk/LayoutTests/fast/events/touch/document-create-touch-list-expected.txt

    r135562 r138808  
    1010PASS touchList.item(1) is null
    1111PASS touchList.item() threw exception TypeError: Not enough arguments.
    12 PASS ts instanceof TouchEvent is true
    13 PASS ts.touches instanceof TouchList is true
    1412PASS ts.touches.length is 2
    15 PASS ts.touches[0] instanceof Touch is true
    1613PASS ts.touches[0].identifier is 12341
    1714PASS ts.touches[0].clientX is 60

  • trunk/LayoutTests/fast/events/touch/script-tests/document-create-touch-list.js

    r135562 r138808  
    2222    document.body.addEventListener("touchstart", function handleTouchStart(ev) {
    2323        ts = ev;
    24         shouldBeTrue("ts instanceof TouchEvent");
    25         shouldBeTrue("ts.touches instanceof TouchList");
    2624        shouldBe("ts.touches.length", "2");
    27         shouldBeTrue("ts.touches[0] instanceof Touch");
    2825        shouldBe("ts.touches[0].identifier", "12341");
    2926        shouldBe("ts.touches[0].clientX", "60");

  • trunk/LayoutTests/platform/efl/fast/js/global-constructors-expected.txt

    r138589 r138808  
    323323PASS TextTrackList.toString() is '[object TextTrackListConstructor]'
    324324PASS TimeRanges.toString() is '[object TimeRangesConstructor]'
    325 PASS Touch.toString() is '[object TouchConstructor]'
    326325PASS TouchEvent.toString() is '[object TouchEventConstructor]'
    327 PASS TouchList.toString() is '[object TouchListConstructor]'
    328326PASS TrackEvent.toString() is '[object TrackEventConstructor]'
    329327PASS UIEvent.toString() is '[object UIEventConstructor]'

  • trunk/LayoutTests/platform/qt-5.0/fast/js/global-constructors-expected.txt

    r138419 r138808  
    313313PASS TextMetrics.toString() is '[object TextMetricsConstructor]'
    314314PASS TimeRanges.toString() is '[object TimeRangesConstructor]'
    315 PASS Touch.toString() is '[object TouchConstructor]'
    316315PASS TouchEvent.toString() is '[object TouchEventConstructor]'
    317 PASS TouchList.toString() is '[object TouchListConstructor]'
    318316PASS UIEvent.toString() is '[object UIEventConstructor]'
    319317PASS URL.toString() is '[object URLConstructor]'

  • trunk/LayoutTests/platform/qt/fast/js/global-constructors-expected.txt

    r135749 r138808  
    296296PASS TextMetrics.toString() is '[object TextMetricsConstructor]'
    297297PASS TimeRanges.toString() is '[object TimeRangesConstructor]'
    298 PASS Touch.toString() is '[object TouchConstructor]'
    299298PASS TouchEvent.toString() is '[object TouchEventConstructor]'
    300 PASS TouchList.toString() is '[object TouchListConstructor]'
    301299PASS UIEvent.toString() is '[object UIEventConstructor]'
    302300PASS WebGLContextEvent.toString() is '[object WebGLContextEventConstructor]'

  • trunk/Source/WebCore/ChangeLog

    r138806 r138808  
     12013-01-04  Rick Byers  <rbyers@chromium.org>
     2
     3        Existence of window.Touch can break websites mobile device detection
     4        https://bugs.webkit.org/show_bug.cgi?id=106071
     5
     6        Reviewed by Ojan Vafai.
     7
     8        Revert http://trac.webkit.org/changeset/135562 for now while I work
     9        on a slightly safer version.
     10
     11        * page/DOMWindow.idl:
     12
    1132013-01-04  Martin Robinson  <mrobinson@igalia.com>
    214

  • trunk/Source/WebCore/page/DOMWindow.idl

    r138646 r138808  
    557557    [Conditional=DEVICE_ORIENTATION, V8EnabledAtRuntime] attribute DeviceMotionEventConstructor DeviceMotionEvent;
    558558    [Conditional=DEVICE_ORIENTATION, V8EnabledAtRuntime] attribute DeviceOrientationEventConstructor DeviceOrientationEvent;
    559     [Conditional=TOUCH_EVENTS] attribute TouchConstructor Touch;
    560559    [Conditional=TOUCH_EVENTS] attribute TouchEventConstructor TouchEvent;
    561     [Conditional=TOUCH_EVENTS] attribute TouchListConstructor TouchList;
    562560    attribute StorageEventConstructor StorageEvent;
    563561    [Conditional=INPUT_SPEECH] attribute SpeechInputEventConstructor SpeechInputEvent;
Note: See TracChangeset for help on using the changeset viewer.