Changeset 138865 in webkit

Timestamp:

Jan 4, 2013 4:18:50 PM (11 years ago)

Author:

roger_fong@apple.com

Message:

Make private browsing work on Windows.
​https://bugs.webkit.org/show_bug.cgi?id=106032.

Reviewed by Alexey Proskuryakov.

Code path never called ensurePrivateBrowsingSession which is what starts up the private browsing session.
This was causing many tests to involving private browsing to fail.

• WebView.cpp:

(WebView::notifyPreferencesChanged):

Location:

trunk/Source/WebKit/win

Files:

• ChangeLog (modified) (1 diff)
• WebView.cpp (modified) (1 diff)

trunk/Source/WebKit/win/ChangeLog

@@ +1 @@
+2013-01-04  Roger Fong  <roger_fong@apple.com>
+
+        Make private browsing work on Windows.
+        https://bugs.webkit.org/show_bug.cgi?id=106032.
+
+        Reviewed by Alexey Proskuryakov.
+
+        Code path never called ensurePrivateBrowsingSession which is what starts up the private browsing session.
+        This was causing many tests to involving private browsing to fail.
+
+        * WebView.cpp:
+        (WebView::notifyPreferencesChanged):
+
 2013-01-03  Roger Fong  <roger_fong@apple.com>
 

trunk/Source/WebKit/win/WebView.cpp

@@ -4681 +4681 @@
     if (FAILED(hr))
         return hr;
+#if PLATFORM(WIN) || USE(CFNETWORK)
+    if (enabled)
+        WebFrameNetworkingContext::ensurePrivateBrowsingSession();
+    else
+        WebFrameNetworkingContext::destroyPrivateBrowsingSession();
+#endif
     settings->setPrivateBrowsingEnabled(!!enabled);