Changeset 138906 in webkit


Ignore:
Timestamp:
Jan 5, 2013 1:07:04 PM (11 years ago)
Author:
mkwst@chromium.org
Message:

Cleanup: mayDisplaySeamlessWithParent -> mayDisplaySeamless_ly_WithParent
https://bugs.webkit.org/show_bug.cgi?id=106169

Reviewed by Eric Seidel.

This patch renames SecurityContext's 'm_mayDisplaySeamlessWithParent' to
'm_mayDisplaySeamlesslyWithParent'. Because adverbs matter.

  • dom/Document.cpp:

(WebCore::Document::initSecurityContext):
(WebCore::Document::shouldDisplaySeamlesslyWithParent):

  • dom/SecurityContext.cpp:

(WebCore::SecurityContext::SecurityContext):

  • dom/SecurityContext.h:

(SecurityContext):

Location:
trunk/Source/WebCore
Files:
4 edited

Legend:

Unmodified
Added
Removed
  • trunk/Source/WebCore/ChangeLog

    r138904 r138906  
     12013-01-05  Mike West  <mkwst@chromium.org>
     2
     3        Cleanup: mayDisplaySeamlessWithParent -> mayDisplaySeamless_ly_WithParent
     4        https://bugs.webkit.org/show_bug.cgi?id=106169
     5
     6        Reviewed by Eric Seidel.
     7
     8        This patch renames SecurityContext's 'm_mayDisplaySeamlessWithParent' to
     9        'm_mayDisplaySeamlesslyWithParent'. Because adverbs matter.
     10
     11        * dom/Document.cpp:
     12        (WebCore::Document::initSecurityContext):
     13        (WebCore::Document::shouldDisplaySeamlesslyWithParent):
     14        * dom/SecurityContext.cpp:
     15        (WebCore::SecurityContext::SecurityContext):
     16        * dom/SecurityContext.h:
     17        (SecurityContext):
     18
    1192013-01-05  Mike West  <mkwst@chromium.org>
    220
  • trunk/Source/WebCore/dom/Document.cpp

    r138863 r138906  
    45844584    // FIXME: What happens if we inherit the security origin? This check may need to be later.
    45854585    // <iframe seamless src="about:blank"> likely won't work as-is.
    4586     m_mayDisplaySeamlessWithParent = isEligibleForSeamless(parentDocument, this);
     4586    m_mayDisplaySeamlesslyWithParent = isEligibleForSeamless(parentDocument, this);
    45874587
    45884588    if (!shouldInheritSecurityOriginFromOwner(m_url))
     
    56625662    if (!ownerElement)
    56635663        return false;
    5664     return m_mayDisplaySeamlessWithParent && ownerElement->hasTagName(iframeTag) && ownerElement->fastHasAttribute(seamlessAttr);
     5664    return m_mayDisplaySeamlesslyWithParent && ownerElement->hasTagName(iframeTag) && ownerElement->fastHasAttribute(seamlessAttr);
    56655665#else
    56665666    return false;
  • trunk/Source/WebCore/dom/SecurityContext.cpp

    r134766 r138906  
    3737
    3838SecurityContext::SecurityContext()
    39     : m_mayDisplaySeamlessWithParent(false)
     39    : m_mayDisplaySeamlesslyWithParent(false)
    4040    , m_haveInitializedSecurityOrigin(false)
    4141    , m_sandboxFlags(SandboxNone)
  • trunk/Source/WebCore/dom/SecurityContext.h

    r134766 r138906  
    8989    // Set in Document::initSecurityContext() at Document creation, per:
    9090    // http://www.whatwg.org/specs/web-apps/current-work/#attr-iframe-seamless
    91     bool m_mayDisplaySeamlessWithParent;
     91    bool m_mayDisplaySeamlesslyWithParent;
    9292
    9393private:
Note: See TracChangeset for help on using the changeset viewer.