Changeset 138919 in webkit

Timestamp:

Jan 6, 2013 12:26:23 PM (11 years ago)

Author:

commit-queue@webkit.org

Message:

Bug 106177 - [GStreamer] Don't call gst_video_info_from_caps() with non-fixed caps
​https://bugs.webkit.org/show_bug.cgi?id=106177

Patch by Sebastian Dröge <​sebastian.droege@collabora.co.uk> on 2013-01-06
Reviewed by Martin Robinson.

• platform/graphics/gstreamer/GStreamerVersioning.cpp:

(getVideoSizeAndFormatFromCaps):
Don't call gst_video_info_from_caps() with non-fixed caps as
it will cause assertions.

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• platform/graphics/gstreamer/GStreamerVersioning.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2013-01-06  Sebastian Dröge  <sebastian.droege@collabora.co.uk>
+
+        Bug 106177 - [GStreamer] Don't call gst_video_info_from_caps() with non-fixed caps
+        https://bugs.webkit.org/show_bug.cgi?id=106177
+
+        Reviewed by Martin Robinson.
+
+        * platform/graphics/gstreamer/GStreamerVersioning.cpp:
+        (getVideoSizeAndFormatFromCaps):
+        Don't call gst_video_info_from_caps() with non-fixed caps as
+        it will cause assertions.
+
 2013-01-06  Abhishek Arya  <inferno@chromium.org>
 

trunk/Source/WebCore/platform/graphics/gstreamer/GStreamerVersioning.cpp

@@ -76 +76 @@
 #ifdef GST_API_VERSION_1
     GstVideoInfo info;
-    if (!gst_video_info_from_caps(&info, caps))
+
+    if (!gst_caps_is_fixed(caps) || !gst_video_info_from_caps(&info, caps))
         return false;