Changeset 138922 in webkit


Ignore:
Timestamp:
Jan 6, 2013 10:03:17 PM (11 years ago)
Author:
shinyak@chromium.org
Message:

RenderImage should not use shadowAncestorNode
https://bugs.webkit.org/show_bug.cgi?id=97871

Reviewed by Dimitri Glazkov.

Since shadowAncestorNode() does not return 0, this if-condition will never hold.
shadowHost() should be used instead.

No change in logic, refactoring.

  • rendering/RenderImage.cpp:

(WebCore::RenderImage::hostImageElement):

Location:
trunk/Source/WebCore
Files:
2 edited

Legend:

Unmodified
Added
Removed
  • trunk/Source/WebCore/ChangeLog

    r138919 r138922  
     12013-01-06  Shinya Kawanaka  <shinyak@chromium.org>
     2
     3        RenderImage should not use shadowAncestorNode
     4        https://bugs.webkit.org/show_bug.cgi?id=97871
     5
     6        Reviewed by Dimitri Glazkov.
     7
     8        Since shadowAncestorNode() does not return 0, this if-condition will never hold.
     9        shadowHost() should be used instead.
     10
     11        No change in logic, refactoring.
     12
     13        * rendering/RenderImage.cpp:
     14        (WebCore::RenderImage::hostImageElement):
     15
    1162013-01-06  Sebastian Dröge  <sebastian.droege@collabora.co.uk>
    217
  • trunk/Source/WebCore/rendering/RenderImage.cpp

    r138838 r138922  
    587587
    588588    if (node()->hasTagName(webkitInnerImageTag)) {
    589         if (Node* ancestor = node()->shadowAncestorNode()) {
     589        if (Node* ancestor = node()->shadowHost()) {
    590590            if (ancestor->hasTagName(imgTag))
    591591                return toHTMLImageElement(ancestor);
Note: See TracChangeset for help on using the changeset viewer.