Changeset 138935 in webkit
- Timestamp:
- Jan 7, 2013 5:26:13 AM (11 years ago)
- Location:
- trunk
- Files:
-
- 4 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/LayoutTests/ChangeLog
r138934 r138935 1 2013-01-07 Christophe Dumez <christophe.dumez@intel.com> 2 3 Regression(r138786): Causes webaudio tests to crash 4 https://bugs.webkit.org/show_bug.cgi?id=106182 5 6 Reviewed by Philippe Normand. 7 8 Unskip several webaudio tests for EFL WK2 now that the 9 regression was fixed. 10 11 * platform/efl-wk2/TestExpectations: 12 1 13 2013-01-07 János Badics <jbadics@inf.u-szeged.hu> 2 14 -
trunk/LayoutTests/platform/efl-wk2/TestExpectations
r138930 r138935 59 59 webkit.org/b/102651 [ Debug ] networkinformation/add-listener-from-callback.html [ Crash ] 60 60 webkit.org/b/102651 [ Debug ] networkinformation/basic-operation.html [ Crash ] 61 62 # Regression after r138786.63 webkit.org/b/106182 webaudio/gain.html [ Crash ]64 webkit.org/b/106182 webaudio/convolution-mono-mono.html [ Crash ]65 webkit.org/b/106182 webaudio/audiochannelmerger-stereo.html [ Crash ]66 webkit.org/b/106182 webaudio/decode-audio-data-basic.html [ Crash ]67 webkit.org/b/106182 webaudio/mediastreamaudiodestinationnode.html [ Crash ]68 webkit.org/b/106182 webaudio/audiobuffersource-loop-comprehensive.html [ Crash ]69 webkit.org/b/106182 webaudio/biquad-highpass.html [ Crash ]70 webkit.org/b/106182 webaudio/realtimeanalyser-fft-sizing.html [ Crash ]71 webkit.org/b/106182 webaudio/audioparam-connect-audioratesignal.html [ Crash ]72 61 73 62 #//////////////////////////////////////////////////////////////////////////////////////// -
trunk/Source/WebCore/ChangeLog
r138929 r138935 1 2013-01-07 Christophe Dumez <christophe.dumez@intel.com> 2 3 Regression(r138786): Causes webaudio tests to crash 4 https://bugs.webkit.org/show_bug.cgi?id=106182 5 6 Reviewed by Philippe Normand. 7 8 Partially revert r138786 since it causes crashes in webaudio 9 tests. The WebProcess would actually become unresponsive due 10 to source element never going to PLAYING state. 11 12 Only the changes to webKitWebAudioSrcChangeState() were reverted. 13 14 No new tests, already covered by existing tests. 15 16 * platform/audio/gstreamer/WebKitWebAudioSourceGStreamer.cpp: 17 (webKitWebAudioSrcChangeState): 18 1 19 2013-01-07 Hayato Ito <hayato@chromium.org> 2 20 -
trunk/Source/WebCore/platform/audio/gstreamer/WebKitWebAudioSourceGStreamer.cpp
r138786 r138935 420 420 case GST_STATE_CHANGE_READY_TO_PAUSED: 421 421 GST_DEBUG_OBJECT(src, "READY->PAUSED"); 422 returnValue = GST_STATE_CHANGE_NO_PREROLL;423 break;424 case GST_STATE_CHANGE_PAUSED_TO_PLAYING:425 GST_DEBUG_OBJECT(src, "PAUSED->PLAYING");426 422 if (!gst_task_start(src->priv->task.get())) 427 423 returnValue = GST_STATE_CHANGE_FAILURE; 428 424 break; 429 case GST_STATE_CHANGE_P LAYING_TO_PAUSED:430 GST_DEBUG_OBJECT(src, "P LAYING->PAUSED");425 case GST_STATE_CHANGE_PAUSED_TO_READY: 426 GST_DEBUG_OBJECT(src, "PAUSED->READY"); 431 427 if (!gst_task_join(src->priv->task.get())) 432 428 returnValue = GST_STATE_CHANGE_FAILURE;
Note: See TracChangeset
for help on using the changeset viewer.