Changeset 138935 in webkit


Ignore:
Timestamp:
Jan 7, 2013 5:26:13 AM (11 years ago)
Author:
Christophe Dumez
Message:

Regression(r138786): Causes webaudio tests to crash
https://bugs.webkit.org/show_bug.cgi?id=106182

Reviewed by Philippe Normand.

Source/WebCore:

Partially revert r138786 since it causes crashes in webaudio
tests. The WebProcess would actually become unresponsive due
to source element never going to PLAYING state.

Only the changes to webKitWebAudioSrcChangeState() were reverted.

No new tests, already covered by existing tests.

  • platform/audio/gstreamer/WebKitWebAudioSourceGStreamer.cpp:

(webKitWebAudioSrcChangeState):

LayoutTests:

Unskip several webaudio tests for EFL WK2 now that the
regression was fixed.

  • platform/efl-wk2/TestExpectations:
Location:
trunk
Files:
4 edited

Legend:

Unmodified
Added
Removed
  • trunk/LayoutTests/ChangeLog

    r138934 r138935  
     12013-01-07  Christophe Dumez  <christophe.dumez@intel.com>
     2
     3        Regression(r138786): Causes webaudio tests to crash
     4        https://bugs.webkit.org/show_bug.cgi?id=106182
     5
     6        Reviewed by Philippe Normand.
     7
     8        Unskip several webaudio tests for EFL WK2 now that the
     9        regression was fixed.
     10
     11        * platform/efl-wk2/TestExpectations:
     12
    1132013-01-07  János Badics  <jbadics@inf.u-szeged.hu>
    214
  • trunk/LayoutTests/platform/efl-wk2/TestExpectations

    r138930 r138935  
    5959webkit.org/b/102651 [ Debug ] networkinformation/add-listener-from-callback.html [ Crash ]
    6060webkit.org/b/102651 [ Debug ] networkinformation/basic-operation.html [ Crash ]
    61 
    62 # Regression after r138786.
    63 webkit.org/b/106182 webaudio/gain.html [ Crash ]
    64 webkit.org/b/106182 webaudio/convolution-mono-mono.html [ Crash ]
    65 webkit.org/b/106182 webaudio/audiochannelmerger-stereo.html [ Crash ]
    66 webkit.org/b/106182 webaudio/decode-audio-data-basic.html [ Crash ]
    67 webkit.org/b/106182 webaudio/mediastreamaudiodestinationnode.html [ Crash ]
    68 webkit.org/b/106182 webaudio/audiobuffersource-loop-comprehensive.html [ Crash ]
    69 webkit.org/b/106182 webaudio/biquad-highpass.html [ Crash ]
    70 webkit.org/b/106182 webaudio/realtimeanalyser-fft-sizing.html [ Crash ]
    71 webkit.org/b/106182 webaudio/audioparam-connect-audioratesignal.html [ Crash ]
    7261
    7362#////////////////////////////////////////////////////////////////////////////////////////
  • trunk/Source/WebCore/ChangeLog

    r138929 r138935  
     12013-01-07  Christophe Dumez  <christophe.dumez@intel.com>
     2
     3        Regression(r138786): Causes webaudio tests to crash
     4        https://bugs.webkit.org/show_bug.cgi?id=106182
     5
     6        Reviewed by Philippe Normand.
     7
     8        Partially revert r138786 since it causes crashes in webaudio
     9        tests. The WebProcess would actually become unresponsive due
     10        to source element never going to PLAYING state.
     11
     12        Only the changes to webKitWebAudioSrcChangeState() were reverted.
     13
     14        No new tests, already covered by existing tests.
     15
     16        * platform/audio/gstreamer/WebKitWebAudioSourceGStreamer.cpp:
     17        (webKitWebAudioSrcChangeState):
     18
    1192013-01-07  Hayato Ito  <hayato@chromium.org>
    220
  • trunk/Source/WebCore/platform/audio/gstreamer/WebKitWebAudioSourceGStreamer.cpp

    r138786 r138935  
    420420    case GST_STATE_CHANGE_READY_TO_PAUSED:
    421421        GST_DEBUG_OBJECT(src, "READY->PAUSED");
    422         returnValue = GST_STATE_CHANGE_NO_PREROLL;
    423         break;
    424     case GST_STATE_CHANGE_PAUSED_TO_PLAYING:
    425         GST_DEBUG_OBJECT(src, "PAUSED->PLAYING");
    426422        if (!gst_task_start(src->priv->task.get()))
    427423            returnValue = GST_STATE_CHANGE_FAILURE;
    428424        break;
    429     case GST_STATE_CHANGE_PLAYING_TO_PAUSED:
    430         GST_DEBUG_OBJECT(src, "PLAYING->PAUSED");
     425    case GST_STATE_CHANGE_PAUSED_TO_READY:
     426        GST_DEBUG_OBJECT(src, "PAUSED->READY");
    431427        if (!gst_task_join(src->priv->task.get()))
    432428            returnValue = GST_STATE_CHANGE_FAILURE;
Note: See TracChangeset for help on using the changeset viewer.