Changeset 138951 in webkit


Ignore:
Timestamp:
Jan 7, 2013 9:15:19 AM (11 years ago)
Author:
Csaba Osztrogonác
Message:

[Qt] run-webkit-tests cleanup for parallel NRWT
​https://bugs.webkit.org/show_bug.cgi?id=106220

Reviewed by Dirk Pranke.

  • Scripts/run-webkit-tests:

(useNewRunWebKitTests):

  • Scripts/webkitpy/layout_tests/port/qt.py:

(QtPort):
(QtPort.default_child_processes):

Location:
trunk/Tools
Files:
3 edited

Legend:

Unmodified
Added
Removed

  • trunk/Tools/ChangeLog

    r138945 r138951  
     12013-01-07  Csaba Osztrogonác  <ossy@webkit.org>
     2
     3        [Qt] run-webkit-tests cleanup for parallel NRWT
     4        https://bugs.webkit.org/show_bug.cgi?id=106220
     5
     6        Reviewed by Dirk Pranke.
     7
     8        * Scripts/run-webkit-tests:
     9        (useNewRunWebKitTests):
     10        * Scripts/webkitpy/layout_tests/port/qt.py:
     11        (QtPort):
     12        (QtPort.default_child_processes):
     13
    1142013-01-07  Philippe Normand  <pnormand@igalia.com>
    215

  • trunk/Tools/Scripts/run-webkit-tests

    r128164 r138951  
    6666}
    6767
    68 sub platformIsReadyForParallelTesting()
    69 {
    70     # NRWT is able to run the tests in parallel, ORWT was not.
    71     # When we run the tests in parallel, tests which (incorrectly)
    72     # interact with each other can start failing.
    73     # To reduce the failure burden during the transition individual
    74     # platforms can opt-in to parallel test execution by default.
    75 
    76     # We believe all platforms are ready for default parallel testing except
    77     # Qt, as Qt runs more than one build-slave per-server.
    78     # Ossy has asked me to blacklist Qt for now.
    79     return !isQt();
    80 }
    81 
    8268my $script = "perl";
    8369my $harnessName = "old-run-webkit-tests";
    … …  
    8672    $script = "python";
    8773    $harnessName = "new-run-webkit-tests";
    88 
    89     if (!grep(/--child-processes/, @ARGV) and !platformIsReadyForParallelTesting()) {
    90         push(@ARGV, "--child-processes=1");
    91         print "Running new-run-webkit-tests with one child process.\n";
    92         print "For more parallelism, run new-run-webkit-tests directly.\n";
    93     }
    9474
    9575    if (runningOnBuildBot()) {

  • trunk/Tools/Scripts/webkitpy/layout_tests/port/qt.py

    r138353 r138951  
    187187        return result
    188188
     189    # Qt port is not ready for parallel testing, see https://bugs.webkit.org/show_bug.cgi?id=77730 for details.
     190    def default_child_processes(self):
     191        return 1
Note: See TracChangeset for help on using the changeset viewer.