Changeset 139031 in webkit


Ignore:
Timestamp:
Jan 7, 2013 10:03:20 PM (11 years ago)
Author:
Christophe Dumez
Message:

[CoordinatedGraphics] Support invalidation tracking for CoordinatedGraphicsLayer
​https://bugs.webkit.org/show_bug.cgi?id=106002

Reviewed by Noam Rosenthal.

Source/WebKit2:

Add calls to addRepaintRect() to CoordinatedGraphicsLayer so that
we can track invalidation in the composited layer.

  • WebProcess/WebPage/CoordinatedGraphics/CoordinatedGraphicsLayer.cpp:

(WebCore::CoordinatedGraphicsLayer::setContentsNeedsDisplay):
(WebCore::CoordinatedGraphicsLayer::setNeedsDisplay): Pass a FloatRect instead
of an IntRect to setNeedsDisplayInRect() since it is what it expects.
(WebCore::CoordinatedGraphicsLayer::setNeedsDisplayInRect):

LayoutTests:

Unskip several tests that require invalidation tracking for EFL WK2 now that
it is supported by Coordinated Graphics.

  • platform/efl-wk2/TestExpectations:
  • platform/efl/TestExpectations:
  • platform/efl/compositing/repaint/invalidations-on-composited-layers-expected.txt: Added.

Use same expectation as mac port.

  • platform/efl/fast/images/repaint-subrect-grid-expected.txt: Added. We are sometimes

1 pixel off compared to the global expectation likely due to lack for subpixel layout
support.

Location:
trunk
Files:
2 added
5 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r139029 r139031  
     12013-01-07  Christophe Dumez  <christophe.dumez@intel.com>
     2
     3        [CoordinatedGraphics] Support invalidation tracking for CoordinatedGraphicsLayer
     4        https://bugs.webkit.org/show_bug.cgi?id=106002
     5
     6        Reviewed by Noam Rosenthal.
     7
     8        Unskip several tests that require invalidation tracking for EFL WK2 now that
     9        it is supported by Coordinated Graphics.
     10
     11        * platform/efl-wk2/TestExpectations:
     12        * platform/efl/TestExpectations:
     13        * platform/efl/compositing/repaint/invalidations-on-composited-layers-expected.txt: Added.
     14        Use same expectation as mac port.
     15        * platform/efl/fast/images/repaint-subrect-grid-expected.txt: Added. We are sometimes
     16        1 pixel off compared to the global expectation likely due to lack for subpixel layout
     17        support.
     18
    1192013-01-07  Hajime Morrita  <morrita@google.com>
    220

  • trunk/LayoutTests/platform/efl-wk2/TestExpectations

    r138935 r139031  
    318318webkit.org/b/98345 fast/parser/document-open-in-unload.html [ Skip ]
    319319
    320 # Requires TestRunner displayInvalidatedRegion() support.
    321 webkit.org/b/98523 fast/images/repaint-subrect-grid.html [ Failure ]
    322 
    323320# NPP_SetWindow is not called with proper size for the first time.
    324321webkit.org/b/98746 plugins/netscape-plugin-setwindow-size-2.html [ Failure ]

  • trunk/LayoutTests/platform/efl/TestExpectations

    r138939 r139031  
    142142fast/repaint/inline-relative-positioned.html
    143143fast/repaint/overflow-flipped-writing-mode-block.html
    144 fast/repaint/overflow-flipped-writing-mode-table.html
    145144fast/repaint/text-in-relative-positioned-inline.html
    146145fast/repaint/trailing-floats-root-line-box-overflow.html
    … …  
    16171616Bug(EFL) compositing/bounds-in-flipped-writing-mode.html [ Failure ]
    16181617Bug(EFL) compositing/iframes/leave-compositing-iframe.html [ Failure ]
    1619 Bug(EFL) compositing/repaint/invalidations-on-composited-layers.html [ Failure ]
    16201618Bug(EFL) compositing/visibility/visibility-composited.html [ Failure ]
    16211619Bug(EFL) editing/selection/caret-rtl.html [ Failure Pass ]

  • trunk/Source/WebKit2/ChangeLog

    r139023 r139031  
     12013-01-07  Christophe Dumez  <christophe.dumez@intel.com>
     2
     3        [CoordinatedGraphics] Support invalidation tracking for CoordinatedGraphicsLayer
     4        https://bugs.webkit.org/show_bug.cgi?id=106002
     5
     6        Reviewed by Noam Rosenthal.
     7
     8        Add calls to addRepaintRect() to CoordinatedGraphicsLayer so that
     9        we can track invalidation in the composited layer.
     10
     11        * WebProcess/WebPage/CoordinatedGraphics/CoordinatedGraphicsLayer.cpp:
     12        (WebCore::CoordinatedGraphicsLayer::setContentsNeedsDisplay):
     13        (WebCore::CoordinatedGraphicsLayer::setNeedsDisplay): Pass a FloatRect instead
     14        of an IntRect to setNeedsDisplayInRect() since it is what it expects.
     15        (WebCore::CoordinatedGraphicsLayer::setNeedsDisplayInRect):
     16
    1172013-01-07  Anders Carlsson  <andersca@apple.com>
    218

  • trunk/Source/WebKit2/WebProcess/WebPage/CoordinatedGraphics/CoordinatedGraphicsLayer.cpp

    r138234 r139031  
    319319    if (client())
    320320        client()->notifyFlushRequired(this);
     321
     322    addRepaintRect(contentsRect());
    321323}
    322324
    … …  
    430432void CoordinatedGraphicsLayer::setNeedsDisplay()
    431433{
    432     setNeedsDisplayInRect(IntRect(IntPoint::zero(), IntSize(size().width(), size().height())));
     434    setNeedsDisplayInRect(FloatRect(FloatPoint(), size()));
    433435}
    434436
    … …  
    437439    if (m_mainBackingStore)
    438440        m_mainBackingStore->invalidate(IntRect(rect));
    439     didChangeLayerState();
     441
     442    didChangeLayerState();
     443
     444    addRepaintRect(rect);
    440445}
    441446
Note: See TracChangeset for help on using the changeset viewer.