Changeset 139034 in webkit

Timestamp:

Jan 7, 2013 11:07:02 PM (11 years ago)

Author:

Christophe Dumez

Message:

[CoordinatedGraphics] compositing/repaint/resize-repaint.html is failing
​https://bugs.webkit.org/show_bug.cgi?id=104637

Reviewed by Noam Rosenthal.

Source/WebKit2:

r137526 attempted to fix excessive repainting when compositing layers
change size. However, the fix did not suffice for ports using Coordinated
Graphics because CoordinatedGraphicsLayer::setSize() was calling
setNeedsDisplay() causing a full repaint.

This patch removes the call to setNeedsDisplay() in
CoordinatedGraphicsLayer::setSize() so that we don't unconditionally
repaint CoordinatedGraphics layers when their size changes.

• WebProcess/WebPage/CoordinatedGraphics/CoordinatedGraphicsLayer.cpp:

(WebCore::CoordinatedGraphicsLayer::setSize):

LayoutTests:

Unskip compositing/repaint/resize-repaint.html now that Coordinated
Graphics is no longer repainting unconditionally compositing layers
when their size changes.

• platform/efl-wk2/TestExpectations:

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/platform/efl-wk2/TestExpectations (modified) (1 diff)
• Source/WebKit2/ChangeLog (modified) (1 diff)
• Source/WebKit2/WebProcess/WebPage/CoordinatedGraphics/CoordinatedGraphicsLayer.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2013-01-07  Christophe Dumez  <christophe.dumez@intel.com>
+
+        [CoordinatedGraphics] compositing/repaint/resize-repaint.html is failing
+        https://bugs.webkit.org/show_bug.cgi?id=104637
+
+        Reviewed by Noam Rosenthal.
+
+        Unskip compositing/repaint/resize-repaint.html now that Coordinated
+        Graphics is no longer repainting unconditionally compositing layers
+        when their size changes.
+
+        * platform/efl-wk2/TestExpectations:
+
 2013-01-07  Christophe Dumez  <christophe.dumez@intel.com>
 

trunk/LayoutTests/platform/efl-wk2/TestExpectations

@@ -369 +369 @@
 Bug(EFL) svg/transforms/transformed-text-fill-pattern.html [ ImageOnlyFailure ]
 
-# New compositing test introduced in r137215 that is failing on WK2 EFL.
-webkit.org/b/104637 compositing/repaint/resize-repaint.html [ Failure ]
-
 webkit.org/b/104656 compositing/repaint/clipped-layer-size-change.html [ ImageOnlyFailure Pass ]
 

trunk/Source/WebKit2/ChangeLog

@@ +1 @@
+2013-01-07  Christophe Dumez  <christophe.dumez@intel.com>
+
+        [CoordinatedGraphics] compositing/repaint/resize-repaint.html is failing
+        https://bugs.webkit.org/show_bug.cgi?id=104637
+
+        Reviewed by Noam Rosenthal.
+
+        r137526 attempted to fix excessive repainting when compositing layers
+        change size. However, the fix did not suffice for ports using Coordinated
+        Graphics because CoordinatedGraphicsLayer::setSize() was calling
+        setNeedsDisplay() causing a full repaint.
+
+        This patch removes the call to setNeedsDisplay() in
+        CoordinatedGraphicsLayer::setSize() so that we don't unconditionally
+        repaint CoordinatedGraphics layers when their size changes.
+
+        * WebProcess/WebPage/CoordinatedGraphics/CoordinatedGraphicsLayer.cpp:
+        (WebCore::CoordinatedGraphicsLayer::setSize):
+
 2013-01-07  Christophe Dumez  <christophe.dumez@intel.com>
 

trunk/Source/WebKit2/WebProcess/WebPage/CoordinatedGraphics/CoordinatedGraphicsLayer.cpp

@@ -215 +215 @@
 
     GraphicsLayer::setSize(size);
-    setNeedsDisplay();
+
     if (maskLayer())
         maskLayer()->setSize(size);