Changeset 139040 in webkit
- Timestamp:
- Jan 8, 2013 12:12:49 AM (11 years ago)
- Location:
- trunk
- Files:
-
- 2 added
- 4 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/LayoutTests/ChangeLog
r139038 r139040 1 2013-01-08 Yuki Sekiguchi <yuki.sekiguchi@access-company.com> 2 3 Float block's logical top margin is illegal in vertical writing mode. 4 https://bugs.webkit.org/show_bug.cgi?id=96597 5 6 Reviewed by Hajime Morita. 7 8 Specify margin to float block in vertical writing mode. 9 10 * fast/writing-mode/vertical-float-margin-expected.html: Added. 11 * fast/writing-mode/vertical-float-margin.html: Added. 12 * platform/chromium/TestExpectations: Add need rebaseline. 13 1 14 2013-01-07 Kent Tamura <tkent@chromium.org> 2 15 -
trunk/LayoutTests/platform/chromium/TestExpectations
r138985 r139040 4303 4303 webkit.org/b/106249 [ Win ] fast/speech/scripted/navigate-away.html [ Failure Pass ] 4304 4304 4305 # Needs rebaseline. Reducing yellow box top margin is intentional. Looks good on Chromium Linux. 4306 webkit.org/b/96597 fast/multicol/vertical-rl/float-multicol.html [ Failure ImageOnlyFailure ] 4307 # Needs rebaseline. Current expectation is wrong because margin of body don't collapse with margin of 1st child. 4308 webkit.org/b/96597 fast/text/emphasis-vertical.html [ ImageOnlyFailure ] -
trunk/Source/WebCore/ChangeLog
r139038 r139040 1 2013-01-08 Yuki Sekiguchi <yuki.sekiguchi@access-company.com> 2 3 Float block's logical top margin is illegal in vertical writing mode. 4 https://bugs.webkit.org/show_bug.cgi?id=96597 5 6 Reviewed by Hajime Morita. 7 8 flipFloatForWritingModeForChild() should use child->renderer()->width() not child->width() like horizontal writing mode. 9 10 Test: fast/writing-mode/vertical-float-margin.html 11 12 * rendering/RenderBlock.cpp: 13 (WebCore::RenderBlock::flipFloatForWritingModeForChild): 14 1 15 2013-01-07 Kent Tamura <tkent@chromium.org> 2 16 -
trunk/Source/WebCore/rendering/RenderBlock.cpp
r138988 r139040 3072 3072 if (isHorizontalWritingMode()) 3073 3073 return LayoutPoint(point.x(), point.y() + height() - child->renderer()->height() - 2 * yPositionForFloatIncludingMargin(child)); 3074 return LayoutPoint(point.x() + width() - child-> width() - 2 * xPositionForFloatIncludingMargin(child), point.y());3074 return LayoutPoint(point.x() + width() - child->renderer()->width() - 2 * xPositionForFloatIncludingMargin(child), point.y()); 3075 3075 } 3076 3076
Note: See TracChangeset
for help on using the changeset viewer.