Changeset 139043 in webkit


Ignore:
Timestamp:
Jan 8, 2013 12:40:10 AM (11 years ago)
Author:
jochen@chromium.org
Message:

REGRESSION(r139036): 'WebCore::DateTimeSymbolicFieldElement::isInRange' hides overloaded virtual function
​https://bugs.webkit.org/show_bug.cgi?id=106311

Unreviewed build fix.

  • html/shadow/DateTimeSymbolicFieldElement.cpp:

(WebCore::DateTimeSymbolicFieldElement::stepDown):
(WebCore::DateTimeSymbolicFieldElement::stepUp):

  • html/shadow/DateTimeSymbolicFieldElement.h:

(WebCore::DateTimeSymbolicFieldElement::indexIsInRange): renamed method to avoid hiding Element::isInRange

Location:
trunk/Source/WebCore
Files:
3 edited

Legend:

Unmodified
Added
Removed

  • trunk/Source/WebCore/ChangeLog

    r139042 r139043  
     12013-01-08  Jochen Eisinger  <jochen@chromium.org>
     2
     3        REGRESSION(r139036): 'WebCore::DateTimeSymbolicFieldElement::isInRange' hides overloaded virtual function
     4        https://bugs.webkit.org/show_bug.cgi?id=106311
     5
     6        Unreviewed build fix.
     7
     8        * html/shadow/DateTimeSymbolicFieldElement.cpp:
     9        (WebCore::DateTimeSymbolicFieldElement::stepDown):
     10        (WebCore::DateTimeSymbolicFieldElement::stepUp):
     11        * html/shadow/DateTimeSymbolicFieldElement.h:
     12        (WebCore::DateTimeSymbolicFieldElement::indexIsInRange): renamed method to avoid hiding Element::isInRange
     13
    1142013-01-08  Adam Barth  <abarth@webkit.org>
    215

  • trunk/Source/WebCore/html/shadow/DateTimeSymbolicFieldElement.cpp

    r139036 r139043  
    120120{
    121121    if (hasValue()) {
    122         if (!isInRange(--m_selectedIndex))
     122        if (!indexIsInRange(--m_selectedIndex))
    123123            m_selectedIndex = m_maximumIndex;
    124124    } else
    … …  
    130130{
    131131    if (hasValue()) {
    132         if (!isInRange(++m_selectedIndex))
     132        if (!indexIsInRange(++m_selectedIndex))
    133133            m_selectedIndex = m_minimumIndex;
    134134    } else

  • trunk/Source/WebCore/html/shadow/DateTimeSymbolicFieldElement.h

    r139036 r139043  
    5050
    5151    String visibleEmptyValue() const;
    52     bool isInRange(int index) const { return index >= m_minimumIndex && index <= m_maximumIndex; }
     52    bool indexIsInRange(int index) const { return index >= m_minimumIndex && index <= m_maximumIndex; }
    5353
    5454    // DateTimeFieldElement functions.
Note: See TracChangeset for help on using the changeset viewer.