Changeset 139081 in webkit

Timestamp:

Jan 8, 2013 10:54:35 AM (11 years ago)

Author:

zandobersek@gmail.com

Message:

[GTK] Build failures when building with python 3.3
​https://bugs.webkit.org/show_bug.cgi?id=106194

Reviewed by Dirk Pranke.

Python 3.3 introduced changes to dictionaries which can result in changed
iteration order. More about these changes:
​http://docs.python.org/3.3/whatsnew/3.3.html#pep-412-key-sharing-dictionary
​http://www.python.org/dev/peps/pep-0412/#cons

This causes the Source/WebCore/inspector/generate-inspector-protocol-version
script to fail the self-testing when using Python 3.3. These changes work
around this problem by not checking for expected errors in order but rather
for their presence in the error output sequence. The number of actual errors
is also checked to be equal to the number of expected errors.

No new tests - no new functionality.

• inspector/generate-inspector-protocol-version:

(self_test):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• inspector/generate-inspector-protocol-version (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2013-01-08  Zan Dobersek  <zandobersek@gmail.com>
+
+        [GTK] Build failures when building with python 3.3
+        https://bugs.webkit.org/show_bug.cgi?id=106194
+
+        Reviewed by Dirk Pranke.
+
+        Python 3.3 introduced changes to dictionaries which can result in changed
+        iteration order. More about these changes:
+        http://docs.python.org/3.3/whatsnew/3.3.html#pep-412-key-sharing-dictionary
+        http://www.python.org/dev/peps/pep-0412/#cons
+
+        This causes the Source/WebCore/inspector/generate-inspector-protocol-version
+        script to fail the self-testing when using Python 3.3. These changes work
+        around this problem by not checking for expected errors in order but rather
+        for their presence in the error output sequence. The number of actual errors
+        is also checked to be equal to the number of expected errors.
+
+        No new tests - no new functionality.
+
+        * inspector/generate-inspector-protocol-version:
+        (self_test):
+
 2013-01-08  Antoine Quint  <graouts@apple.com>
 

trunk/Source/WebCore/inspector/generate-inspector-protocol-version

@@ -304 +304 @@
         "Network.requestWillBeSent: required parameter is missing: documentURL" ]
     for i in range(len(errors)):
-        if errors[i] != golden_errors[i]:
+        if errors[i] not in golden_errors:
             return False
-    return True
+    return len(errors) is len(golden_errors)
 
 def main():