Changeset 139089 in webkit

Timestamp:

Jan 8, 2013 11:40:40 AM (11 years ago)

Author:

ojan@chromium.org

Message:

text controls are sized too small when a percentage height is set
​https://bugs.webkit.org/show_bug.cgi?id=106277

Reviewed by Tony Chang.

Source/WebCore:

This makes our behavior match Firefox 17, IE 9 and Opera 12.
The current logic came from ​http://trac.webkit.org/changeset/13723,
which itself was copy-pasted from RenderReplaced and no longer has this clause..

Test: fast/forms/percent-height-auto-width-form-controls.html

• rendering/RenderFileUploadControl.cpp:

(WebCore::RenderFileUploadControl::computePreferredLogicalWidths):

• rendering/RenderListBox.cpp:

(WebCore::RenderListBox::computePreferredLogicalWidths):

• rendering/RenderMenuList.cpp:

(WebCore::RenderMenuList::computePreferredLogicalWidths):

• rendering/RenderSlider.cpp:

(WebCore::RenderSlider::computePreferredLogicalWidths):

• rendering/RenderTextControl.cpp:

(WebCore::RenderTextControl::computePreferredLogicalWidths):

LayoutTests:

• fast/forms/percent-height-auto-width-form-controls-expected.txt: Added.
• fast/forms/percent-height-auto-width-form-controls.html: Added.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/fast/forms/percent-height-auto-width-form-controls-expected.txt (added)
• LayoutTests/fast/forms/percent-height-auto-width-form-controls.html (added)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/rendering/RenderFileUploadControl.cpp (modified) (1 diff)
• Source/WebCore/rendering/RenderListBox.cpp (modified) (1 diff)
• Source/WebCore/rendering/RenderMenuList.cpp (modified) (1 diff)
• Source/WebCore/rendering/RenderSlider.cpp (modified) (1 diff)
• Source/WebCore/rendering/RenderTextControl.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2013-01-08  Ojan Vafai  <ojan@chromium.org>
+
+        text controls are sized too small when a percentage height is set
+        https://bugs.webkit.org/show_bug.cgi?id=106277
+
+        Reviewed by Tony Chang.
+
+        * fast/forms/percent-height-auto-width-form-controls-expected.txt: Added.
+        * fast/forms/percent-height-auto-width-form-controls.html: Added.
+
 2013-01-08  Mike West  <mkwst@chromium.org>
 

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2013-01-08  Ojan Vafai  <ojan@chromium.org>
+
+        text controls are sized too small when a percentage height is set
+        https://bugs.webkit.org/show_bug.cgi?id=106277
+
+        Reviewed by Tony Chang.
+
+        This makes our behavior match Firefox 17, IE 9 and Opera 12.
+        The current logic came from http://trac.webkit.org/changeset/13723,
+        which itself was copy-pasted from RenderReplaced and no longer has this clause..
+
+        Test: fast/forms/percent-height-auto-width-form-controls.html
+
+        * rendering/RenderFileUploadControl.cpp:
+        (WebCore::RenderFileUploadControl::computePreferredLogicalWidths):
+        * rendering/RenderListBox.cpp:
+        (WebCore::RenderListBox::computePreferredLogicalWidths):
+        * rendering/RenderMenuList.cpp:
+        (WebCore::RenderMenuList::computePreferredLogicalWidths):
+        * rendering/RenderSlider.cpp:
+        (WebCore::RenderSlider::computePreferredLogicalWidths):
+        * rendering/RenderTextControl.cpp:
+        (WebCore::RenderTextControl::computePreferredLogicalWidths):
+
 2013-01-08  Peter Beverloo  <peter@chromium.org>
 

trunk/Source/WebCore/rendering/RenderFileUploadControl.cpp

@@ -196 +196 @@
         m_maxPreferredLogicalWidth = max(m_maxPreferredLogicalWidth, adjustContentBoxLogicalWidthForBoxSizing(style->minWidth().value()));
         m_minPreferredLogicalWidth = max(m_minPreferredLogicalWidth, adjustContentBoxLogicalWidthForBoxSizing(style->minWidth().value()));
-    } else if (style->width().isPercent() || (style->width().isAuto() && style->height().isPercent()))
+    } else if (style->width().isPercent())
         m_minPreferredLogicalWidth = 0;
     else

trunk/Source/WebCore/rendering/RenderListBox.cpp

@@ -222 +222 @@
         m_maxPreferredLogicalWidth = max(m_maxPreferredLogicalWidth, adjustContentBoxLogicalWidthForBoxSizing(style()->minWidth().value()));
         m_minPreferredLogicalWidth = max(m_minPreferredLogicalWidth, adjustContentBoxLogicalWidthForBoxSizing(style()->minWidth().value()));
-    } else if (style()->width().isPercent() || (style()->width().isAuto() && style()->height().isPercent()))
+    } else if (style()->width().isPercent())
         m_minPreferredLogicalWidth = 0;
     else

trunk/Source/WebCore/rendering/RenderMenuList.cpp

@@ -286 +286 @@
         m_maxPreferredLogicalWidth = max(m_maxPreferredLogicalWidth, adjustContentBoxLogicalWidthForBoxSizing(style()->minWidth().value()));
         m_minPreferredLogicalWidth = max(m_minPreferredLogicalWidth, adjustContentBoxLogicalWidthForBoxSizing(style()->minWidth().value()));
-    } else if (style()->width().isPercent() || (style()->width().isAuto() && style()->height().isPercent()))
+    } else if (style()->width().isPercent())
         m_minPreferredLogicalWidth = 0;
     else

trunk/Source/WebCore/rendering/RenderSlider.cpp

@@ -84 +84 @@
         m_maxPreferredLogicalWidth = max(m_maxPreferredLogicalWidth, adjustContentBoxLogicalWidthForBoxSizing(style()->minWidth().value()));
         m_minPreferredLogicalWidth = max(m_minPreferredLogicalWidth, adjustContentBoxLogicalWidthForBoxSizing(style()->minWidth().value()));
-    } else if (style()->width().isPercent() || (style()->width().isAuto() && style()->height().isPercent()))
+    } else if (style()->width().isPercent())
         m_minPreferredLogicalWidth = 0;
     else

trunk/Source/WebCore/rendering/RenderTextControl.cpp

@@ -275 +275 @@
         m_maxPreferredLogicalWidth = max(m_maxPreferredLogicalWidth, adjustContentBoxLogicalWidthForBoxSizing(style()->minWidth().value()));
         m_minPreferredLogicalWidth = max(m_minPreferredLogicalWidth, adjustContentBoxLogicalWidthForBoxSizing(style()->minWidth().value()));
-    } else if (style()->width().isPercent() || (style()->width().isAuto() && style()->height().isPercent()))
+    } else if (style()->width().isPercent())
         m_minPreferredLogicalWidth = 0;
     else