Changeset 139096 in webkit

Timestamp:

Jan 8, 2013 12:31:37 PM (11 years ago)

Author:

bweinstein@apple.com

Message:

Plug-ins shouldn’t be added to list to autostart if you start a plugin in private browsing.
​https://bugs.webkit.org/show_bug.cgi?id=106348
<rdar://problem/12968442>

Reviewed by Anders Carlsson.

• html/HTMLPlugInImageElement.cpp:

(WebCore::HTMLPlugInImageElement::userDidClickSnapshot): Don't call addAutoStartOrigin if we are

in private browsing mode.

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• html/HTMLPlugInImageElement.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2013-01-08  Brian Weinstein  <bweinstein@apple.com>
+
+        Plug-ins shouldn’t be added to list to autostart if you start a plugin in private browsing.
+        https://bugs.webkit.org/show_bug.cgi?id=106348
+        <rdar://problem/12968442>
+
+        Reviewed by Anders Carlsson.
+
+        * html/HTMLPlugInImageElement.cpp:
+        (WebCore::HTMLPlugInImageElement::userDidClickSnapshot): Don't call addAutoStartOrigin if we are
+            in private browsing mode.
+
 2013-01-08  Chris Fleizach  <cfleizach@apple.com>
 

trunk/Source/WebCore/html/HTMLPlugInImageElement.cpp

@@ -268 +268 @@
 {
     m_pendingClickEventFromSnapshot = event;
-    if (document()->page())
-        document()->page()->plugInClient()->addAutoStartOrigin(document()->page()->mainFrame()->document()->baseURL().host(), m_plugInOriginHash);
+    
+    if (Page* page = document()->page()) {
+        if (!page->settings()->privateBrowsingEnabled())
+            page->plugInClient()->addAutoStartOrigin(document()->page()->mainFrame()->document()->baseURL().host(), m_plugInOriginHash);
+    }
 }