Changeset 139165 in webkit


Ignore:
Timestamp:
Jan 8, 2013 10:42:55 PM (11 years ago)
Author:
crogers@google.com
Message:

Remove unused/deprecated render() method in chromium WebKit API
​https://bugs.webkit.org/show_bug.cgi?id=106399

Reviewed by Kent Tamura.

Source/Platform:

  • chromium/public/WebAudioDevice.h:

Source/WebKit/chromium:

  • src/AudioDestinationChromium.cpp:
  • src/AudioDestinationChromium.h:

(AudioDestinationChromium):

Location:
trunk/Source
Files:
5 edited

Legend:

Unmodified
Added
Removed

  • trunk/Source/Platform/ChangeLog

    r139127 r139165  
     12013-01-08  Chris Rogers  <crogers@google.com>
     2
     3        Remove unused/deprecated render() method in chromium WebKit API
     4        https://bugs.webkit.org/show_bug.cgi?id=106399
     5
     6        Reviewed by Kent Tamura.
     7
     8        * chromium/public/WebAudioDevice.h:
     9
    1102013-01-08  James Robinson  <jamesr@chromium.org>
    211

  • trunk/Source/Platform/chromium/public/WebAudioDevice.h

    r124264 r139165  
    4242        virtual void render(const WebVector<float*>& sourceData, const WebVector<float*>& destinationData, size_t numberOfFrames) { };
    4343
    44         // FIXME: to be removed once we switch over to newer render() method handling both audio output and (optional) input.
    45         virtual void render(const WebVector<float*>& audioData, size_t numberOfFrames) = 0;
    46 
    4744    protected:
    4845        virtual ~RenderCallback() { }

  • trunk/Source/WebKit/chromium/ChangeLog

    r139157 r139165  
     12013-01-08  Chris Rogers  <crogers@google.com>
     2
     3        Remove unused/deprecated render() method in chromium WebKit API
     4        https://bugs.webkit.org/show_bug.cgi?id=106399
     5
     6        Reviewed by Kent Tamura.
     7
     8        * src/AudioDestinationChromium.cpp:
     9        * src/AudioDestinationChromium.h:
     10        (AudioDestinationChromium):
     11
    1122013-01-08  Yoshifumi Inoue  <yosin@chromium.org>
    213

  • trunk/Source/WebKit/chromium/src/AudioDestinationChromium.cpp

    r129835 r139165  
    146146}
    147147
    148 // Pulls on our provider to get the rendered audio stream.
    149 // FIXME: remove this method when the chromium-side switches over to the synchronized I/O render() method (above).
    150 void AudioDestinationChromium::render(const WebVector<float*>& audioData, size_t numberOfFrames)
    151 {
    152     bool isNumberOfChannelsGood = audioData.size() == numberOfChannels;
    153     if (!isNumberOfChannelsGood) {
    154         ASSERT_NOT_REACHED();
    155         return;
    156     }
    157 
    158     bool isBufferSizeGood = numberOfFrames == m_callbackBufferSize;
    159     if (!isBufferSizeGood) {
    160         ASSERT_NOT_REACHED();
    161         return;
    162     }
    163 
    164     m_renderBus.setChannelMemory(0, audioData[0], numberOfFrames);
    165     m_renderBus.setChannelMemory(1, audioData[1], numberOfFrames);
    166     m_fifo->consume(&m_renderBus, numberOfFrames);
    167 }
    168 
    169148void AudioDestinationChromium::provideInput(AudioBus* bus, size_t framesToProcess)
    170149{

  • trunk/Source/WebKit/chromium/src/AudioDestinationChromium.h

    r130448 r139165  
    5959    // WebKit::WebAudioDevice::RenderCallback
    6060    virtual void render(const WebKit::WebVector<float*>& sourceData, const WebKit::WebVector<float*>& audioData, size_t numberOfFrames);
    61     virtual void render(const WebKit::WebVector<float*>& audioData, size_t numberOfFrames);
    6261
    6362    // WebCore::AudioSourceProvider
Note: See TracChangeset for help on using the changeset viewer.