Changeset 139197 in webkit


Ignore:
Timestamp:
Jan 9, 2013 9:29:11 AM (11 years ago)
Author:
zoltan@webkit.org
Message:

[CSS Regions] Selecting text through nested regions causes weird and unclearable selection
https://bugs.webkit.org/show_bug.cgi?id=105641

Reviewed by David Hyatt.

If you have a region with a nested region inside what is rendered below the base region and you are trying select text
starting from the base region and ending it in the nested region, firstly you got a weird selection, secondly you can't
clear the selection. We could prevent this strange behavior by preventing the selection through different region flows.

Source/WebCore:

Test: fast/regions/selecting-text-through-different-region-flows.html

  • rendering/RenderView.cpp:

(WebCore::RenderView::setSelection): Don't allow selection when trying to select different region flows.

LayoutTests:

  • fast/regions/selecting-text-through-different-region-flows-expected.txt: Added.
  • fast/regions/selecting-text-through-different-region-flows.html: Added.
  • platform/chromium-mac/fast/regions/selecting-text-through-different-region-flows-expected.png: Added.
Location:
trunk
Files:
3 added
3 edited

Legend:

Unmodified
Added
Removed
  • trunk/LayoutTests/ChangeLog

    r139191 r139197  
     12013-01-09  Zoltan Horvath  <zoltan@webkit.org>
     2
     3        [CSS Regions] Selecting text through nested regions causes weird and unclearable selection 
     4        https://bugs.webkit.org/show_bug.cgi?id=105641
     5
     6        Reviewed by David Hyatt.
     7
     8        If you have a region with a nested region inside what is rendered below the base region and you are trying select text
     9        starting from the base region and ending it in the nested region, firstly you got a weird selection, secondly you can't
     10        clear the selection. We could prevent this strange behavior by preventing the selection through different region flows.
     11
     12        * fast/regions/selecting-text-through-different-region-flows-expected.txt: Added.
     13        * fast/regions/selecting-text-through-different-region-flows.html: Added.
     14        * platform/chromium-mac/fast/regions/selecting-text-through-different-region-flows-expected.png: Added.
     15
    1162013-01-09  Florin Malita  <fmalita@chromium.org>
    217
  • trunk/Source/WebCore/ChangeLog

    r139196 r139197  
     12013-01-09  Zoltan Horvath  <zoltan@webkit.org>
     2
     3        [CSS Regions] Selecting text through nested regions causes weird and unclearable selection 
     4        https://bugs.webkit.org/show_bug.cgi?id=105641
     5
     6        Reviewed by David Hyatt.
     7
     8        If you have a region with a nested region inside what is rendered below the base region and you are trying select text
     9        starting from the base region and ending it in the nested region, firstly you got a weird selection, secondly you can't
     10        clear the selection. We could prevent this strange behavior by preventing the selection through different region flows.
     11
     12        Test: fast/regions/selecting-text-through-different-region-flows.html
     13
     14        * rendering/RenderView.cpp:
     15        (WebCore::RenderView::setSelection): Don't allow selection when trying to select different region flows.
     16
    1172013-01-09  Hugo Parente Lima  <hugo.lima@openbossa.org>
    218
  • trunk/Source/WebCore/rendering/RenderView.cpp

    r139192 r139197  
    573573        return;
    574574
     575    if ((start && end) && (start->enclosingRenderFlowThread() != end->enclosingRenderFlowThread()))
     576        return;
     577
    575578    // Record the old selected objects.  These will be used later
    576579    // when we compare against the new selected objects.
Note: See TracChangeset for help on using the changeset viewer.