Changeset 139203 in webkit

Timestamp:

Jan 9, 2013 10:10:34 AM (11 years ago)

Author:

ojan@chromium.org

Message:

Source/WebCore: marquee special-case in RenderBlock is not needed
​https://bugs.webkit.org/show_bug.cgi?id=106396

Reviewed by Simon Fraser.

This was added in ​http://trac.webkit.org/changeset/105772. The layout test
in that patch (which is disabled) works and the original site that was broken
also still works.

• rendering/RenderBlock.cpp:

(WebCore::RenderBlock::computePreferredLogicalWidths):

LayoutTests: Implement CSS computed style value for transition shorthand
​https://bugs.webkit.org/show_bug.cgi?id=105035

Patch by Alexis Menard <​alexis@webkit.org> on 2013-01-09
Reviewed by Dean Jackson.

Uncomment existing tests to cover the new feature.

• transitions/transitions-parsing-expected.txt:
• transitions/transitions-parsing.html:

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/rendering/RenderBlock.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2013-01-09  Alexis Menard  <alexis@webkit.org>
+
+        Implement CSS computed style value for transition shorthand
+        https://bugs.webkit.org/show_bug.cgi?id=105035
+
+        Reviewed by Dean Jackson.
+
+        Uncomment existing tests to cover the new feature.
+
+        * transitions/transitions-parsing-expected.txt:
+        * transitions/transitions-parsing.html:
+
 2013-01-09  Tony Chang  <tony@chromium.org>
 

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2013-01-09  Ojan Vafai  <ojan@chromium.org>
+
+        marquee special-case in RenderBlock is not needed
+        https://bugs.webkit.org/show_bug.cgi?id=106396
+
+        Reviewed by Simon Fraser.
+
+        This was added in http://trac.webkit.org/changeset/105772. The layout test
+        in that patch (which is disabled) works and the original site that was broken
+        also still works.
+
+        * rendering/RenderBlock.cpp:
+        (WebCore::RenderBlock::computePreferredLogicalWidths):
+
+2013-01-09  Alexis Menard  <alexis@webkit.org>
+
+        Implement CSS computed style value for transition shorthand
+        https://bugs.webkit.org/show_bug.cgi?id=105035
+
+        Reviewed by Dean Jackson.
+
+        Implement support for query the transition and webkit-transition
+        shorthand from the computed style.
+
+        Test: transitions/transitions-parsing.html
+
+        * css/CSSComputedStyleDeclaration.cpp:
+        (WebCore::createTransitionPropertyValue): Factor the code to create the
+        correct value into a function to reuse it for the shorthand.
+        (WebCore::getTransitionPropertyValue):
+        (WebCore::createTimingFunctionValue): Little refactor, the intermediate
+        local variables are not needed.
+        (WebCore::getTimingFunctionValue):
+        (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
+
 2013-01-09  Tony Chang  <tony@chromium.org>
 

trunk/Source/WebCore/rendering/RenderBlock.cpp

@@ -5584 +5584 @@
     RenderStyle* styleToUse = style();
     if (!isTableCell() && styleToUse->logicalWidth().isFixed() && styleToUse->logicalWidth().value() >= 0 
-       && style()->marqueeBehavior() != MALTERNATE && !(isDeprecatedFlexItem() && !styleToUse->logicalWidth().intValue()))
+        && !(isDeprecatedFlexItem() && !styleToUse->logicalWidth().intValue()))
         m_minPreferredLogicalWidth = m_maxPreferredLogicalWidth = adjustContentBoxLogicalWidthForBoxSizing(styleToUse->logicalWidth().value());
     else {