Changeset 139219 in webkit

Timestamp:

Jan 9, 2013 12:12:02 PM (11 years ago)

Author:

commit-queue@webkit.org

Message:

IndexedDB: Remove unnecessary tests from storage/indexeddb/key-type-array.html
​https://bugs.webkit.org/show_bug.cgi?id=106472

Patch by Michael Pruett <​michael@68k.org> on 2013-01-09
Reviewed by Tony Chang.

The tests which verify that JSON.stringify() throws an exception
for cyclic objects produce different error messages on JSC and
V8 and do nothing to test IndexedDB functionality. These tests
should be removed.

• storage/indexeddb/key-type-array-expected.txt:
• storage/indexeddb/resources/key-type-array.js:

Location:

trunk/LayoutTests

Files:

• ChangeLog (modified) (1 diff)
• storage/indexeddb/key-type-array-expected.txt (modified) (1 diff)
• storage/indexeddb/resources/key-type-array.js (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2013-01-09  Michael Pruett  <michael@68k.org>
+
+        IndexedDB: Remove unnecessary tests from storage/indexeddb/key-type-array.html
+        https://bugs.webkit.org/show_bug.cgi?id=106472
+
+        Reviewed by Tony Chang.
+
+        The tests which verify that JSON.stringify() throws an exception
+        for cyclic objects produce different error messages on JSC and
+        V8 and do nothing to test IndexedDB functionality. These tests
+        should be removed.
+
+        * storage/indexeddb/key-type-array-expected.txt:
+        * storage/indexeddb/resources/key-type-array.js:
+
 2013-01-08  Ojan Vafai  <ojan@chromium.org>
 

trunk/LayoutTests/storage/indexeddb/key-type-array-expected.txt

@@ -159 +159 @@
 array that contains itself: array = [ array ]
 cyclic_array = []; cyclic_array.push(cyclic_array)
-PASS JSON.stringify(cyclic_array) threw exception TypeError: Converting circular structure to JSON.
 array that contains itself, one level down: array = [ [ array ] ]
 cyclic_array2 = []; cyclic_array2.push([cyclic_array2])
-PASS JSON.stringify(cyclic_array2) threw exception TypeError: Converting circular structure to JSON.
 array that contains itself, not as first element: array = [1, 'b', [], array]
 cyclic_array3 = [1, 'b', []]; cyclic_array3.push(cyclic_array3)
-PASS JSON.stringify(cyclic_array3) threw exception TypeError: Converting circular structure to JSON.
-
 array that contains array that contains itself
 cyclic_array4 = [cyclic_array];
-PASS JSON.stringify(cyclic_array4) threw exception TypeError: Converting circular structure to JSON.
 
 testing invalid array key: [ void 0 ]

trunk/LayoutTests/storage/indexeddb/resources/key-type-array.js

@@ -106 +106 @@
     debug("array that contains itself: array = [ array ]");
     evalAndLog("cyclic_array = []; cyclic_array.push(cyclic_array)");
-    shouldThrow("JSON.stringify(cyclic_array)");
 
     debug("array that contains itself, one level down: array = [ [ array ] ]");
     evalAndLog("cyclic_array2 = []; cyclic_array2.push([cyclic_array2])");
-    shouldThrow("JSON.stringify(cyclic_array2)");
 
     debug("array that contains itself, not as first element: array = [1, 'b', [], array]");
     evalAndLog("cyclic_array3 = [1, 'b', []]; cyclic_array3.push(cyclic_array3)");
-    shouldThrow("JSON.stringify(cyclic_array3)");
-    debug("");
 
     debug("array that contains array that contains itself");
     evalAndLog("cyclic_array4 = [cyclic_array];");
-    shouldThrow("JSON.stringify(cyclic_array4)");
     debug("");