Changeset 139256 in webkit


Ignore:
Timestamp:
Jan 9, 2013 4:44:57 PM (11 years ago)
Author:
tasak@google.com
Message:

border-radius with box-shadow is not rendered correctly
​https://bugs.webkit.org/show_bug.cgi?id=106404

Reviewed by Hajime Morita.

Source/WebCore:

RoundedRect::isRenderable is wrong. So RoundedRect::adjustRadii
is invoked for renderable RoundedRects.

Test: fast/borders/border-radius-with-box-shadow.html

  • platform/graphics/RoundedRect.cpp:

(WebCore::RoundedRect::isRenderable):
Have to compare topLeft's height plus bottomLeft's height with
rect's height and to compare topRight's height plus bottomRight's
height with rect's height.

LayoutTests:

  • fast/borders/border-radius-with-box-shadow-expected.txt: Added.
  • fast/borders/border-radius-with-box-shadow.html: Added.
  • platform/chromium-linux/fast/borders/border-radius-with-box-shadow-expected.png: Added.
Location:
trunk
Files:
3 added
3 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r139255 r139256  
     12013-01-09  Takashi Sakamoto  <tasak@google.com>
     2
     3        border-radius with box-shadow is not rendered correctly
     4        https://bugs.webkit.org/show_bug.cgi?id=106404
     5
     6        Reviewed by Hajime Morita.
     7
     8        * fast/borders/border-radius-with-box-shadow-expected.txt: Added.
     9        * fast/borders/border-radius-with-box-shadow.html: Added.
     10        * platform/chromium-linux/fast/borders/border-radius-with-box-shadow-expected.png: Added.
     11
    1122013-01-09  Anders Carlsson  <andersca@apple.com>
    213

  • trunk/Source/WebCore/ChangeLog

    r139250 r139256  
     12013-01-09  Takashi Sakamoto  <tasak@google.com>
     2
     3        border-radius with box-shadow is not rendered correctly
     4        https://bugs.webkit.org/show_bug.cgi?id=106404
     5
     6        Reviewed by Hajime Morita.
     7
     8        RoundedRect::isRenderable is wrong. So RoundedRect::adjustRadii
     9        is invoked for renderable RoundedRects.
     10
     11        Test: fast/borders/border-radius-with-box-shadow.html
     12
     13        * platform/graphics/RoundedRect.cpp:
     14        (WebCore::RoundedRect::isRenderable):
     15        Have to compare topLeft's height plus bottomLeft's height with
     16        rect's height and to compare topRight's height plus bottomRight's
     17        height with rect's height.
     18
    1192013-01-09  Joanmarie Diggs  <jdiggs@igalia.com>
    220

  • trunk/Source/WebCore/platform/graphics/RoundedRect.cpp

    r125304 r139256  
    159159    return m_radii.topLeft().width() + m_radii.topRight().width() <= m_rect.width()
    160160        && m_radii.bottomLeft().width() + m_radii.bottomRight().width() <= m_rect.width()
    161         && m_radii.topLeft().height() + m_radii.topRight().height() <= m_rect.height()
    162         && m_radii.bottomLeft().height() + m_radii.bottomRight().height() <= m_rect.height();
     161        && m_radii.topLeft().height() + m_radii.bottomLeft().height() <= m_rect.height()
     162        && m_radii.topRight().height() + m_radii.bottomRight().height() <= m_rect.height();
    163163}
    164164
Note: See TracChangeset for help on using the changeset viewer.